[
https://issues.apache.org/jira/browse/YARN-10780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17369025#comment-17369025
]
Peter Bacsko commented on YARN-10780:
-
+1
Thanks [~gandras], latest patch LGTM.
Committed to trunk.
[
https://issues.apache.org/jira/browse/YARN-10780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17367423#comment-17367423
]
Hadoop QA commented on YARN-10780:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/YARN-10780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17367265#comment-17367265
]
Andras Gyori commented on YARN-10780:
-
Thank you [~pbacsko] uploaded a new revision.
> Optimise
[
https://issues.apache.org/jira/browse/YARN-10780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17367259#comment-17367259
]
Peter Bacsko commented on YARN-10780:
-
[~gandras] looks good, could you take care of the checkstyle
[
https://issues.apache.org/jira/browse/YARN-10780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17367184#comment-17367184
]
Hadoop QA commented on YARN-10780:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-10780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366498#comment-17366498
]
Hadoop QA commented on YARN-10780:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-10780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17366400#comment-17366400
]
Andras Gyori commented on YARN-10780:
-
Thank you [~pbacsko] for the review. I have incorporated your
[
https://issues.apache.org/jira/browse/YARN-10780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360012#comment-17360012
]
Andras Gyori commented on YARN-10780:
-
Some of the logic is replicated in YARN-10801, therefore I
[
https://issues.apache.org/jira/browse/YARN-10780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17355823#comment-17355823
]
Hadoop QA commented on YARN-10780:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/YARN-10780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17355796#comment-17355796
]
Peter Bacsko commented on YARN-10780:
-
Ok, I went through the patch. I'm not saying that I have 100%
[
https://issues.apache.org/jira/browse/YARN-10780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17355775#comment-17355775
]
Peter Bacsko commented on YARN-10780:
-
There are a lot of NPE at {{serviceStop()}}, [~gandras] could
[
https://issues.apache.org/jira/browse/YARN-10780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17354394#comment-17354394
]
Hadoop QA commented on YARN-10780:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
12 matches
Mail list logo