[
https://issues.apache.org/jira/browse/YARN-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13823661#comment-13823661
]
Hudson commented on YARN-1222:
--
FAILURE: Integrated in Hadoop-Mapreduce-trunk #1609 (See
[htt
[
https://issues.apache.org/jira/browse/YARN-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13823642#comment-13823642
]
Hudson commented on YARN-1222:
--
FAILURE: Integrated in Hadoop-Hdfs-trunk #1583 (See
[https://
[
https://issues.apache.org/jira/browse/YARN-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13823558#comment-13823558
]
Hudson commented on YARN-1222:
--
SUCCESS: Integrated in Hadoop-Yarn-trunk #392 (See
[https://b
[
https://issues.apache.org/jira/browse/YARN-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13822693#comment-13822693
]
Hudson commented on YARN-1222:
--
SUCCESS: Integrated in Hadoop-trunk-Commit #4738 (See
[https:
[
https://issues.apache.org/jira/browse/YARN-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13822681#comment-13822681
]
Bikas Saha commented on YARN-1222:
--
+1 thanks! committed to trunk and branch-2
> Make imp
[
https://issues.apache.org/jira/browse/YARN-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13820697#comment-13820697
]
Hadoop QA commented on YARN-1222:
-
{color:green}+1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13820585#comment-13820585
]
Karthik Kambatla commented on YARN-1222:
bq. To be clear I meant the HAUtil.verifyA
[
https://issues.apache.org/jira/browse/YARN-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13820556#comment-13820556
]
Bikas Saha commented on YARN-1222:
--
To be clear I meant the HAUtil.verifyAndSetAllRpcAddre
[
https://issues.apache.org/jira/browse/YARN-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13820552#comment-13820552
]
Karthik Kambatla commented on YARN-1222:
bq. Can you please look at why the findbug
[
https://issues.apache.org/jira/browse/YARN-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13820311#comment-13820311
]
Hadoop QA commented on YARN-1222:
-
{color:red}-1 overall{color}. Here are the results of t
[
https://issues.apache.org/jira/browse/YARN-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13820289#comment-13820289
]
Bikas Saha commented on YARN-1222:
--
Why not use the helper method that we have to do this
[
https://issues.apache.org/jira/browse/YARN-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13820273#comment-13820273
]
Bikas Saha commented on YARN-1222:
--
I am afraid the lock looks deadlock prone. many places
[
https://issues.apache.org/jira/browse/YARN-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13820036#comment-13820036
]
Karthik Kambatla commented on YARN-1222:
Thanks Bikas. The new patch addresses all
[
https://issues.apache.org/jira/browse/YARN-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13819895#comment-13819895
]
Bikas Saha commented on YARN-1222:
--
Looks good.
Some minor comments.
In default fencing,
[
https://issues.apache.org/jira/browse/YARN-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13818796#comment-13818796
]
Hadoop QA commented on YARN-1222:
-
{color:green}+1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13818766#comment-13818766
]
Hadoop QA commented on YARN-1222:
-
{color:red}-1 overall{color}. Here are the results of t
[
https://issues.apache.org/jira/browse/YARN-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13818424#comment-13818424
]
Hadoop QA commented on YARN-1222:
-
{color:red}-1 overall{color}. Here are the results of t
[
https://issues.apache.org/jira/browse/YARN-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13817560#comment-13817560
]
Bikas Saha commented on YARN-1222:
--
Quick comments
1) The new event is not following the c
[
https://issues.apache.org/jira/browse/YARN-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13815280#comment-13815280
]
Bikas Saha commented on YARN-1222:
--
bq. Post YARN-1318, I think RMStateStore constructor s
[
https://issues.apache.org/jira/browse/YARN-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13814596#comment-13814596
]
Karthik Kambatla commented on YARN-1222:
bq. Thinking aloud, using HAServiceTarget
[
https://issues.apache.org/jira/browse/YARN-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13814425#comment-13814425
]
Bikas Saha commented on YARN-1222:
--
REQUEST_BY_USER_FORCED is probably not the right choic
[
https://issues.apache.org/jira/browse/YARN-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13814108#comment-13814108
]
Bikas Saha commented on YARN-1222:
--
Lets make that clear in the yarn-site/configuration.
[
https://issues.apache.org/jira/browse/YARN-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13814102#comment-13814102
]
Karthik Kambatla commented on YARN-1222:
bq. Where is the shared rm-admin-acl being
[
https://issues.apache.org/jira/browse/YARN-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13814092#comment-13814092
]
Bikas Saha commented on YARN-1222:
--
bq. The root-node ACLs are per RM instance. They need
[
https://issues.apache.org/jira/browse/YARN-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13814065#comment-13814065
]
Karthik Kambatla commented on YARN-1222:
Thanks [~bikassaha] for the close review.
[
https://issues.apache.org/jira/browse/YARN-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13813716#comment-13813716
]
Bikas Saha commented on YARN-1222:
--
@Private? {code}+ public static String getConfValueFo
[
https://issues.apache.org/jira/browse/YARN-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13813274#comment-13813274
]
Hadoop QA commented on YARN-1222:
-
{color:red}-1 overall{color}. Here are the results of t
[
https://issues.apache.org/jira/browse/YARN-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13812664#comment-13812664
]
Karthik Kambatla commented on YARN-1222:
Addressed other comments. Working on a tes
[
https://issues.apache.org/jira/browse/YARN-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13812663#comment-13812663
]
Karthik Kambatla commented on YARN-1222:
bq. deleteWithRetries() - The new logic do
[
https://issues.apache.org/jira/browse/YARN-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13803559#comment-13803559
]
Tsuyoshi OZAWA commented on YARN-1222:
--
{code}
Based on reading this patch YARN-1307 n
[
https://issues.apache.org/jira/browse/YARN-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13800376#comment-13800376
]
Bikas Saha commented on YARN-1222:
--
Lets put some javadoc and comments saying that the int
[
https://issues.apache.org/jira/browse/YARN-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13799504#comment-13799504
]
Sandy Ryza commented on YARN-1222:
--
{code}
LOG.error("Error in storing master key w
[
https://issues.apache.org/jira/browse/YARN-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13798399#comment-13798399
]
Hadoop QA commented on YARN-1222:
-
{color:red}-1 overall{color}. Here are the results of t
[
https://issues.apache.org/jira/browse/YARN-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13798372#comment-13798372
]
Karthik Kambatla commented on YARN-1222:
Thanks [~bikassaha]. The patch is exactly
[
https://issues.apache.org/jira/browse/YARN-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13798363#comment-13798363
]
Bikas Saha commented on YARN-1222:
--
I havent seen the patch. I would expect that logical s
[
https://issues.apache.org/jira/browse/YARN-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13798325#comment-13798325
]
Karthik Kambatla commented on YARN-1222:
Have tested this manually on a cluster and
[
https://issues.apache.org/jira/browse/YARN-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13798270#comment-13798270
]
Tsuyoshi OZAWA commented on YARN-1222:
--
In YARN-1307, [~kkambatl] mentioned that the p
[
https://issues.apache.org/jira/browse/YARN-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13798062#comment-13798062
]
Karthik Kambatla commented on YARN-1222:
Yep. It is better to work on them sequenti
[
https://issues.apache.org/jira/browse/YARN-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13797483#comment-13797483
]
Vinod Kumar Vavilapalli commented on YARN-1222:
---
I meant blocking w.r.t the i
[
https://issues.apache.org/jira/browse/YARN-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13797473#comment-13797473
]
Bikas Saha commented on YARN-1222:
--
This is related but shouldnt be blocked. This jira is
[
https://issues.apache.org/jira/browse/YARN-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13797471#comment-13797471
]
Vinod Kumar Vavilapalli commented on YARN-1222:
---
I think this should be block
[
https://issues.apache.org/jira/browse/YARN-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13774658#comment-13774658
]
Karthik Kambatla commented on YARN-1222:
Another approach we could take is let the
[
https://issues.apache.org/jira/browse/YARN-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13774276#comment-13774276
]
Karthik Kambatla commented on YARN-1222:
By the way, for now I am using the RM_HA_A
[
https://issues.apache.org/jira/browse/YARN-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13774273#comment-13774273
]
Karthik Kambatla commented on YARN-1222:
bq. We should be storing the information i
[
https://issues.apache.org/jira/browse/YARN-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13774210#comment-13774210
]
Karthik Kambatla commented on YARN-1222:
While working on fencing aspects of ZKRMSt
[
https://issues.apache.org/jira/browse/YARN-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13772273#comment-13772273
]
Bikas Saha commented on YARN-1222:
--
Other improvements carried over from YARN-353
We shoul
46 matches
Mail list logo
