[jira] [Commented] (YARN-1574) When RM transit from Active to Standby, the same eventDispatcher should not be registered more than once

2014-01-10 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-1574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13868227#comment-13868227 ] Hadoop QA commented on YARN-1574: - {color:red}-1 overall{color}. Here are the results of t

[jira] [Commented] (YARN-1574) When RM transit from Active to Standby, the same eventDispatcher should not be registered more than once

2014-01-10 Thread Xuan Gong (JIRA)
[ https://issues.apache.org/jira/browse/YARN-1574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13868172#comment-13868172 ] Xuan Gong commented on YARN-1574: - bq. any manual testing to verify no leak of dispatchers?

[jira] [Commented] (YARN-1574) When RM transit from Active to Standby, the same eventDispatcher should not be registered more than once

2014-01-10 Thread Xuan Gong (JIRA)
[ https://issues.apache.org/jira/browse/YARN-1574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13868137#comment-13868137 ] Xuan Gong commented on YARN-1574: - bq. Quickly looked at the patch, would be nice to add a

[jira] [Commented] (YARN-1574) When RM transit from Active to Standby, the same eventDispatcher should not be registered more than once

2014-01-10 Thread Karthik Kambatla (JIRA)
[ https://issues.apache.org/jira/browse/YARN-1574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13868115#comment-13868115 ] Karthik Kambatla commented on YARN-1574: Quickly looked at the patch, would be nice

[jira] [Commented] (YARN-1574) When RM transit from Active to Standby, the same eventDispatcher should not be registered more than once

2014-01-10 Thread Karthik Kambatla (JIRA)
[ https://issues.apache.org/jira/browse/YARN-1574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13868112#comment-13868112 ] Karthik Kambatla commented on YARN-1574: [~xgong] - any manual testing to verify no

[jira] [Commented] (YARN-1574) When RM transit from Active to Standby, the same eventDispatcher should not be registered more than once

2014-01-10 Thread Xuan Gong (JIRA)
[ https://issues.apache.org/jira/browse/YARN-1574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13868101#comment-13868101 ] Xuan Gong commented on YARN-1574: - [~kkambatl] Could you take a look at the latest patch ?

[jira] [Commented] (YARN-1574) When RM transit from Active to Standby, the same eventDispatcher should not be registered more than once

2014-01-09 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-1574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13867497#comment-13867497 ] Hadoop QA commented on YARN-1574: - {color:green}+1 overall{color}. Here are the results of

[jira] [Commented] (YARN-1574) When RM transit from Active to Standby, the same eventDispatcher should not be registered more than once

2014-01-09 Thread Xuan Gong (JIRA)
[ https://issues.apache.org/jira/browse/YARN-1574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13867473#comment-13867473 ] Xuan Gong commented on YARN-1574: - bq. I should have thought of this earlier - we should re

[jira] [Commented] (YARN-1574) When RM transit from Active to Standby, the same eventDispatcher should not be registered more than once

2014-01-09 Thread Karthik Kambatla (JIRA)
[ https://issues.apache.org/jira/browse/YARN-1574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13867371#comment-13867371 ] Karthik Kambatla commented on YARN-1574: Yes. Indeed. > When RM transit from Acti

[jira] [Commented] (YARN-1574) When RM transit from Active to Standby, the same eventDispatcher should not be registered more than once

2014-01-09 Thread Xuan Gong (JIRA)
[ https://issues.apache.org/jira/browse/YARN-1574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13867366#comment-13867366 ] Xuan Gong commented on YARN-1574: - [~kkambatl] bq. I also noticed CompositeService#removeSe

[jira] [Commented] (YARN-1574) When RM transit from Active to Standby, the same eventDispatcher should not be registered more than once

2014-01-09 Thread Karthik Kambatla (JIRA)
[ https://issues.apache.org/jira/browse/YARN-1574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13867169#comment-13867169 ] Karthik Kambatla commented on YARN-1574: The test looks much cleaner now. I shoul

[jira] [Commented] (YARN-1574) When RM transit from Active to Standby, the same eventDispatcher should not be registered more than once

2014-01-09 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-1574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13866885#comment-13866885 ] Hadoop QA commented on YARN-1574: - {color:green}+1 overall{color}. Here are the results of

[jira] [Commented] (YARN-1574) When RM transit from Active to Standby, the same eventDispatcher should not be registered more than once

2014-01-09 Thread Xuan Gong (JIRA)
[ https://issues.apache.org/jira/browse/YARN-1574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13866855#comment-13866855 ] Xuan Gong commented on YARN-1574: - Thanks for the review. The new patch addresses all the l

[jira] [Commented] (YARN-1574) When RM transit from Active to Standby, the same eventDispatcher should not be registered more than once

2014-01-08 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-1574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13866415#comment-13866415 ] Hadoop QA commented on YARN-1574: - {color:red}-1 overall{color}. Here are the results of t

[jira] [Commented] (YARN-1574) When RM transit from Active to Standby, the same eventDispatcher should not be registered more than once

2014-01-08 Thread Karthik Kambatla (JIRA)
[ https://issues.apache.org/jira/browse/YARN-1574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13866411#comment-13866411 ] Karthik Kambatla commented on YARN-1574: Nice test, may be we can simplify it furth

[jira] [Commented] (YARN-1574) When RM transit from Active to Standby, the same eventDispatcher should not be registered more than once

2014-01-08 Thread Xuan Gong (JIRA)
[ https://issues.apache.org/jira/browse/YARN-1574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13866397#comment-13866397 ] Xuan Gong commented on YARN-1574: - bq. We should be careful and make sure all AlwaysOn serv

[jira] [Commented] (YARN-1574) When RM transit from Active to Standby, the same eventDispatcher should not be registered more than once

2014-01-08 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-1574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13866304#comment-13866304 ] Hadoop QA commented on YARN-1574: - {color:red}-1 overall{color}. Here are the results of t

[jira] [Commented] (YARN-1574) When RM transit from Active to Standby, the same eventDispatcher should not be registered more than once

2014-01-08 Thread Karthik Kambatla (JIRA)
[ https://issues.apache.org/jira/browse/YARN-1574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13866282#comment-13866282 ] Karthik Kambatla commented on YARN-1574: bq. I think that they are fine because all

[jira] [Commented] (YARN-1574) When RM transit from Active to Standby, the same eventDispatcher should not be registered more than once

2014-01-08 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-1574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13866271#comment-13866271 ] Hadoop QA commented on YARN-1574: - {color:red}-1 overall{color}. Here are the results of t

[jira] [Commented] (YARN-1574) When RM transit from Active to Standby, the same eventDispatcher should not be registered more than once

2014-01-08 Thread Xuan Gong (JIRA)
[ https://issues.apache.org/jira/browse/YARN-1574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13866156#comment-13866156 ] Xuan Gong commented on YARN-1574: - bq. It is probably better to cast to Service instead of

[jira] [Commented] (YARN-1574) When RM transit from Active to Standby, the same eventDispatcher should not be registered more than once

2014-01-08 Thread Karthik Kambatla (JIRA)
[ https://issues.apache.org/jira/browse/YARN-1574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13866111#comment-13866111 ] Karthik Kambatla commented on YARN-1574: Approach looks reasonable. Comments: # It

[jira] [Commented] (YARN-1574) When RM transit from Active to Standby, the same eventDispatcher should not be registered more than once

2014-01-08 Thread Xuan Gong (JIRA)
[ https://issues.apache.org/jira/browse/YARN-1574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13866098#comment-13866098 ] Xuan Gong commented on YARN-1574: - [~kkambatl] Could you take a look ? > When RM transit

[jira] [Commented] (YARN-1574) When RM transit from Active to Standby, the same eventDispatcher should not be registered more than once

2014-01-08 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-1574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13866089#comment-13866089 ] Hadoop QA commented on YARN-1574: - {color:red}-1 overall{color}. Here are the results of t

[jira] [Commented] (YARN-1574) When RM transit from Active to Standby, the same eventDispatcher should not be registered more than once

2014-01-08 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-1574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13866056#comment-13866056 ] Hadoop QA commented on YARN-1574: - {color:red}-1 overall{color}. Here are the results of t

[jira] [Commented] (YARN-1574) When RM transit from Active to Standby, the same eventDispatcher should not be registered more than once

2014-01-08 Thread Xuan Gong (JIRA)
[ https://issues.apache.org/jira/browse/YARN-1574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13866042#comment-13866042 ] Xuan Gong commented on YARN-1574: - +1 on option2. But I think that the resetDispatcher meth

[jira] [Commented] (YARN-1574) When RM transit from Active to Standby, the same eventDispatcher should not be registered more than once

2014-01-08 Thread Karthik Kambatla (JIRA)
[ https://issues.apache.org/jira/browse/YARN-1574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13865780#comment-13865780 ] Karthik Kambatla commented on YARN-1574: [~xgong], [~bikassaha] - what do you think

[jira] [Commented] (YARN-1574) When RM transit from Active to Standby, the same eventDispatcher should not be registered more than once

2014-01-08 Thread Karthik Kambatla (JIRA)
[ https://issues.apache.org/jira/browse/YARN-1574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13865773#comment-13865773 ] Karthik Kambatla commented on YARN-1574: Good catch, [~xgong]. I see two ways of ha

[jira] [Commented] (YARN-1574) When RM transit from Active to Standby, the same eventDispatcher should not be registered more than once

2014-01-08 Thread Xuan Gong (JIRA)
[ https://issues.apache.org/jira/browse/YARN-1574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13865741#comment-13865741 ] Xuan Gong commented on YARN-1574: - For example, we have two RMs, RM1 and RM2, and one NM. W