[jira] [Commented] (YARN-2030) Use StateMachine to simplify handleStoreEvent() in RMStateStore

2014-06-10 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14026336#comment-14026336 ] Hudson commented on YARN-2030: -- FAILURE: Integrated in Hadoop-Yarn-trunk #579 (See

[jira] [Commented] (YARN-2030) Use StateMachine to simplify handleStoreEvent() in RMStateStore

2014-06-10 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14026453#comment-14026453 ] Hudson commented on YARN-2030: -- FAILURE: Integrated in Hadoop-Hdfs-trunk #1770 (See

[jira] [Commented] (YARN-2030) Use StateMachine to simplify handleStoreEvent() in RMStateStore

2014-06-09 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14025421#comment-14025421 ] Jian He commented on YARN-2030: --- Patch looks good to me, did a minor rename from operand -

[jira] [Commented] (YARN-2030) Use StateMachine to simplify handleStoreEvent() in RMStateStore

2014-06-09 Thread Vinod Kumar Vavilapalli (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14025451#comment-14025451 ] Vinod Kumar Vavilapalli commented on YARN-2030: --- Quickly looked at it. Fine

[jira] [Commented] (YARN-2030) Use StateMachine to simplify handleStoreEvent() in RMStateStore

2014-06-09 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14025599#comment-14025599 ] Jian He commented on YARN-2030: --- Committing this. Filed YARN-2136 for handling events at

[jira] [Commented] (YARN-2030) Use StateMachine to simplify handleStoreEvent() in RMStateStore

2014-06-09 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14025626#comment-14025626 ] Jian He commented on YARN-2030: --- Noticed an existing issue that the storedException passed

[jira] [Commented] (YARN-2030) Use StateMachine to simplify handleStoreEvent() in RMStateStore

2014-06-09 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14025648#comment-14025648 ] Jian He commented on YARN-2030: --- Opened YARN-2138 for handling un-handled store op failed

[jira] [Commented] (YARN-2030) Use StateMachine to simplify handleStoreEvent() in RMStateStore

2014-06-09 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14026005#comment-14026005 ] Hudson commented on YARN-2030: -- SUCCESS: Integrated in Hadoop-trunk-Commit #5672 (See

[jira] [Commented] (YARN-2030) Use StateMachine to simplify handleStoreEvent() in RMStateStore

2014-06-08 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14021156#comment-14021156 ] Hadoop QA commented on YARN-2030: - {color:green}+1 overall{color}. Here are the results of

[jira] [Commented] (YARN-2030) Use StateMachine to simplify handleStoreEvent() in RMStateStore

2014-06-07 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14020741#comment-14020741 ] Hadoop QA commented on YARN-2030: - {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (YARN-2030) Use StateMachine to simplify handleStoreEvent() in RMStateStore

2014-06-05 Thread Junping Du (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14018758#comment-14018758 ] Junping Du commented on YARN-2030: -- bq. Junping Du, can you help with the review and

[jira] [Commented] (YARN-2030) Use StateMachine to simplify handleStoreEvent() in RMStateStore

2014-06-05 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14019581#comment-14019581 ] Jian He commented on YARN-2030: --- I see, thanks for the update. Maybe just promote getProto()

[jira] [Commented] (YARN-2030) Use StateMachine to simplify handleStoreEvent() in RMStateStore

2014-06-05 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14019588#comment-14019588 ] Jian He commented on YARN-2030: --- I meant add an abstract getProto method. Use StateMachine

[jira] [Commented] (YARN-2030) Use StateMachine to simplify handleStoreEvent() in RMStateStore

2014-06-04 Thread Junping Du (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14018335#comment-14018335 ] Junping Du commented on YARN-2030: -- [~decster], I think He Jian was reviewing your patch.

[jira] [Commented] (YARN-2030) Use StateMachine to simplify handleStoreEvent() in RMStateStore

2014-06-04 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14018478#comment-14018478 ] Jian He commented on YARN-2030: --- bq. looks like PBImpl already has ProtoBase as super class,

[jira] [Commented] (YARN-2030) Use StateMachine to simplify handleStoreEvent() in RMStateStore

2014-06-03 Thread Binglin Chang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14016325#comment-14016325 ] Binglin Chang commented on YARN-2030: - Hi, [~djp]. I think the patch is ready for

[jira] [Commented] (YARN-2030) Use StateMachine to simplify handleStoreEvent() in RMStateStore

2014-05-23 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14006858#comment-14006858 ] Hadoop QA commented on YARN-2030: - {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (YARN-2030) Use StateMachine to simplify handleStoreEvent() in RMStateStore

2014-05-23 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14007919#comment-14007919 ] Hadoop QA commented on YARN-2030: - {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (YARN-2030) Use StateMachine to simplify handleStoreEvent() in RMStateStore

2014-05-22 Thread Binglin Chang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14005753#comment-14005753 ] Binglin Chang commented on YARN-2030: - Hi Jian He, Thanks for the comments, looks like

[jira] [Commented] (YARN-2030) Use StateMachine to simplify handleStoreEvent() in RMStateStore

2014-05-21 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14004398#comment-14004398 ] Jian He commented on YARN-2030: --- Hi Binglin, thanks for cleaning it up ! Just quickly looked

[jira] [Commented] (YARN-2030) Use StateMachine to simplify handleStoreEvent() in RMStateStore

2014-05-20 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14003208#comment-14003208 ] Hadoop QA commented on YARN-2030: - {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (YARN-2030) Use StateMachine to simplify handleStoreEvent() in RMStateStore

2014-05-20 Thread Junping Du (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14004335#comment-14004335 ] Junping Du commented on YARN-2030: -- Hi [~decster], thanks for taking on this effort. I

[jira] [Commented] (YARN-2030) Use StateMachine to simplify handleStoreEvent() in RMStateStore

2014-05-16 Thread Wangda Tan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13993246#comment-13993246 ] Wangda Tan commented on YARN-2030: -- +1 for this idea, I think we should handle this neatly

[jira] [Commented] (YARN-2030) Use StateMachine to simplify handleStoreEvent() in RMStateStore

2014-05-16 Thread Tsuyoshi OZAWA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13998635#comment-13998635 ] Tsuyoshi OZAWA commented on YARN-2030: -- +1 for this idea too. Using state machine