[jira] [Commented] (YARN-2144) Add logs when preemption occurs

[ https://issues.apache.org/jira/browse/YARN-2144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14052610#comment-14052610 ] Sunil G commented on YARN-2144: --- Hi [~leftnoteasy] A quick nit! RMContainer has isAMContainer

[jira] [Commented] (YARN-2144) Add logs when preemption occurs

[ https://issues.apache.org/jira/browse/YARN-2144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14052666#comment-14052666 ] Wangda Tan commented on YARN-2144: -- Hi [~sunilg], Thanks for your review, but this patch

[jira] [Commented] (YARN-2144) Add logs when preemption occurs

[ https://issues.apache.org/jira/browse/YARN-2144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14041172#comment-14041172 ] Hadoop QA commented on YARN-2144: - {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (YARN-2144) Add logs when preemption occurs

[ https://issues.apache.org/jira/browse/YARN-2144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14041543#comment-14041543 ] Wangda Tan commented on YARN-2144: -- Thanks Jian for review! Add logs when preemption

[jira] [Commented] (YARN-2144) Add logs when preemption occurs

[ https://issues.apache.org/jira/browse/YARN-2144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14040115#comment-14040115 ] Wangda Tan commented on YARN-2144: -- Attached a new patch only changed

[jira] [Commented] (YARN-2144) Add logs when preemption occurs

[ https://issues.apache.org/jira/browse/YARN-2144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14040128#comment-14040128 ] Hadoop QA commented on YARN-2144: - {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (YARN-2144) Add logs when preemption occurs

[ https://issues.apache.org/jira/browse/YARN-2144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14040140#comment-14040140 ] Wangda Tan commented on YARN-2144: -- The findbug warning is caused by un-synchronized

[jira] [Commented] (YARN-2144) Add logs when preemption occurs

[ https://issues.apache.org/jira/browse/YARN-2144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14040213#comment-14040213 ] Carlo Curino commented on YARN-2144: From a quick skim, the patch seems fine. As a

[jira] [Commented] (YARN-2144) Add logs when preemption occurs

[ https://issues.apache.org/jira/browse/YARN-2144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14040286#comment-14040286 ] Wangda Tan commented on YARN-2144: -- Hi [~curino], thanks for your comment. I think it's

[jira] [Commented] (YARN-2144) Add logs when preemption occurs

[ https://issues.apache.org/jira/browse/YARN-2144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14040328#comment-14040328 ] Jian He commented on YARN-2144: --- The first check can never happen? {code} if (null ==

[jira] [Commented] (YARN-2144) Add logs when preemption occurs

[ https://issues.apache.org/jira/browse/YARN-2144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14040343#comment-14040343 ] Wangda Tan commented on YARN-2144: -- Thanks [~jianhe] for review. bq. The first check can

[jira] [Commented] (YARN-2144) Add logs when preemption occurs

[ https://issues.apache.org/jira/browse/YARN-2144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14040361#comment-14040361 ] Hadoop QA commented on YARN-2144: - {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (YARN-2144) Add logs when preemption occurs

[ https://issues.apache.org/jira/browse/YARN-2144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14040397#comment-14040397 ] Jian He commented on YARN-2144: --- bq. Yes, it should be never happen, but it's better to

[jira] [Commented] (YARN-2144) Add logs when preemption occurs

[ https://issues.apache.org/jira/browse/YARN-2144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14040421#comment-14040421 ] Hadoop QA commented on YARN-2144: - {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (YARN-2144) Add logs when preemption occurs

[ https://issues.apache.org/jira/browse/YARN-2144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14040436#comment-14040436 ] Hadoop QA commented on YARN-2144: - {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (YARN-2144) Add logs when preemption occurs

[ https://issues.apache.org/jira/browse/YARN-2144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14039934#comment-14039934 ] Carlo Curino commented on YARN-2144: I only skimmed the patch quickly, but I see

[jira] [Commented] (YARN-2144) Add logs when preemption occurs

[ https://issues.apache.org/jira/browse/YARN-2144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14040010#comment-14040010 ] Wangda Tan commented on YARN-2144: -- Since suggested by [~jianhe], to propose of this JIRA,

[jira] [Commented] (YARN-2144) Add logs when preemption occurs

[ https://issues.apache.org/jira/browse/YARN-2144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14039434#comment-14039434 ] Jian He commented on YARN-2144: --- For the purpose of this jira, can we just log whatever

[jira] [Commented] (YARN-2144) Add logs when preemption occurs

[ https://issues.apache.org/jira/browse/YARN-2144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14039580#comment-14039580 ] Jian He commented on YARN-2144: --- appId=appattempt_1402886643897_0002_01, appId can be

[jira] [Commented] (YARN-2144) Add logs when preemption occurs

[ https://issues.apache.org/jira/browse/YARN-2144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14037115#comment-14037115 ] Wangda Tan commented on YARN-2144: -- Attached a patch only contains preemption log related

[jira] [Commented] (YARN-2144) Add logs when preemption occurs

[ https://issues.apache.org/jira/browse/YARN-2144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14038185#comment-14038185 ] Hadoop QA commented on YARN-2144: - {color:green}+1 overall{color}. Here are the results of

[jira] [Commented] (YARN-2144) Add logs when preemption occurs

[ https://issues.apache.org/jira/browse/YARN-2144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14036396#comment-14036396 ] Jian He commented on YARN-2144: --- Wangda, can you separate the patch ? let's have this jira

[jira] [Commented] (YARN-2144) Add logs when preemption occurs

[ https://issues.apache.org/jira/browse/YARN-2144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14036845#comment-14036845 ] Wangda Tan commented on YARN-2144: -- [~jianhe], I created a JIRA YARN-2181 to track web UI

[jira] [Commented] (YARN-2144) Add logs when preemption occurs

[ https://issues.apache.org/jira/browse/YARN-2144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14034624#comment-14034624 ] Jian He commented on YARN-2144: --- the patch needs rebase, can you update please? thx Add

[jira] [Commented] (YARN-2144) Add logs when preemption occurs

[ https://issues.apache.org/jira/browse/YARN-2144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14034725#comment-14034725 ] Hadoop QA commented on YARN-2144: - {color:green}+1 overall{color}. Here are the results of

[jira] [Commented] (YARN-2144) Add logs when preemption occurs

[ https://issues.apache.org/jira/browse/YARN-2144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14032287#comment-14032287 ] Hadoop QA commented on YARN-2144: - {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (YARN-2144) Add logs when preemption occurs

[ https://issues.apache.org/jira/browse/YARN-2144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14032333#comment-14032333 ] Hadoop QA commented on YARN-2144: - {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (YARN-2144) Add logs when preemption occurs

[ https://issues.apache.org/jira/browse/YARN-2144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14032603#comment-14032603 ] Tassapol Athiapinya commented on YARN-2144: --- [~leftnoteasy] Can you please

[jira] [Commented] (YARN-2144) Add logs when preemption occurs

[ https://issues.apache.org/jira/browse/YARN-2144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14032611#comment-14032611 ] Hadoop QA commented on YARN-2144: - {color:green}+1 overall{color}. Here are the results of

[jira] [Commented] (YARN-2144) Add logs when preemption occurs

[ https://issues.apache.org/jira/browse/YARN-2144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14033190#comment-14033190 ] Jian He commented on YARN-2144: --- Haven't looked at the patch. YARN-1809 is adding the attempt

[jira] [Commented] (YARN-2144) Add logs when preemption occurs

[ https://issues.apache.org/jira/browse/YARN-2144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14033306#comment-14033306 ] Wangda Tan commented on YARN-2144: -- Hi [~tassapola], bq. In AM page, Does Resource

[jira] [Commented] (YARN-2144) Add logs when preemption occurs

[ https://issues.apache.org/jira/browse/YARN-2144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14033326#comment-14033326 ] Wangda Tan commented on YARN-2144: -- bq. Haven't looked at the patch. YARN-1809 is adding