[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17003353#comment-17003353
]
chaoli commented on YARN-2962:
--
I'm not quite agreed with this patch. I recently read zookeeper source code,
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16044614#comment-16044614
]
Bibin A Chundatt commented on YARN-2962:
[~varun_saxena]
Raised YARN-6703 jira is for the same.
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16044455#comment-16044455
]
Varun Saxena commented on YARN-2962:
Thanks [~bibinchundatt]. You are correct. I forgot to discuss
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1603#comment-1603
]
Bibin A Chundatt commented on YARN-2962:
[~varun_saxena]/[~templedf]
Had the time to check the
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15994963#comment-15994963
]
Varun Saxena commented on YARN-2962:
Thanks a lot [~templedf] for the review and commit. This JIRA was
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989540#comment-15989540
]
Daniel Templeton commented on YARN-2962:
Since it's a compatible change that doesn't mess with
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989458#comment-15989458
]
Hudson commented on YARN-2962:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11652 (See
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989426#comment-15989426
]
Daniel Templeton commented on YARN-2962:
+1 on the latest patch.
> ZKRMStateStore: Limit the
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985881#comment-15985881
]
Hadoop QA commented on YARN-2962:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985361#comment-15985361
]
Varun Saxena commented on YARN-2962:
bq. Why are you removing the rm1.close() and rm2.close() in
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15963194#comment-15963194
]
Varun Saxena commented on YARN-2962:
Thanks Daniel for the review.
I will update the patch.
>
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15961027#comment-15961027
]
Daniel Templeton commented on YARN-2962:
A couple of quick questions:
# Why are you removing the
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959821#comment-15959821
]
Daniel Templeton commented on YARN-2962:
Thanks, [~varun_saxena]. Let me do one more quick review
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15952802#comment-15952802
]
Hadoop QA commented on YARN-2962:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15933461#comment-15933461
]
Daniel Templeton commented on YARN-2962:
Thanks for updating the patch, [~varun_saxena]. Looks
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927711#comment-15927711
]
Hadoop QA commented on YARN-2962:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927694#comment-15927694
]
Hadoop QA commented on YARN-2962:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927168#comment-15927168
]
Hadoop QA commented on YARN-2962:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15924106#comment-15924106
]
Hadoop QA commented on YARN-2962:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15923062#comment-15923062
]
Hadoop QA commented on YARN-2962:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891302#comment-15891302
]
Daniel Templeton commented on YARN-2962:
Sweet! Thanks for the rebase, [~varun_saxena]. It's been
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15886307#comment-15886307
]
Hadoop QA commented on YARN-2962:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878377#comment-15878377
]
Varun Saxena commented on YARN-2962:
Sorry missed your pings. Will look at it in a couple of days.
>
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15868892#comment-15868892
]
Daniel Templeton commented on YARN-2962:
[~varun_saxena], can we get this one closed?
>
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15830649#comment-15830649
]
Daniel Templeton commented on YARN-2962:
[~varun_saxena], ping.
> ZKRMStateStore: Limit the number
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15816455#comment-15816455
]
Hadoop QA commented on YARN-2962:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15783757#comment-15783757
]
Daniel Templeton commented on YARN-2962:
No worries. I'm happy to help with the review.
>
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15735583#comment-15735583
]
Varun Saxena commented on YARN-2962:
Sorry have been keeping busy lately.
Give me a week. Will update
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15730413#comment-15730413
]
Daniel Templeton commented on YARN-2962:
[~varun_saxena], any progress on the rebase?
>
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15612861#comment-15612861
]
Varun Saxena commented on YARN-2962:
No it doesn't.
Will rebase it
> ZKRMStateStore: Limit the number
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15321386#comment-15321386
]
Varun Saxena commented on YARN-2962:
Have rebased the patch and fixed comments given by Daniel. Haven't
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15321255#comment-15321255
]
Hadoop QA commented on YARN-2962:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15319183#comment-15319183
]
Varun Saxena commented on YARN-2962:
Thanks [~asuresh].
Seems patch is not applying. Will upload a
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15318853#comment-15318853
]
Hadoop QA commented on YARN-2962:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15318852#comment-15318852
]
Arun Suresh commented on YARN-2962:
---
[~varun_saxena], apologize for the really long delay..
I am fine
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15200154#comment-15200154
]
Varun Saxena commented on YARN-2962:
Thanks Daniel for the review.
bq. One optimization I might
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15198442#comment-15198442
]
Daniel Templeton commented on YARN-2962:
Thanks for updating the patch, [~varun_saxena].
The
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15200170#comment-15200170
]
Varun Saxena commented on YARN-2962:
bq. Could you also explain in the parameter description why one
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15088281#comment-15088281
]
Varun Saxena commented on YARN-2962:
[~kasha], [~jianhe], [~vinodkv], [~asuresh], kindly review.
Will
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15085977#comment-15085977
]
Varun Saxena commented on YARN-2962:
Rebased and updated the patch.
Additionally the patch ensures that
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15085982#comment-15085982
]
Varun Saxena commented on YARN-2962:
We can decide if we need to write a tool to migrate apps to a
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15086246#comment-15086246
]
Hadoop QA commented on YARN-2962:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14715342#comment-14715342
]
Ben Podgursky commented on YARN-2962:
-
Hi,
We're looking at switching to a HA RM and
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14715519#comment-14715519
]
Varun Saxena commented on YARN-2962:
bq. how many applications did you have in the RM
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14715591#comment-14715591
]
Ben Podgursky commented on YARN-2962:
-
Got it. Thanks for the details. It sounds like
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14619262#comment-14619262
]
Varun Saxena commented on YARN-2962:
[~kasha], I mean if let us say somebody configures
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14619254#comment-14619254
]
Karthik Kambatla commented on YARN-2962:
Since we don't support rolling upgrades
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14619399#comment-14619399
]
Karthik Kambatla commented on YARN-2962:
Oh, sorry.
For changing split index post
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14615069#comment-14615069
]
Varun Saxena commented on YARN-2962:
[~kasha],
The thing we primarily need to decide is
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14614432#comment-14614432
]
Karthik Kambatla commented on YARN-2962:
For a trunk only patch, do we really need
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14568789#comment-14568789
]
Varun Saxena commented on YARN-2962:
Was waiting for an input from [~vinodkv] and
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14569262#comment-14569262
]
Karthik Kambatla commented on YARN-2962:
YARN-3643 should help alleviate most of
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14537264#comment-14537264
]
Varun Saxena commented on YARN-2962:
[~vinodkv] / [~asuresh], supporting 2 separate
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14527299#comment-14527299
]
Vinod Kumar Vavilapalli commented on YARN-2962:
---
Thinking more, the new RM
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14526289#comment-14526289
]
Arun Suresh commented on YARN-2962:
---
bq. we can simplify it without special hierarchies
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14526130#comment-14526130
]
Vinod Kumar Vavilapalli commented on YARN-2962:
---
bq. it will indeed be
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14517605#comment-14517605
]
Hadoop QA commented on YARN-2962:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
||
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14501158#comment-14501158
]
Varun Saxena commented on YARN-2962:
A little busy nowadays. The change I suggested
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14499939#comment-14499939
]
Arun Suresh commented on YARN-2962:
---
[~varun_saxena], wondering if you need any help with
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14390076#comment-14390076
]
Arun Suresh commented on YARN-2962:
---
.. alternative to starting the index from the front.
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14390074#comment-14390074
]
Arun Suresh commented on YARN-2962:
---
Yup.. agreed, star index from the end is a better
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14388399#comment-14388399
]
Varun Saxena commented on YARN-2962:
Thanks [~asuresh] for the review.
bq. minor
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14388443#comment-14388443
]
Varun Saxena commented on YARN-2962:
bq. Also was wondering, should we hard code the
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14387091#comment-14387091
]
Arun Suresh commented on YARN-2962:
---
[~varun_saxena], Thanks for the patch. It looks
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14345649#comment-14345649
]
Varun Saxena commented on YARN-2962:
[~kasha] / [~jianhe] / [~ozawa], kindly review
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14346492#comment-14346492
]
Varun Saxena commented on YARN-2962:
Suggest a better config name ?
Also currently
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14343758#comment-14343758
]
Hadoop QA commented on YARN-2962:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14344472#comment-14344472
]
Varun Saxena commented on YARN-2962:
Findbugs to be addressed by YARN-3204
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14340380#comment-14340380
]
Karthik Kambatla commented on YARN-2962:
[~varun_saxena] - it will indeed be
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14339900#comment-14339900
]
Tsuyoshi Ozawa commented on YARN-2962:
--
[~varun_saxena], Yes,
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14339796#comment-14339796
]
Varun Saxena commented on YARN-2962:
[~kasha] / [~ka...@cloudera.com], for this I WILL
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14277106#comment-14277106
]
Karthik Kambatla commented on YARN-2962:
The proposed approach sounds reasonable.
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14277112#comment-14277112
]
Varun Saxena commented on YARN-2962:
Yup, that sounds good.
ZKRMStateStore: Limit
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14277099#comment-14277099
]
Varun Saxena commented on YARN-2962:
[~kasha], your views on this
ZKRMStateStore:
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14255497#comment-14255497
]
Varun Saxena commented on YARN-2962:
[~rakeshr], thanks for your input. ApplicationID
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14250656#comment-14250656
]
Karthik Kambatla commented on YARN-2962:
[~rakeshr] - you are right, we saw the
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14251292#comment-14251292
]
Rakesh R commented on YARN-2962:
OK. Recently I had given a talk about ZooKeeper. Please
[
https://issues.apache.org/jira/browse/YARN-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14247916#comment-14247916
]
Rakesh R commented on YARN-2962:
Hi [~kasha], I'm interested to know more about this. Could
78 matches
Mail list logo
