[
https://issues.apache.org/jira/browse/YARN-3140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15505890#comment-15505890
]
Hudson commented on YARN-3140:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10464 (See
[
https://issues.apache.org/jira/browse/YARN-3140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15504595#comment-15504595
]
Wangda Tan commented on YARN-3140:
--
Unit test failures are not related. Javadocs warnings are also not
[
https://issues.apache.org/jira/browse/YARN-3140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15504364#comment-15504364
]
Hadoop QA commented on YARN-3140:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15502599#comment-15502599
]
Jian He commented on YARN-3140:
---
The conflict is due to log statement reformatted into a bad format, we
[
https://issues.apache.org/jira/browse/YARN-3140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15502282#comment-15502282
]
Jian He commented on YARN-3140:
---
[~leftnoteasy], the patch doesn't apply any more, could you rebase?
>
[
https://issues.apache.org/jira/browse/YARN-3140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15497022#comment-15497022
]
Wangda Tan commented on YARN-3140:
--
Thanks [~jianhe], all failed tests are not related to this patch.
>
[
https://issues.apache.org/jira/browse/YARN-3140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15495424#comment-15495424
]
Jian He commented on YARN-3140:
---
lgtm, committing in a day if no comments from others.
> Improve locks in
[
https://issues.apache.org/jira/browse/YARN-3140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15494387#comment-15494387
]
Hadoop QA commented on YARN-3140:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15494172#comment-15494172
]
Wangda Tan commented on YARN-3140:
--
Thanks [~jianhe] for review,
Addressed all comments, except:
bq.
[
https://issues.apache.org/jira/browse/YARN-3140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15493012#comment-15493012
]
Jian He commented on YARN-3140:
---
- Is this method not used ? If so, labelManager no need to be volatile, and
[
https://issues.apache.org/jira/browse/YARN-3140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15488272#comment-15488272
]
Wangda Tan commented on YARN-3140:
--
[~jianhe] could you take a look at this patch?
> Improve locks in
[
https://issues.apache.org/jira/browse/YARN-3140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15480463#comment-15480463
]
Hadoop QA commented on YARN-3140:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15478793#comment-15478793
]
Hadoop QA commented on YARN-3140:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
13 matches
Mail list logo