[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15369720#comment-15369720
]
Hudson commented on YARN-3367:
--
SUCCESS: Integrated in Hadoop-trunk-Commit #10074 (See
[https
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15139289#comment-15139289
]
Naganarasimha G R commented on YARN-3367:
-
Thanks for the review can commit [~sjlee
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15139217#comment-15139217
]
Sangjin Lee commented on YARN-3367:
---
The latest patch LGTM. Committing shortly.
> Replac
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138811#comment-15138811
]
Hadoop QA commented on YARN-3367:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138179#comment-15138179
]
Hadoop QA commented on YARN-3367:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15137617#comment-15137617
]
Sangjin Lee commented on YARN-3367:
---
Hi [~Naganarasimha], I realized that the patch needs
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15137524#comment-15137524
]
Sangjin Lee commented on YARN-3367:
---
LGTM. I'll commit it soon unless I hear additional f
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15137425#comment-15137425
]
Sangjin Lee commented on YARN-3367:
---
OK I think it's real close now. I ran all the tests
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15135746#comment-15135746
]
Hadoop QA commented on YARN-3367:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15135321#comment-15135321
]
Sangjin Lee commented on YARN-3367:
---
The reason you're not seeing that is because
{{Test
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15135305#comment-15135305
]
Hadoop QA commented on YARN-3367:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15131212#comment-15131212
]
Hadoop QA commented on YARN-3367:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15130971#comment-15130971
]
Sangjin Lee commented on YARN-3367:
---
I agree it might be slightly better to try to drain
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15130336#comment-15130336
]
Naganarasimha G R commented on YARN-3367:
-
Thanks [~varun_saxena],
True will updat
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15130065#comment-15130065
]
Varun Saxena commented on YARN-3367:
A couple of comments.
# When we are stopping the
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15130015#comment-15130015
]
Varun Saxena commented on YARN-3367:
testSyncCall is failing again.
I think instead of
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1512#comment-1512
]
Hadoop QA commented on YARN-3367:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15129511#comment-15129511
]
Sangjin Lee commented on YARN-3367:
---
It looks good to me. I don't think the unit test fai
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15129459#comment-15129459
]
Hadoop QA commented on YARN-3367:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15129193#comment-15129193
]
Sangjin Lee commented on YARN-3367:
---
My local test for TestDistributedShell was not concl
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15128620#comment-15128620
]
Sangjin Lee commented on YARN-3367:
---
Regarding TestDistributedShell, I'll try to reproduc
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15127773#comment-15127773
]
Naganarasimha G R commented on YARN-3367:
-
I have been trying for sometime now and
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15127767#comment-15127767
]
Varun Saxena commented on YARN-3367:
bq. TestDistributedShell: what is the status of th
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126957#comment-15126957
]
Hadoop QA commented on YARN-3367:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126765#comment-15126765
]
Sangjin Lee commented on YARN-3367:
---
Thanks [~Naganarasimha] for the updated patch! I'll
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126734#comment-15126734
]
Sangjin Lee commented on YARN-3367:
---
I agree it may be a good idea to create separate imp
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126446#comment-15126446
]
Hadoop QA commented on YARN-3367:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126270#comment-15126270
]
Varun Saxena commented on YARN-3367:
bq. TimelineClient class becoming bulky and little
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126233#comment-15126233
]
Naganarasimha G R commented on YARN-3367:
-
Test case failures and hanging is not re
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15125601#comment-15125601
]
Hadoop QA commented on YARN-3367:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15120951#comment-15120951
]
Hadoop QA commented on YARN-3367:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15120757#comment-15120757
]
Naganarasimha G R (Naga) commented on YARN-3367:
Hi Sangjin,
Skimmed throu
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15120646#comment-15120646
]
Naganarasimha G R commented on YARN-3367:
-
Thanks [~sjlee0], for sharing these poin
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15120627#comment-15120627
]
Sangjin Lee commented on YARN-3367:
---
I went over the patch in some more detail, and it's
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15120497#comment-15120497
]
Sangjin Lee commented on YARN-3367:
---
Thanks for the latest patch [~Naganarasimha]! I'm go
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15117513#comment-15117513
]
Naganarasimha G R commented on YARN-3367:
-
test case failures are not related to th
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15117078#comment-15117078
]
Hadoop QA commented on YARN-3367:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15116555#comment-15116555
]
Naganarasimha G R commented on YARN-3367:
-
Need to rebase the patch... uploading sh
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15116517#comment-15116517
]
Hadoop QA commented on YARN-3367:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15116506#comment-15116506
]
Naganarasimha G R commented on YARN-3367:
-
Have cross verified the patch in TestDis
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15107105#comment-15107105
]
Naganarasimha G R commented on YARN-3367:
-
Thanks for comments [~sjlee0], Working o
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15087811#comment-15087811
]
Sangjin Lee commented on YARN-3367:
---
[~Naganarasimha] and I spoke offline about this, but
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15070715#comment-15070715
]
Sangjin Lee commented on YARN-3367:
---
I haven't fully digested the code so I might be off-
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15070652#comment-15070652
]
Naganarasimha G R commented on YARN-3367:
-
Thanks for the comments [~sjlee0],
bq. I
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15070611#comment-15070611
]
Sangjin Lee commented on YARN-3367:
---
Thanks for the patch [~Naganarasimha]! I took a fair
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15070009#comment-15070009
]
Naganarasimha G R commented on YARN-3367:
-
thanks [~djp] for looking into this issu
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15069952#comment-15069952
]
Junping Du commented on YARN-3367:
--
Thanks Naga for updating the patch! Quickly go through
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15068468#comment-15068468
]
Naganarasimha G R commented on YARN-3367:
-
check style issues some cannot be handle
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15068355#comment-15068355
]
Hadoop QA commented on YARN-3367:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15067436#comment-15067436
]
Hadoop QA commented on YARN-3367:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15044081#comment-15044081
]
Hadoop QA commented on YARN-3367:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15041824#comment-15041824
]
Junping Du commented on YARN-3367:
--
bq. Can you share your thoughts on why events are requ
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15004506#comment-15004506
]
Hadoop QA commented on YARN-3367:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14970108#comment-14970108
]
Naganarasimha G R commented on YARN-3367:
-
Hi [~djp],
Can you share your thoughts
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14948044#comment-14948044
]
Naganarasimha G R commented on YARN-3367:
-
bq. There is still no hard guarantee th
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14947620#comment-14947620
]
Sangjin Lee commented on YARN-3367:
---
{quote}
You mean that flush need not be coupled with
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14947261#comment-14947261
]
Naganarasimha G R commented on YARN-3367:
-
Hi [~sjlee0] , Thanks for the comments,
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14944028#comment-14944028
]
Sangjin Lee commented on YARN-3367:
---
bq. Yes i agree with this, but what should be the be
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14943849#comment-14943849
]
Naganarasimha G R commented on YARN-3367:
-
Thanks for the feed back [~sjlee0],
bq.
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14943760#comment-14943760
]
Sangjin Lee commented on YARN-3367:
---
Sorry for my late reply.
{quote}
Timelineclient asy
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14939324#comment-14939324
]
Naganarasimha G R commented on YARN-3367:
-
Hi [~gtCarrera] & [~sjlee0], Any though
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14903754#comment-14903754
]
Naganarasimha G R commented on YARN-3367:
-
Thanks [~gtCarrera9],
For looking into
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14903527#comment-14903527
]
Li Lu commented on YARN-3367:
-
Also, I looked at the patch. One general comment is that, the lo
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14903461#comment-14903461
]
Li Lu commented on YARN-3367:
-
Hi [~Naganarasimha], I'm trying to go over all pending JIRAs for
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14732079#comment-14732079
]
Hadoop QA commented on YARN-3367:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14701302#comment-14701302
]
Naganarasimha G R commented on YARN-3367:
-
Thanks [~djp], Assigning this jira to my
[
https://issues.apache.org/jira/browse/YARN-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14653651#comment-14653651
]
Junping Du commented on YARN-3367:
--
We need to implement a separated API - putEntitiesAsyn
67 matches
Mail list logo