[
https://issues.apache.org/jira/browse/YARN-3591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14546568#comment-14546568
]
Lavkesh Lahngir commented on YARN-3591:
---
[~vinodkv]: The concern here is, If a resour
[
https://issues.apache.org/jira/browse/YARN-3591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14546590#comment-14546590
]
zhihai xu commented on YARN-3591:
-
[~lavkesh], Currently DirectoryCollection supports {{ful
[
https://issues.apache.org/jira/browse/YARN-3591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14550566#comment-14550566
]
Hadoop QA commented on YARN-3591:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/YARN-3591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14551976#comment-14551976
]
Hadoop QA commented on YARN-3591:
-
\\
\\
| (/) *{color:green}+1 overall{color}* |
\\
\\
||
[
https://issues.apache.org/jira/browse/YARN-3591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14553777#comment-14553777
]
zhihai xu commented on YARN-3591:
-
[~lavkesh], thanks for the new patch. It looks like your
[
https://issues.apache.org/jira/browse/YARN-3591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14553981#comment-14553981
]
Lavkesh Lahngir commented on YARN-3591:
---
The code shows that full dirs are both reada
[
https://issues.apache.org/jira/browse/YARN-3591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14555187#comment-14555187
]
zhihai xu commented on YARN-3591:
-
Calling checkLocalizedResources() on both goodirs and fu
[
https://issues.apache.org/jira/browse/YARN-3591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14555819#comment-14555819
]
Lavkesh Lahngir commented on YARN-3591:
---
Hm.. Got you point.
Is DirectoryCollection c
[
https://issues.apache.org/jira/browse/YARN-3591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14555961#comment-14555961
]
Lavkesh Lahngir commented on YARN-3591:
---
typo: cleanUpLocalDir(lfs, del, newRepaired
[
https://issues.apache.org/jira/browse/YARN-3591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14555996#comment-14555996
]
Lavkesh Lahngir commented on YARN-3591:
---
For adding newErrorDirs do we have to create
[
https://issues.apache.org/jira/browse/YARN-3591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14558727#comment-14558727
]
zhihai xu commented on YARN-3591:
-
Yes, I think we can get newErrorDirs and newRepairedDirs
[
https://issues.apache.org/jira/browse/YARN-3591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14568834#comment-14568834
]
Lavkesh Lahngir commented on YARN-3591:
---
[~zxu] :Can we get away without storing into
[
https://issues.apache.org/jira/browse/YARN-3591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14569480#comment-14569480
]
Sunil G commented on YARN-3591:
---
If we have a new api which returns the present set of error
[
https://issues.apache.org/jira/browse/YARN-3591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14569727#comment-14569727
]
zhihai xu commented on YARN-3591:
-
Hi [~lavkesh], I think we can create a separate JIRA for
[
https://issues.apache.org/jira/browse/YARN-3591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14570652#comment-14570652
]
Lavkesh Lahngir commented on YARN-3591:
---
Thanks [~sunilg] and [~zxu] for comments and
[
https://issues.apache.org/jira/browse/YARN-3591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14576761#comment-14576761
]
zhihai xu commented on YARN-3591:
-
Hi [~lavkesh], thanks for the update.
IMHO, although sto
[
https://issues.apache.org/jira/browse/YARN-3591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577124#comment-14577124
]
Lavkesh Lahngir commented on YARN-3591:
---
[~zxu]: Thanks for the review and comments.
[
https://issues.apache.org/jira/browse/YARN-3591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14583524#comment-14583524
]
Varun Vasudev commented on YARN-3591:
-
Sorry for the late response. In my opinion, ther
[
https://issues.apache.org/jira/browse/YARN-3591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14583925#comment-14583925
]
zhihai xu commented on YARN-3591:
-
Hi [~vvasudev], thanks for the suggestion.
It looks like
[
https://issues.apache.org/jira/browse/YARN-3591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14587682#comment-14587682
]
Varun Vasudev commented on YARN-3591:
-
Lavkesh's original patch did the test regardless
[
https://issues.apache.org/jira/browse/YARN-3591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14590484#comment-14590484
]
zhihai xu commented on YARN-3591:
-
Hi [~vvasudev], thanks for the explanation.
IMHO, If we
[
https://issues.apache.org/jira/browse/YARN-3591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14590576#comment-14590576
]
Hadoop QA commented on YARN-3591:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/YARN-3591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14591612#comment-14591612
]
Varun Vasudev commented on YARN-3591:
-
[~zxu] can you explain how using onChange will h
[
https://issues.apache.org/jira/browse/YARN-3591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14592560#comment-14592560
]
zhihai xu commented on YARN-3591:
-
Hi [~vvasudev],
bq. can you explain how using onChange w
[
https://issues.apache.org/jira/browse/YARN-3591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14593472#comment-14593472
]
Jason Lowe commented on YARN-3591:
--
One potential issue with that approach is long-running
[
https://issues.apache.org/jira/browse/YARN-3591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14595250#comment-14595250
]
zhihai xu commented on YARN-3591:
-
Hi [~jlowe], thanks for the thorough analysis.
My assump
[
https://issues.apache.org/jira/browse/YARN-3591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14608089#comment-14608089
]
Lavkesh Lahngir commented on YARN-3591:
---
Thanks [~jlowe] and [~zxu] for detailed anal
[
https://issues.apache.org/jira/browse/YARN-3591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14634635#comment-14634635
]
Lavkesh Lahngir commented on YARN-3591:
---
Hi [~jlowe], Can we get some input on the pr
[
https://issues.apache.org/jira/browse/YARN-3591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14635292#comment-14635292
]
Jason Lowe commented on YARN-3591:
--
Sorry for the delay, as I was on vacation and am still
[
https://issues.apache.org/jira/browse/YARN-3591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14635499#comment-14635499
]
zhihai xu commented on YARN-3591:
-
+1 for [~jlowe]'s comment. Yes, It fixes some problems w
[
https://issues.apache.org/jira/browse/YARN-3591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14532567#comment-14532567
]
Lavkesh Lahngir commented on YARN-3591:
---
example:
>>stat /data/d3/yarn/local
File: `
[
https://issues.apache.org/jira/browse/YARN-3591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14532675#comment-14532675
]
Hadoop QA commented on YARN-3591:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/YARN-3591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540715#comment-14540715
]
zhihai xu commented on YARN-3591:
-
Hi [~lavkesh], thanks for working on this issue. It look
[
https://issues.apache.org/jira/browse/YARN-3591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14541464#comment-14541464
]
Lavkesh Lahngir commented on YARN-3591:
---
Thanks [~zxu] for comments.
added a null ch
[
https://issues.apache.org/jira/browse/YARN-3591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14541525#comment-14541525
]
Hadoop QA commented on YARN-3591:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/YARN-3591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14541705#comment-14541705
]
Varun Vasudev commented on YARN-3591:
-
[~zxu], [~lavkesh] - instead of checking listing
[
https://issues.apache.org/jira/browse/YARN-3591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14542291#comment-14542291
]
Lavkesh Lahngir commented on YARN-3591:
---
[~vvasudev] Thanks for the review:
This is a
[
https://issues.apache.org/jira/browse/YARN-3591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14542347#comment-14542347
]
zhihai xu commented on YARN-3591:
-
[~vvasudev], that is a good suggestion, which will give
[
https://issues.apache.org/jira/browse/YARN-3591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14543304#comment-14543304
]
Lavkesh Lahngir commented on YARN-3591:
---
Thanks for the comment [~zxu] and [~vvasudev
[
https://issues.apache.org/jira/browse/YARN-3591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14543886#comment-14543886
]
Lavkesh Lahngir commented on YARN-3591:
---
LocalResourcesTrackerImpl keeps a ref count
[
https://issues.apache.org/jira/browse/YARN-3591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14544708#comment-14544708
]
zhihai xu commented on YARN-3591:
-
I think the current code call {{removeResource}} instead
[
https://issues.apache.org/jira/browse/YARN-3591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14545250#comment-14545250
]
Lavkesh Lahngir commented on YARN-3591:
---
What about zombie files lying in the various
[
https://issues.apache.org/jira/browse/YARN-3591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14546213#comment-14546213
]
Vinod Kumar Vavilapalli commented on YARN-3591:
---
Essentially keeping the owne
[
https://issues.apache.org/jira/browse/YARN-3591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14546461#comment-14546461
]
zhihai xu commented on YARN-3591:
-
[~vinodkv], yes, keeping the ownership of turning disks
[
https://issues.apache.org/jira/browse/YARN-3591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14661606#comment-14661606
]
Lavkesh Lahngir commented on YARN-3591:
---
Marking sub-tasks to be invalid.
> Resource
[
https://issues.apache.org/jira/browse/YARN-3591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14661674#comment-14661674
]
Hadoop QA commented on YARN-3591:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/YARN-3591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14661836#comment-14661836
]
Hadoop QA commented on YARN-3591:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/YARN-3591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14727155#comment-14727155
]
Hadoop QA commented on YARN-3591:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/YARN-3591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14727698#comment-14727698
]
Varun Vasudev commented on YARN-3591:
-
Thanks for the latest patch Lavkesh! Couple of c
[
https://issues.apache.org/jira/browse/YARN-3591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14729674#comment-14729674
]
Hadoop QA commented on YARN-3591:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/YARN-3591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14730374#comment-14730374
]
Varun Vasudev commented on YARN-3591:
-
+1 for the latest patch. I'll commit this tomorr
51 matches
Mail list logo