[
https://issues.apache.org/jira/browse/YARN-3884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14622030#comment-14622030
]
Bibin A Chundatt commented on YARN-3884:
@Please review patch attached .
> RMConta
[
https://issues.apache.org/jira/browse/YARN-3884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14625307#comment-14625307
]
Bibin A Chundatt commented on YARN-3884:
Please review patch attached
> RMContaine
[
https://issues.apache.org/jira/browse/YARN-3884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15612812#comment-15612812
]
Wangda Tan commented on YARN-3884:
--
This looks useful, [~sunilg] could you look at the pat
[
https://issues.apache.org/jira/browse/YARN-3884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15623548#comment-15623548
]
Varun Saxena commented on YARN-3884:
[~bibinchundatt], can you rebase the patch. Also c
[
https://issues.apache.org/jira/browse/YARN-3884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15625494#comment-15625494
]
Sunil G commented on YARN-3884:
---
Yes. I will also take a look after rebasing.
> RMContainerI
[
https://issues.apache.org/jira/browse/YARN-3884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15632212#comment-15632212
]
Bibin A Chundatt commented on YARN-3884:
Thank you [~sunilg]/[~varun_saxena]/[~left
[
https://issues.apache.org/jira/browse/YARN-3884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15639795#comment-15639795
]
Hadoop QA commented on YARN-3884:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-3884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15639888#comment-15639888
]
Varun Saxena commented on YARN-3884:
Thanks [~bibinchundatt] for the patch.
At a very
[
https://issues.apache.org/jira/browse/YARN-3884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15639904#comment-15639904
]
Bibin A Chundatt commented on YARN-3884:
Thanks [~varun_saxena] for review
Had the
[
https://issues.apache.org/jira/browse/YARN-3884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15639918#comment-15639918
]
Varun Saxena commented on YARN-3884:
Hmm...But we do not really differentiate between r
[
https://issues.apache.org/jira/browse/YARN-3884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15640079#comment-15640079
]
Bibin A Chundatt commented on YARN-3884:
IIUC we do send all Scheduler Container st
[
https://issues.apache.org/jira/browse/YARN-3884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15643577#comment-15643577
]
Varun Saxena commented on YARN-3884:
Yeah, diagnostics are reported when container fini
[
https://issues.apache.org/jira/browse/YARN-3884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15657317#comment-15657317
]
Bibin A Chundatt commented on YARN-3884:
[~sunilg]/[~varun_saxena]
Is the current a
[
https://issues.apache.org/jira/browse/YARN-3884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15657394#comment-15657394
]
Sunil G commented on YARN-3884:
---
Thanks [~bibinchundatt]
Overall approach and idea seems fine
[
https://issues.apache.org/jira/browse/YARN-3884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15658709#comment-15658709
]
Varun Saxena commented on YARN-3884:
[~bibinchundatt], kindly rebase the patch. Its no
[
https://issues.apache.org/jira/browse/YARN-3884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15679424#comment-15679424
]
Hadoop QA commented on YARN-3884:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-3884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15680841#comment-15680841
]
Bibin A Chundatt commented on YARN-3884:
Failure looks random. Local run the same t
[
https://issues.apache.org/jira/browse/YARN-3884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15680962#comment-15680962
]
Varun Saxena commented on YARN-3884:
Thanks [~bibinchundatt] for the patch.
# We can r
[
https://issues.apache.org/jira/browse/YARN-3884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15683944#comment-15683944
]
Bibin A Chundatt commented on YARN-3884:
Attaching patch after handling comments
>
[
https://issues.apache.org/jira/browse/YARN-3884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15684111#comment-15684111
]
Hadoop QA commented on YARN-3884:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-3884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15688678#comment-15688678
]
Bibin A Chundatt commented on YARN-3884:
YARN-5548 is available to track the same.
[
https://issues.apache.org/jira/browse/YARN-3884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15692477#comment-15692477
]
Varun Saxena commented on YARN-3884:
Thanks [~bibinchundatt] for the patch.
The log cha
[
https://issues.apache.org/jira/browse/YARN-3884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15692666#comment-15692666
]
Bibin A Chundatt commented on YARN-3884:
Thank you [~varun_saxena] for comments
{qu
[
https://issues.apache.org/jira/browse/YARN-3884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693848#comment-15693848
]
Hadoop QA commented on YARN-3884:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote |
[
https://issues.apache.org/jira/browse/YARN-3884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15717413#comment-15717413
]
Bibin A Chundatt commented on YARN-3884:
[~varun_saxena]
Any more changes required?
[
https://issues.apache.org/jira/browse/YARN-3884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15718495#comment-15718495
]
Varun Saxena commented on YARN-3884:
[~bibinchundatt], can you fix the checkstyle issue
[
https://issues.apache.org/jira/browse/YARN-3884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15806891#comment-15806891
]
Hadoop QA commented on YARN-3884:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-3884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15806893#comment-15806893
]
Varun Saxena commented on YARN-3884:
[~bibinchundatt], the patch no longer applies clea
[
https://issues.apache.org/jira/browse/YARN-3884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15817134#comment-15817134
]
Bibin A Chundatt commented on YARN-3884:
Will update patch shortly
> RMContainerIm
[
https://issues.apache.org/jira/browse/YARN-3884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828436#comment-15828436
]
Hadoop QA commented on YARN-3884:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-3884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828743#comment-15828743
]
Varun Saxena commented on YARN-3884:
Checkstyle issues seem fixable.
By the way test fa
[
https://issues.apache.org/jira/browse/YARN-3884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15829524#comment-15829524
]
Bibin A Chundatt commented on YARN-3884:
YARN-5548 we had increased the scope of ji
[
https://issues.apache.org/jira/browse/YARN-3884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15832825#comment-15832825
]
Hadoop QA commented on YARN-3884:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-3884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15854438#comment-15854438
]
Varun Saxena commented on YARN-3884:
Thanks Bibin for the patch. Will review and commit
[
https://issues.apache.org/jira/browse/YARN-3884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15875081#comment-15875081
]
Varun Saxena commented on YARN-3884:
LGTM. Will wait for a day before committing it.
>
[
https://issues.apache.org/jira/browse/YARN-3884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15875121#comment-15875121
]
Hadoop QA commented on YARN-3884:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-3884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15875485#comment-15875485
]
Varun Saxena commented on YARN-3884:
[~sunilg], you have any further comments?
> RMCon
37 matches
Mail list logo