[
https://issues.apache.org/jira/browse/YARN-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15142161#comment-15142161
]
Hudson commented on YARN-4138:
--
SUCCESS: Integrated in Hadoop-trunk-Commit #9280 (See
[https:
[
https://issues.apache.org/jira/browse/YARN-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15142052#comment-15142052
]
sandflee commented on YARN-4138:
looks good to me too, thanks [~mding]
> Roll back contain
[
https://issues.apache.org/jira/browse/YARN-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140973#comment-15140973
]
Jian He commented on YARN-4138:
---
patch looks good to me, [~sandflee], do you have any more co
[
https://issues.apache.org/jira/browse/YARN-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15137639#comment-15137639
]
MENG DING commented on YARN-4138:
-
The checkstyle warnings are not fixable.
The failed test
[
https://issues.apache.org/jira/browse/YARN-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15137553#comment-15137553
]
Hadoop QA commented on YARN-4138:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15135286#comment-15135286
]
Hadoop QA commented on YARN-4138:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15134926#comment-15134926
]
MENG DING commented on YARN-4138:
-
Hi, [~jianhe] and [~sandflee]
After more thoughts, I th
[
https://issues.apache.org/jira/browse/YARN-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15134878#comment-15134878
]
MENG DING commented on YARN-4138:
-
The difference between the two allocationExpirationInfo
[
https://issues.apache.org/jira/browse/YARN-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15133758#comment-15133758
]
sandflee commented on YARN-4138:
to simple the race condition process, could we reject the
[
https://issues.apache.org/jira/browse/YARN-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15133690#comment-15133690
]
Jian He commented on YARN-4138:
---
bq. the second allocation expiration info overwrites the fi
[
https://issues.apache.org/jira/browse/YARN-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15133627#comment-15133627
]
sandflee commented on YARN-4138:
Hi, [~mding], there may some cases not user/app error,
1,
[
https://issues.apache.org/jira/browse/YARN-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15132466#comment-15132466
]
MENG DING commented on YARN-4138:
-
Hi, [~jianhe]
I think with a bit of explanation this wo
[
https://issues.apache.org/jira/browse/YARN-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15131755#comment-15131755
]
Jian He commented on YARN-4138:
---
bq. We only confirm resource when NM reported resource is t
[
https://issues.apache.org/jira/browse/YARN-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15131201#comment-15131201
]
MENG DING commented on YARN-4138:
-
The failed tests are not related.
> Roll back container
[
https://issues.apache.org/jira/browse/YARN-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15131157#comment-15131157
]
Hadoop QA commented on YARN-4138:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15130206#comment-15130206
]
Jian He commented on YARN-4138:
---
Patch looks good to me overall,
one question for this test c
[
https://issues.apache.org/jira/browse/YARN-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15129395#comment-15129395
]
Hadoop QA commented on YARN-4138:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15072880#comment-15072880
]
MENG DING commented on YARN-4138:
-
Hi, [~sandflee]
I think this issue depends on YARN-4519
[
https://issues.apache.org/jira/browse/YARN-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15072480#comment-15072480
]
MENG DING commented on YARN-4138:
-
You are right, I remembered that wrong.
> Roll back con
[
https://issues.apache.org/jira/browse/YARN-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15072430#comment-15072430
]
sandflee commented on YARN-4138:
when release containers , we didn't hold SchedulerApp's lo
[
https://issues.apache.org/jira/browse/YARN-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15072426#comment-15072426
]
MENG DING commented on YARN-4138:
-
Release containers may have the same issue too. Strange
[
https://issues.apache.org/jira/browse/YARN-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15072414#comment-15072414
]
Jian He commented on YARN-4138:
---
I think it may be true that this will lead to dead lock.
- C
[
https://issues.apache.org/jira/browse/YARN-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15072314#comment-15072314
]
sandflee commented on YARN-4138:
Hi, [~mding], I'll open a new jira to track this, not to d
[
https://issues.apache.org/jira/browse/YARN-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15071684#comment-15071684
]
MENG DING commented on YARN-4138:
-
Hi, [~sandflee]
Can you provide a test case if you beli
[
https://issues.apache.org/jira/browse/YARN-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15071682#comment-15071682
]
MENG DING commented on YARN-4138:
-
Hi, [~sandflee]
In your step 3, the container will NOT
[
https://issues.apache.org/jira/browse/YARN-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15071492#comment-15071492
]
sandflee commented on YARN-4138:
there seems a deadlock, in allocate and rollback logic we
[
https://issues.apache.org/jira/browse/YARN-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15071475#comment-15071475
]
sandflee commented on YARN-4138:
+ decreaseRequest = new SchedContainerChangeRequest(
[
https://issues.apache.org/jira/browse/YARN-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15071403#comment-15071403
]
sandflee commented on YARN-4138:
Hi, [~mding], sorry for the late reply,
1, If AM send tok
[
https://issues.apache.org/jira/browse/YARN-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15071080#comment-15071080
]
MENG DING commented on YARN-4138:
-
Hi, [~jianhe]
I just tried to apply the patch on the la
[
https://issues.apache.org/jira/browse/YARN-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15070594#comment-15070594
]
Jian He commented on YARN-4138:
---
sorry, my bad. I don't why the AllocationExpirationInfo.java
[
https://issues.apache.org/jira/browse/YARN-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15070534#comment-15070534
]
MENG DING commented on YARN-4138:
-
Hi [~jianhe], which file(s) are you referring to in part
[
https://issues.apache.org/jira/browse/YARN-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15068934#comment-15068934
]
Jian He commented on YARN-4138:
---
looks like some files are created at a wrong direcotry "had
[
https://issues.apache.org/jira/browse/YARN-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15064880#comment-15064880
]
Hadoop QA commented on YARN-4138:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15064134#comment-15064134
]
MENG DING commented on YARN-4138:
-
Hi, [~sandflee]
1. Yes, this is the expected behavior.
[
https://issues.apache.org/jira/browse/YARN-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15063576#comment-15063576
]
sandflee commented on YARN-4138:
{quote}
We should not update lastConfirmedResource in this
[
https://issues.apache.org/jira/browse/YARN-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15063209#comment-15063209
]
MENG DING commented on YARN-4138:
-
Thanks [~sandflee] for the review.
bq. use Resources.fi
[
https://issues.apache.org/jira/browse/YARN-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15063066#comment-15063066
]
MENG DING commented on YARN-4138:
-
Hi, [~jianhe]
Thanks for reviewing the code.
* I thin
[
https://issues.apache.org/jira/browse/YARN-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15059777#comment-15059777
]
sandflee commented on YARN-4138:
1, use Resources.fitsin(targetResource, lastConfirmedReso
[
https://issues.apache.org/jira/browse/YARN-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15057229#comment-15057229
]
sandflee commented on YARN-4138:
got it, thanks for your explain!
> Roll back container re
[
https://issues.apache.org/jira/browse/YARN-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15057106#comment-15057106
]
Jian He commented on YARN-4138:
---
{code}
SchedContainerChangeRequest decreaseRequest =
[
https://issues.apache.org/jira/browse/YARN-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15056056#comment-15056056
]
MENG DING commented on YARN-4138:
-
Hi, [~sandflee]
The proposed implementation of the toke
[
https://issues.apache.org/jira/browse/YARN-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15055330#comment-15055330
]
sandflee commented on YARN-4138:
Hi, [~mding], consider such situation:
1) AM request inc
[
https://issues.apache.org/jira/browse/YARN-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15052890#comment-15052890
]
MENG DING commented on YARN-4138:
-
Hi, [~sandflee]
Not sure if I fully understand your que
[
https://issues.apache.org/jira/browse/YARN-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15052468#comment-15052468
]
sandflee commented on YARN-4138:
if AM increase container size successful in NM, but resour
[
https://issues.apache.org/jira/browse/YARN-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14875803#comment-14875803
]
Hadoop QA commented on YARN-4138:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/YARN-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14803287#comment-14803287
]
MENG DING commented on YARN-4138:
-
Hi, [~sunilg]
The case you mentioned is covered. When R
[
https://issues.apache.org/jira/browse/YARN-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14803201#comment-14803201
]
Sunil G commented on YARN-4138:
---
HI [~mding]
In the same case, if we 2 incremental requests,
[
https://issues.apache.org/jira/browse/YARN-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14803122#comment-14803122
]
MENG DING commented on YARN-4138:
-
There is an issue with the current logic:
{code:title=R
[
https://issues.apache.org/jira/browse/YARN-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14745697#comment-14745697
]
Sunil G commented on YARN-4138:
---
Synced offline. Assigning to [~mding] as he already has a WI
[
https://issues.apache.org/jira/browse/YARN-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14737260#comment-14737260
]
Sunil G commented on YARN-4138:
---
Hi [~mding]
Thank you. Yes. I was also thinking in same line
[
https://issues.apache.org/jira/browse/YARN-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14737229#comment-14737229
]
MENG DING commented on YARN-4138:
-
bq. if multiple requests comes for same container, and t
[
https://issues.apache.org/jira/browse/YARN-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14737197#comment-14737197
]
Sunil G commented on YARN-4138:
---
Thank you very much [~mding] for sharing the update. I am f
[
https://issues.apache.org/jira/browse/YARN-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14737160#comment-14737160
]
MENG DING commented on YARN-4138:
-
Hi, [~sunilg],
The following is a summary of my discus
[
https://issues.apache.org/jira/browse/YARN-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14737089#comment-14737089
]
MENG DING commented on YARN-4138:
-
Thanks [~sunilg] for taking this.
> Roll back container
[
https://issues.apache.org/jira/browse/YARN-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14737059#comment-14737059
]
Sunil G commented on YARN-4138:
---
Hi [~mding]
If you are not working on this, I would like to
55 matches
Mail list logo
