[jira] [Commented] (YARN-4403) (AM/NM/Container)LivelinessMonitor should use monotonic time when calculating period

2015-12-14 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15057337#comment-15057337 ] Hudson commented on YARN-4403: -- FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #693 (See

[jira] [Commented] (YARN-4403) (AM/NM/Container)LivelinessMonitor should use monotonic time when calculating period

2015-12-14 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15056811#comment-15056811 ] Hudson commented on YARN-4403: -- FAILURE: Integrated in Hadoop-trunk-Commit #8965 (See

[jira] [Commented] (YARN-4403) (AM/NM/Container)LivelinessMonitor should use monotonic time when calculating period

2015-12-08 Thread Junping Du (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15046873#comment-15046873 ] Junping Du commented on YARN-4403: -- Ok. That sounds good. Will update the patch soon. >

[jira] [Commented] (YARN-4403) (AM/NM/Container)LivelinessMonitor should use monotonic time when calculating period

2015-12-08 Thread Junping Du (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15046871#comment-15046871 ] Junping Du commented on YARN-4403: -- Ok. That sounds good. Will update the patch soon. >

[jira] [Commented] (YARN-4403) (AM/NM/Container)LivelinessMonitor should use monotonic time when calculating period

2015-12-08 Thread Junping Du (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15046872#comment-15046872 ] Junping Du commented on YARN-4403: -- Ok. That sounds good. Will update the patch soon. >

[jira] [Commented] (YARN-4403) (AM/NM/Container)LivelinessMonitor should use monotonic time when calculating period

2015-12-08 Thread Sunil G (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15046961#comment-15046961 ] Sunil G commented on YARN-4403: --- Hi [~djp] Thanks for the updated patch. I have one doubt here, we could see

[jira] [Commented] (YARN-4403) (AM/NM/Container)LivelinessMonitor should use monotonic time when calculating period

2015-12-08 Thread Sunil G (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15046995#comment-15046995 ] Sunil G commented on YARN-4403: --- Yes. That's definitely a valid reason as per the current usage. Thank you

[jira] [Commented] (YARN-4403) (AM/NM/Container)LivelinessMonitor should use monotonic time when calculating period

2015-12-08 Thread Junping Du (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15046989#comment-15046989 ] Junping Du commented on YARN-4403: -- It depends on if any consumer of SystemClock are using it to track

[jira] [Commented] (YARN-4403) (AM/NM/Container)LivelinessMonitor should use monotonic time when calculating period

2015-12-08 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15047143#comment-15047143 ] Hadoop QA commented on YARN-4403: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-4403) (AM/NM/Container)LivelinessMonitor should use monotonic time when calculating period

2015-12-07 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15045461#comment-15045461 ] Jian He commented on YARN-4403: --- we can actually add a separate one ? > (AM/NM/Container)LivelinessMonitor

[jira] [Commented] (YARN-4403) (AM/NM/Container)LivelinessMonitor should use monotonic time when calculating period

2015-12-04 Thread Junping Du (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15041446#comment-15041446 ] Junping Du commented on YARN-4403: -- Thanks Jian for review and comments. My first thought before is to

[jira] [Commented] (YARN-4403) (AM/NM/Container)LivelinessMonitor should use monotonic time when calculating period

2015-12-03 Thread Junping Du (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15037612#comment-15037612 ] Junping Du commented on YARN-4403: -- Thanks [~xinxianyin] to link YARN-4177. I missed that discussion

[jira] [Commented] (YARN-4403) (AM/NM/Container)LivelinessMonitor should use monotonic time when calculating period

2015-12-03 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15039502#comment-15039502 ] Jian He commented on YARN-4403: --- patch looks good to me. one minor suggestion, do you think we can change

[jira] [Commented] (YARN-4403) (AM/NM/Container)LivelinessMonitor should use monotonic time when calculating period

2015-12-02 Thread Junping Du (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15035910#comment-15035910 ] Junping Du commented on YARN-4403: -- Agree. LivelinessMonitor is more critical as it affects all YARN

[jira] [Commented] (YARN-4403) (AM/NM/Container)LivelinessMonitor should use monotonic time when calculating period

2015-12-02 Thread Junping Du (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15035950#comment-15035950 ] Junping Du commented on YARN-4403: -- bq. For YARN/MR, I could also definitely help in getting it in shape

[jira] [Commented] (YARN-4403) (AM/NM/Container)LivelinessMonitor should use monotonic time when calculating period

2015-12-02 Thread Sunil G (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15035871#comment-15035871 ] Sunil G commented on YARN-4403: --- Hi [~djp] Thanks for the patch. Yes, its better to use {{MonotonicClock}}

[jira] [Commented] (YARN-4403) (AM/NM/Container)LivelinessMonitor should use monotonic time when calculating period

2015-12-02 Thread Sunil G (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15035923#comment-15035923 ] Sunil G commented on YARN-4403: --- Yes. That sounds good. +1 for the patch. For YARN/MR, I could also

[jira] [Commented] (YARN-4403) (AM/NM/Container)LivelinessMonitor should use monotonic time when calculating period

2015-12-02 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15036240#comment-15036240 ] Hadoop QA commented on YARN-4403: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-4403) (AM/NM/Container)LivelinessMonitor should use monotonic time when calculating period

2015-12-02 Thread Xianyin Xin (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15037185#comment-15037185 ] Xianyin Xin commented on YARN-4403: --- And will provide new patch of YARN-4177 once this is in. >

[jira] [Commented] (YARN-4403) (AM/NM/Container)LivelinessMonitor should use monotonic time when calculating period

2015-12-02 Thread Xianyin Xin (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15037284#comment-15037284 ] Xianyin Xin commented on YARN-4403: --- Thanks, [~sunilg]. > (AM/NM/Container)LivelinessMonitor should use

[jira] [Commented] (YARN-4403) (AM/NM/Container)LivelinessMonitor should use monotonic time when calculating period

2015-12-02 Thread Xianyin Xin (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15037180#comment-15037180 ] Xianyin Xin commented on YARN-4403: --- hi [~djp], this is a good suggestion, and YARN-4177 provides some

[jira] [Commented] (YARN-4403) (AM/NM/Container)LivelinessMonitor should use monotonic time when calculating period

2015-12-02 Thread Sunil G (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15037208#comment-15037208 ] Sunil G commented on YARN-4403: --- Thanks [~xinxianyin] for updating this, I missed this somehow. It seems like