[
https://issues.apache.org/jira/browse/YARN-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15113476#comment-15113476
]
Xuan Gong commented on YARN-4496:
-
+1 lgtm. Checking this in
> Improve HA ResourceManager Failover
[
https://issues.apache.org/jira/browse/YARN-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15113481#comment-15113481
]
Xuan Gong commented on YARN-4496:
-
Committed into trunk/branch-2. Thanks, Jian for working on this. And
[
https://issues.apache.org/jira/browse/YARN-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15113495#comment-15113495
]
Hudson commented on YARN-4496:
--
FAILURE: Integrated in Hadoop-trunk-Commit #9172 (See
[
https://issues.apache.org/jira/browse/YARN-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110464#comment-15110464
]
Hadoop QA commented on YARN-4496:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15111577#comment-15111577
]
Hadoop QA commented on YARN-4496:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15111907#comment-15111907
]
Hadoop QA commented on YARN-4496:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15109235#comment-15109235
]
Jian He commented on YARN-4496:
---
yeah, I actually tried to make them common when I started writing the patch
[
https://issues.apache.org/jira/browse/YARN-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15109212#comment-15109212
]
Arun Suresh commented on YARN-4496:
---
Thanks for the patch [~jianhe] !!
It looks good generally,
[
https://issues.apache.org/jira/browse/YARN-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15109286#comment-15109286
]
Arun Suresh commented on YARN-4496:
---
Agreed.. Couple of minor comments:
# I noticed that you had changed
[
https://issues.apache.org/jira/browse/YARN-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15109416#comment-15109416
]
Jian He commented on YARN-4496:
---
bq. Do we need that change ?
This method actually uses this flag
{code}
[
https://issues.apache.org/jira/browse/YARN-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15109726#comment-15109726
]
Xuan Gong commented on YARN-4496:
-
The patch looks good.
But can we separate these changes from this jira ?
[
https://issues.apache.org/jira/browse/YARN-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15109786#comment-15109786
]
Jian He commented on YARN-4496:
---
bq. when it is possible to evaluate it using HAUtil.isHAEnabled(conf) (like
[
https://issues.apache.org/jira/browse/YARN-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15109793#comment-15109793
]
Jian He commented on YARN-4496:
---
The v4 patch fixed comments from Xuan and Arun.
thank you both for the
[
https://issues.apache.org/jira/browse/YARN-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15109805#comment-15109805
]
Arun Suresh commented on YARN-4496:
---
Got it... missed that... thanks for clarifying
+1, pending jenkins
[
https://issues.apache.org/jira/browse/YARN-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15109770#comment-15109770
]
Jian He commented on YARN-4496:
---
ok , removed that change. will track separately
> Improve HA
[
https://issues.apache.org/jira/browse/YARN-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15109780#comment-15109780
]
Arun Suresh commented on YARN-4496:
---
bq. This method actually uses this flag
Correct.. but what I meant
[
https://issues.apache.org/jira/browse/YARN-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15109781#comment-15109781
]
Hadoop QA commented on YARN-4496:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15108356#comment-15108356
]
Hadoop QA commented on YARN-4496:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15107685#comment-15107685
]
Jian He commented on YARN-4496:
---
Uploaded a patch:
- added a new RequestHedgingRMFailoverProxyProvider. When
[
https://issues.apache.org/jira/browse/YARN-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15108014#comment-15108014
]
Hadoop QA commented on YARN-4496:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15101053#comment-15101053
]
Jian He commented on YARN-4496:
---
taking over, thanks !
> Improve HA ResourceManager Failover detection on
[
https://issues.apache.org/jira/browse/YARN-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15088332#comment-15088332
]
Arun Suresh commented on YARN-4496:
---
Hey [~jianhe], Feel free to take it up.. I can help with the
[
https://issues.apache.org/jira/browse/YARN-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15088251#comment-15088251
]
Jian He commented on YARN-4496:
---
+1, [~asuresh], are you working on this ?
> Improve HA ResourceManager
[
https://issues.apache.org/jira/browse/YARN-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15070140#comment-15070140
]
Subru Krishnan commented on YARN-4496:
--
+1. Thanks [~asuresh] for initiating this. To add more
[
https://issues.apache.org/jira/browse/YARN-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15069043#comment-15069043
]
Arun Suresh commented on YARN-4496:
---
Had a discussion with [~subru], and we think this would also be
25 matches
Mail list logo
