[
https://issues.apache.org/jira/browse/YARN-4997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15746988#comment-15746988
]
Tao Jie commented on YARN-4997:
---
Thank you [~sershe], I have created another JIRA YARN-6000 t
[
https://issues.apache.org/jira/browse/YARN-4997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15746948#comment-15746948
]
Sergey Shelukhin commented on YARN-4997:
We'd be ok with a different way; our exist
[
https://issues.apache.org/jira/browse/YARN-4997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15746936#comment-15746936
]
Tao Jie commented on YARN-4997:
---
[~sershe], we have discussed about the modifier of {{interfa
[
https://issues.apache.org/jira/browse/YARN-4997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15746522#comment-15746522
]
Sergey Shelukhin commented on YARN-4997:
this break the following piece of code in
[
https://issues.apache.org/jira/browse/YARN-4997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15709328#comment-15709328
]
Hudson commented on YARN-4997:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #1091
[
https://issues.apache.org/jira/browse/YARN-4997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15709263#comment-15709263
]
Daniel Templeton commented on YARN-4997:
[~Tao Jie], would you mind checking if the
[
https://issues.apache.org/jira/browse/YARN-4997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15709185#comment-15709185
]
Daniel Templeton commented on YARN-4997:
I'll let you slide on the method length ch
[
https://issues.apache.org/jira/browse/YARN-4997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15707929#comment-15707929
]
Hadoop QA commented on YARN-4997:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-4997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15707795#comment-15707795
]
Tao Jie commented on YARN-4997:
---
[~templedf], thanks for your patient review and sorry for in
[
https://issues.apache.org/jira/browse/YARN-4997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15706089#comment-15706089
]
Daniel Templeton commented on YARN-4997:
Thanks, [~Tao Jie]. Sorry to be fussy, bu
[
https://issues.apache.org/jira/browse/YARN-4997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15704462#comment-15704462
]
Tao Jie commented on YARN-4997:
---
Updated the patch respect to [~templedf]'s comment. The test
[
https://issues.apache.org/jira/browse/YARN-4997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15704153#comment-15704153
]
Hadoop QA commented on YARN-4997:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-4997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15703578#comment-15703578
]
Daniel Templeton commented on YARN-4997:
Thanks for updating the patch. Since [~ka
[
https://issues.apache.org/jira/browse/YARN-4997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15625237#comment-15625237
]
Hadoop QA commented on YARN-4997:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote |
[
https://issues.apache.org/jira/browse/YARN-4997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15625058#comment-15625058
]
Hadoop QA commented on YARN-4997:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-4997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15624840#comment-15624840
]
Tao Jie commented on YARN-4997:
---
Hi [~kasha], I rebased the patch for review.
For the semanti
[
https://issues.apache.org/jira/browse/YARN-4997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15611108#comment-15611108
]
Qiang Zhang commented on YARN-4997:
---
Hi,everyOne
this issue is very good,when this patch
[
https://issues.apache.org/jira/browse/YARN-4997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15454253#comment-15454253
]
Tao Jie commented on YARN-4997:
---
I looked more closely at {{synchronized}} in onReload. {{onR
[
https://issues.apache.org/jira/browse/YARN-4997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15454117#comment-15454117
]
Tao Jie commented on YARN-4997:
---
Thank you for your comments, [~kasha].
{quote}
Noticed there
[
https://issues.apache.org/jira/browse/YARN-4997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15453640#comment-15453640
]
Karthik Kambatla commented on YARN-4997:
Thanks for working on this, [~cassanada].
[
https://issues.apache.org/jira/browse/YARN-4997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15449165#comment-15449165
]
Tao Jie commented on YARN-4997:
---
Thank you [~templedf] for your review! [~kasha], could you
[
https://issues.apache.org/jira/browse/YARN-4997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15435823#comment-15435823
]
Daniel Templeton commented on YARN-4997:
+1 (non-binding). Thanks for all the patc
[
https://issues.apache.org/jira/browse/YARN-4997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15434090#comment-15434090
]
Hadoop QA commented on YARN-4997:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-4997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15434011#comment-15434011
]
Tao Jie commented on YARN-4997:
---
Oops！Fix this misspelling and update the patch.
> Update fa
[
https://issues.apache.org/jira/browse/YARN-4997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15433228#comment-15433228
]
Daniel Templeton commented on YARN-4997:
LGTM! Except... I apologize for not seei
[
https://issues.apache.org/jira/browse/YARN-4997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15433052#comment-15433052
]
Hadoop QA commented on YARN-4997:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-4997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15432909#comment-15432909
]
Tao Jie commented on YARN-4997:
---
Patch updated. Fix findbugs with add {{synchronized}} on {{s
[
https://issues.apache.org/jira/browse/YARN-4997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15431646#comment-15431646
]
Daniel Templeton commented on YARN-4997:
Thanks for the fresh patch. I looked more
[
https://issues.apache.org/jira/browse/YARN-4997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15430582#comment-15430582
]
Hadoop QA commented on YARN-4997:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-4997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15430503#comment-15430503
]
Tao Jie commented on YARN-4997:
---
Thanks for reply, [~templedf]. I updated the code and found
[
https://issues.apache.org/jira/browse/YARN-4997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15428697#comment-15428697
]
Daniel Templeton commented on YARN-4997:
Thanks for the updated patch, [~Tao Jie].
[
https://issues.apache.org/jira/browse/YARN-4997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15416452#comment-15416452
]
Hadoop QA commented on YARN-4997:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-4997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15416362#comment-15416362
]
Tao Jie commented on YARN-4997:
---
[~templedf], thanks for reply! For {{getDefaultPermissions()
[
https://issues.apache.org/jira/browse/YARN-4997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15415585#comment-15415585
]
Daniel Templeton commented on YARN-4997:
Thanks for the update. I still have a few
[
https://issues.apache.org/jira/browse/YARN-4997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15415150#comment-15415150
]
Hadoop QA commented on YARN-4997:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-4997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15415082#comment-15415082
]
Tao Jie commented on YARN-4997:
---
[~templedf], thanks for your review! And attached patch with
[
https://issues.apache.org/jira/browse/YARN-4997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15413907#comment-15413907
]
Daniel Templeton commented on YARN-4997:
Thanks for the patch, [~Tao Jie]. Overall
[
https://issues.apache.org/jira/browse/YARN-4997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15398987#comment-15398987
]
Hadoop QA commented on YARN-4997:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-4997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15398953#comment-15398953
]
Hadoop QA commented on YARN-4997:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-4997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15398871#comment-15398871
]
Tao Jie commented on YARN-4997:
---
Attached file fixed findbugs and unittests.
> Update fair s
[
https://issues.apache.org/jira/browse/YARN-4997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15398640#comment-15398640
]
Hadoop QA commented on YARN-4997:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-4997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15385256#comment-15385256
]
Tao Jie commented on YARN-4997:
---
Fix for review.
> Update fair scheduler to use pluggable au
[
https://issues.apache.org/jira/browse/YARN-4997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15372259#comment-15372259
]
Daniel Templeton commented on YARN-4997:
[~Tao Jie], you're welcome to take it.
>
[
https://issues.apache.org/jira/browse/YARN-4997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15363652#comment-15363652
]
Tao Jie commented on YARN-4997:
---
hi [~templedf], I would like to take this over, if you haven
44 matches
Mail list logo
