[
https://issues.apache.org/jira/browse/YARN-5105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15370294#comment-15370294
]
Varun Vasudev commented on YARN-5105:
-
Just noticed that the commit message for this patch has the
[
https://issues.apache.org/jira/browse/YARN-5105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15309217#comment-15309217
]
Varun Saxena commented on YARN-5105:
Thanks [~sjlee0] for the review and commit.
Thanks [~jrottinghuis]
[
https://issues.apache.org/jira/browse/YARN-5105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15308529#comment-15308529
]
Sangjin Lee commented on YARN-5105:
---
Committed the patch (v.05). Thanks [~varun_saxena] for your
[
https://issues.apache.org/jira/browse/YARN-5105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15308342#comment-15308342
]
Hadoop QA commented on YARN-5105:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15308298#comment-15308298
]
Sangjin Lee commented on YARN-5105:
---
The latest patch LGTM. I'll commit it once the jenkins comes back
[
https://issues.apache.org/jira/browse/YARN-5105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15307032#comment-15307032
]
Joep Rottinghuis commented on YARN-5105:
[~varun_saxena] I like the very clear description of
[
https://issues.apache.org/jira/browse/YARN-5105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15305215#comment-15305215
]
Varun Saxena commented on YARN-5105:
[~sjlee0], [~jrottinghuis], kindly review.
Checkstyle issues are
[
https://issues.apache.org/jira/browse/YARN-5105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15305029#comment-15305029
]
Hadoop QA commented on YARN-5105:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15304978#comment-15304978
]
Hadoop QA commented on YARN-5105:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15304977#comment-15304977
]
Hadoop QA commented on YARN-5105:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15304971#comment-15304971
]
Hadoop QA commented on YARN-5105:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15304951#comment-15304951
]
Hadoop QA commented on YARN-5105:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15304909#comment-15304909
]
Hadoop QA commented on YARN-5105:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15302354#comment-15302354
]
Joep Rottinghuis commented on YARN-5105:
Agreed, initially I suggested only two values and then I
[
https://issues.apache.org/jira/browse/YARN-5105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15301491#comment-15301491
]
Varun Saxena commented on YARN-5105:
bq. Given that we already have the concept of limit to limit the #
[
https://issues.apache.org/jira/browse/YARN-5105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15301193#comment-15301193
]
Joep Rottinghuis commented on YARN-5105:
While I agree that we can postpone the decision whether to
[
https://issues.apache.org/jira/browse/YARN-5105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300963#comment-15300963
]
Hadoop QA commented on YARN-5105:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300653#comment-15300653
]
Varun Saxena commented on YARN-5105:
Regarding YARN-4455 i.e. supporting time ranges for metrics. I was
[
https://issues.apache.org/jira/browse/YARN-5105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15299553#comment-15299553
]
Varun Saxena commented on YARN-5105:
{quote}
I think the awkwardness comes from the fact that whether
[
https://issues.apache.org/jira/browse/YARN-5105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15299452#comment-15299452
]
Sangjin Lee commented on YARN-5105:
---
Thanks for the update Varun!
I am going over the patch, and am
[
https://issues.apache.org/jira/browse/YARN-5105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15298354#comment-15298354
]
Varun Saxena commented on YARN-5105:
It seems that the test failure is due to separator char in app id.
[
https://issues.apache.org/jira/browse/YARN-5105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15298345#comment-15298345
]
Hadoop QA commented on YARN-5105:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15298271#comment-15298271
]
Hadoop QA commented on YARN-5105:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15298054#comment-15298054
]
Hadoop QA commented on YARN-5105:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15298034#comment-15298034
]
Varun Saxena commented on YARN-5105:
Added code to return HTTP 400 in above cases
> entire time series
[
https://issues.apache.org/jira/browse/YARN-5105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15297316#comment-15297316
]
Sangjin Lee commented on YARN-5105:
---
{quote}
One more thing we need to think about is behavior of fields
[
https://issues.apache.org/jira/browse/YARN-5105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15296884#comment-15296884
]
Hadoop QA commented on YARN-5105:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15296783#comment-15296783
]
Varun Saxena commented on YARN-5105:
A patch supporting METRICS_TIME_SERIES in fields to retrieve to
[
https://issues.apache.org/jira/browse/YARN-5105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15295179#comment-15295179
]
Varun Saxena commented on YARN-5105:
We cannot really set the number of versions to fetch on each
[
https://issues.apache.org/jira/browse/YARN-5105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15289236#comment-15289236
]
Sangjin Lee commented on YARN-5105:
---
I was thinking more along the line of emitting only the latest value
[
https://issues.apache.org/jira/browse/YARN-5105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15287624#comment-15287624
]
Varun Saxena commented on YARN-5105:
How do we handle it ? Have an explicit limit from user or have an
31 matches
Mail list logo
