[
https://issues.apache.org/jira/browse/YARN-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15369751#comment-15369751
]
Hudson commented on YARN-5109:
--
SUCCESS: Integrated in Hadoop-trunk-Commit #10074 (See
[
https://issues.apache.org/jira/browse/YARN-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15304659#comment-15304659
]
Varun Saxena commented on YARN-5109:
Thanks [~sjlee0] and [~jrottinghuis] for the review and commit.
[
https://issues.apache.org/jira/browse/YARN-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15303236#comment-15303236
]
Sangjin Lee commented on YARN-5109:
---
I am also +1 on the latest patch. I'll wait until the EOD for last
[
https://issues.apache.org/jira/browse/YARN-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15303184#comment-15303184
]
Joep Rottinghuis commented on YARN-5109:
+1: 07 patch looks good to me. Thanks for all the patience
[
https://issues.apache.org/jira/browse/YARN-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15302969#comment-15302969
]
Hadoop QA commented on YARN-5109:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15302963#comment-15302963
]
Varun Saxena commented on YARN-5109:
[~jrottinghuis], [~sjlee0], kindly review.
The build is clean.
[
https://issues.apache.org/jira/browse/YARN-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15302958#comment-15302958
]
Hadoop QA commented on YARN-5109:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15302764#comment-15302764
]
Varun Saxena commented on YARN-5109:
[~jrottinghuis], I am currently writing code for encoding tabs and
[
https://issues.apache.org/jira/browse/YARN-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15302736#comment-15302736
]
Joep Rottinghuis commented on YARN-5109:
[~varun_saxena] let's leave that replace alone for right
[
https://issues.apache.org/jira/browse/YARN-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15302672#comment-15302672
]
Varun Saxena commented on YARN-5109:
[~sjlee0], [~jrottinghuis]
In Separator#encode, we are using
[
https://issues.apache.org/jira/browse/YARN-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15302651#comment-15302651
]
Varun Saxena commented on YARN-5109:
testWriteNullApplicationToHBase was failing due to the test case
[
https://issues.apache.org/jira/browse/YARN-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15302548#comment-15302548
]
Hadoop QA commented on YARN-5109:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15302534#comment-15302534
]
Varun Saxena commented on YARN-5109:
Yeah, hadnt rebased the branch. Will check.
> timestamps are
[
https://issues.apache.org/jira/browse/YARN-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15302528#comment-15302528
]
Sangjin Lee commented on YARN-5109:
---
Also, one of the unit tests is failing. Haven't checked again if the
[
https://issues.apache.org/jira/browse/YARN-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15302520#comment-15302520
]
Varun Saxena commented on YARN-5109:
Ohh...I hadn't updated my branch. Let me fix this and update.
>
[
https://issues.apache.org/jira/browse/YARN-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15302510#comment-15302510
]
Sangjin Lee commented on YARN-5109:
---
Thanks for updating the patch [~varun_saxena]! I'll go over it one
[
https://issues.apache.org/jira/browse/YARN-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15302345#comment-15302345
]
Joep Rottinghuis commented on YARN-5109:
Indeed it is easy to do now with the way KeyConverter and
[
https://issues.apache.org/jira/browse/YARN-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15301889#comment-15301889
]
Varun Saxena commented on YARN-5109:
bq. It would be relatively easy to encode (and decode) tabs in
[
https://issues.apache.org/jira/browse/YARN-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15301051#comment-15301051
]
Joep Rottinghuis commented on YARN-5109:
[~varun_saxena] please go ahead with the patch. I was
[
https://issues.apache.org/jira/browse/YARN-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300646#comment-15300646
]
Varun Saxena commented on YARN-5109:
By the way, we are encoding spaces in column qualifiers. Any
[
https://issues.apache.org/jira/browse/YARN-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300570#comment-15300570
]
Varun Saxena commented on YARN-5109:
Regarding point 1, I had seen this while coding.
[
https://issues.apache.org/jira/browse/YARN-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15299567#comment-15299567
]
Joep Rottinghuis commented on YARN-5109:
Overall, the approach and implementation looks really
[
https://issues.apache.org/jira/browse/YARN-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15299023#comment-15299023
]
Hadoop QA commented on YARN-5109:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15299022#comment-15299022
]
Hadoop QA commented on YARN-5109:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15298851#comment-15298851
]
Varun Saxena commented on YARN-5109:
Makes sense. Will make it private.
> timestamps are stored
[
https://issues.apache.org/jira/browse/YARN-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15298433#comment-15298433
]
Sangjin Lee commented on YARN-5109:
---
Thanks for updating the patch [~varun_saxena]! I think it's almost
[
https://issues.apache.org/jira/browse/YARN-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15298019#comment-15298019
]
Hadoop QA commented on YARN-5109:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15297969#comment-15297969
]
Hadoop QA commented on YARN-5109:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15297844#comment-15297844
]
Varun Saxena commented on YARN-5109:
bq. Also, do we have a test that tests an encoded long having a
[
https://issues.apache.org/jira/browse/YARN-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15297099#comment-15297099
]
Sangjin Lee commented on YARN-5109:
---
Thanks [~varun_saxena] for the patch! I think it's almost there. I
[
https://issues.apache.org/jira/browse/YARN-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15295281#comment-15295281
]
Hadoop QA commented on YARN-5109:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15295257#comment-15295257
]
Hadoop QA commented on YARN-5109:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15295242#comment-15295242
]
Varun Saxena commented on YARN-5109:
Consistently getting build failures on Jenkins with following
[
https://issues.apache.org/jira/browse/YARN-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15295203#comment-15295203
]
Varun Saxena commented on YARN-5109:
Updating a patch trying to fix checkstyle issues.
> timestamps
[
https://issues.apache.org/jira/browse/YARN-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15295159#comment-15295159
]
Hadoop QA commented on YARN-5109:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15294610#comment-15294610
]
Joep Rottinghuis commented on YARN-5109:
Seems sensible. Looking forward to see in context on patch
[
https://issues.apache.org/jira/browse/YARN-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15294603#comment-15294603
]
Varun Saxena commented on YARN-5109:
[~sjlee0], yeah this doesnt break anything. I was just curious to
[
https://issues.apache.org/jira/browse/YARN-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15294601#comment-15294601
]
Varun Saxena commented on YARN-5109:
[~sjlee0],
Yes, type safety will have to be ensured within this
[
https://issues.apache.org/jira/browse/YARN-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15294600#comment-15294600
]
Joep Rottinghuis commented on YARN-5109:
Agreed with [~sjlee0] that we'd like to avoid non-type
[
https://issues.apache.org/jira/browse/YARN-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15294595#comment-15294595
]
Joep Rottinghuis commented on YARN-5109:
bq. The main motivation for reversing the user and the
[
https://issues.apache.org/jira/browse/YARN-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15294559#comment-15294559
]
Sangjin Lee commented on YARN-5109:
---
Hmm, could you point to the specific method where the proposed
[
https://issues.apache.org/jira/browse/YARN-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15294555#comment-15294555
]
Sangjin Lee commented on YARN-5109:
---
[~jrottinghuis], [~vrushalic], and I dug a little bit, and it
[
https://issues.apache.org/jira/browse/YARN-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15294277#comment-15294277
]
Varun Saxena commented on YARN-5109:
Infact even getColumnPrefixBytes would not work for the code in
[
https://issues.apache.org/jira/browse/YARN-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15294198#comment-15294198
]
Varun Saxena commented on YARN-5109:
Just to update, the patch is almost complete.
Will have it up by
[
https://issues.apache.org/jira/browse/YARN-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15293975#comment-15293975
]
Hadoop QA commented on YARN-5109:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15293713#comment-15293713
]
Sangjin Lee commented on YARN-5109:
---
The {{ApplicationTable}} and {{EntityTable}} javadoc also reflect
[
https://issues.apache.org/jira/browse/YARN-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15293705#comment-15293705
]
Sangjin Lee commented on YARN-5109:
---
Hmm, I don't remember there was a reason the application row key had
[
https://issues.apache.org/jira/browse/YARN-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15293666#comment-15293666
]
Varun Saxena commented on YARN-5109:
[~sjlee0], any reason we have clusterid followed by user id in
[
https://issues.apache.org/jira/browse/YARN-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15293464#comment-15293464
]
Varun Saxena commented on YARN-5109:
Yes I have taken that patch and working on top of it.
>
[
https://issues.apache.org/jira/browse/YARN-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15293458#comment-15293458
]
Joep Rottinghuis commented on YARN-5109:
The code in the patch I attached compiles and clears unit
[
https://issues.apache.org/jira/browse/YARN-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15293028#comment-15293028
]
Varun Saxena commented on YARN-5109:
Thanks Sangjin and Joep for the pseudocode and prototype.
Now I
[
https://issues.apache.org/jira/browse/YARN-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15292819#comment-15292819
]
Joep Rottinghuis commented on YARN-5109:
[~varun_saxena] I'm going to briefly assign this jira to
[
https://issues.apache.org/jira/browse/YARN-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15292696#comment-15292696
]
Joep Rottinghuis commented on YARN-5109:
I have an almost working prototype where we can combined
[
https://issues.apache.org/jira/browse/YARN-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15292270#comment-15292270
]
Sangjin Lee commented on YARN-5109:
---
Another related issue I see is currently the event id and the info
[
https://issues.apache.org/jira/browse/YARN-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15292229#comment-15292229
]
Sangjin Lee commented on YARN-5109:
---
Joep, Vrushali, and I discussed some more offline, and we realized
[
https://issues.apache.org/jira/browse/YARN-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291983#comment-15291983
]
Varun Saxena commented on YARN-5109:
Writing down what we discussed in the meeting with regards to
[
https://issues.apache.org/jira/browse/YARN-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291529#comment-15291529
]
Varun Saxena commented on YARN-5109:
Sure. Lets discuss this in the meeting.
Basically column
[
https://issues.apache.org/jira/browse/YARN-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291498#comment-15291498
]
Sangjin Lee commented on YARN-5109:
---
Good point about the column qualifiers not needing the correct
[
https://issues.apache.org/jira/browse/YARN-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15290991#comment-15290991
]
Varun Saxena commented on YARN-5109:
Thanks [~sjlee0].
I did realize this issue with timestamps in row
[
https://issues.apache.org/jira/browse/YARN-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15290166#comment-15290166
]
Sangjin Lee commented on YARN-5109:
---
Here is a proposal. Instead of blindly splitting along the separator
[
https://issues.apache.org/jira/browse/YARN-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15289895#comment-15289895
]
Sangjin Lee commented on YARN-5109:
---
I spoke with [~jrottinghuis] offline about this. Initially we were
[
https://issues.apache.org/jira/browse/YARN-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15289571#comment-15289571
]
Sangjin Lee commented on YARN-5109:
---
These are the all the cases of "naked" joins:
[
https://issues.apache.org/jira/browse/YARN-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15289237#comment-15289237
]
Varun Saxena commented on YARN-5109:
Thanks [~sjlee0].
Yes, I am in the process of coding for this i.e.
[
https://issues.apache.org/jira/browse/YARN-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15289207#comment-15289207
]
Sangjin Lee commented on YARN-5109:
---
Thanks for looking into this [~varun_saxena]. It might be good to
[
https://issues.apache.org/jira/browse/YARN-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15288444#comment-15288444
]
Sangjin Lee commented on YARN-5109:
---
For example, code that creates the column name for events:
{code}
65 matches
Mail list logo
