[jira] [Commented] (YARN-5170) Eliminate singleton converters and static method access

[ https://issues.apache.org/jira/browse/YARN-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15369795#comment-15369795 ] Hudson commented on YARN-5170: -- SUCCESS: Integrated in Hadoop-trunk-Commit #10074 (See

[jira] [Commented] (YARN-5170) Eliminate singleton converters and static method access

[ https://issues.apache.org/jira/browse/YARN-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15324638#comment-15324638 ] Varun Saxena commented on YARN-5170: Committed this to YARN-2928 branch. Thanks [~jrottinghuis] for

[jira] [Commented] (YARN-5170) Eliminate singleton converters and static method access

[ https://issues.apache.org/jira/browse/YARN-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15324614#comment-15324614 ] Joep Rottinghuis commented on YARN-5170: Better yet, why don't you commit this in as-is. Then I'll

[jira] [Commented] (YARN-5170) Eliminate singleton converters and static method access

[ https://issues.apache.org/jira/browse/YARN-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15324618#comment-15324618 ] Varun Saxena commented on YARN-5170: Should be fine to handle it later. I am frankly fine either ways

[jira] [Commented] (YARN-5170) Eliminate singleton converters and static method access

[ https://issues.apache.org/jira/browse/YARN-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15324611#comment-15324611 ] Joep Rottinghuis commented on YARN-5170: You're right, that's one thing I overlooked. I can upload

[jira] [Commented] (YARN-5170) Eliminate singleton converters and static method access

[ https://issues.apache.org/jira/browse/YARN-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15324608#comment-15324608 ] Varun Saxena commented on YARN-5170: Will commit it shortly. > Eliminate singleton converters and

[jira] [Commented] (YARN-5170) Eliminate singleton converters and static method access

[ https://issues.apache.org/jira/browse/YARN-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15324587#comment-15324587 ] Varun Saxena commented on YARN-5170: [~jrottinghuis] One thing which I had pointed out earlier was : In

[jira] [Commented] (YARN-5170) Eliminate singleton converters and static method access

[ https://issues.apache.org/jira/browse/YARN-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15324568#comment-15324568 ] Joep Rottinghuis commented on YARN-5170: Thanks for tackling last static use and adjusting the

[jira] [Commented] (YARN-5170) Eliminate singleton converters and static method access

[ https://issues.apache.org/jira/browse/YARN-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15324530#comment-15324530 ] Hadoop QA commented on YARN-5170: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5170) Eliminate singleton converters and static method access

[ https://issues.apache.org/jira/browse/YARN-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15324525#comment-15324525 ] Hadoop QA commented on YARN-5170: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5170) Eliminate singleton converters and static method access

[ https://issues.apache.org/jira/browse/YARN-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15324504#comment-15324504 ] Varun Saxena commented on YARN-5170: Posted patch v13. > Eliminate singleton converters and static

[jira] [Commented] (YARN-5170) Eliminate singleton converters and static method access

[ https://issues.apache.org/jira/browse/YARN-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15324481#comment-15324481 ] Varun Saxena commented on YARN-5170: Infact couple of more comments. 1. We are still using

[jira] [Commented] (YARN-5170) Eliminate singleton converters and static method access

[ https://issues.apache.org/jira/browse/YARN-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15324383#comment-15324383 ] Varun Saxena commented on YARN-5170: One more comment. RowKeyPrefix interface is in

[jira] [Commented] (YARN-5170) Eliminate singleton converters and static method access

[ https://issues.apache.org/jira/browse/YARN-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15324019#comment-15324019 ] Hadoop QA commented on YARN-5170: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5170) Eliminate singleton converters and static method access

[ https://issues.apache.org/jira/browse/YARN-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15323964#comment-15323964 ] Varun Saxena commented on YARN-5170: The build had gone to H8 so wasnt invoked. Invoked it from

[jira] [Commented] (YARN-5170) Eliminate singleton converters and static method access

[ https://issues.apache.org/jira/browse/YARN-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15323921#comment-15323921 ] Joep Rottinghuis commented on YARN-5170: That's awkward. Not sure how Eclipse slipped that one in.

[jira] [Commented] (YARN-5170) Eliminate singleton converters and static method access

[ https://issues.apache.org/jira/browse/YARN-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15323916#comment-15323916 ] Li Lu commented on YARN-5170: - Oops the author tag is a real problem. Others looks in green though. >

[jira] [Commented] (YARN-5170) Eliminate singleton converters and static method access

[ https://issues.apache.org/jira/browse/YARN-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15323911#comment-15323911 ] Hadoop QA commented on YARN-5170: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5170) Eliminate singleton converters and static method access

[ https://issues.apache.org/jira/browse/YARN-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15323908#comment-15323908 ] Hadoop QA commented on YARN-5170: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5170) Eliminate singleton converters and static method access

[ https://issues.apache.org/jira/browse/YARN-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15323880#comment-15323880 ] Vrushali C commented on YARN-5170: -- Have restarted the build several times but seems to pick H8 all the

[jira] [Commented] (YARN-5170) Eliminate singleton converters and static method access

[ https://issues.apache.org/jira/browse/YARN-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15323879#comment-15323879 ] Li Lu commented on YARN-5170: - Sure. Kicked https://builds.apache.org/job/PreCommit-YARN-Build/11961/ >

[jira] [Commented] (YARN-5170) Eliminate singleton converters and static method access

[ https://issues.apache.org/jira/browse/YARN-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15323875#comment-15323875 ] Varun Saxena commented on YARN-5170: Ok...Will have one final look and commit it later today, if no

[jira] [Commented] (YARN-5170) Eliminate singleton converters and static method access

[ https://issues.apache.org/jira/browse/YARN-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15323872#comment-15323872 ] Joep Rottinghuis commented on YARN-5170: Thanks [~gtCarrera9] could you please poke the build?

[jira] [Commented] (YARN-5170) Eliminate singleton converters and static method access

[ https://issues.apache.org/jira/browse/YARN-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15323865#comment-15323865 ] Li Lu commented on YARN-5170: - Thanks [~jrottinghuis]! Last patch LGTM. +1 pending Jenkins. Please feel free

[jira] [Commented] (YARN-5170) Eliminate singleton converters and static method access

[ https://issues.apache.org/jira/browse/YARN-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15323835#comment-15323835 ] Joep Rottinghuis commented on YARN-5170: Separate jira filed: YARN-5229 > Eliminate singleton

[jira] [Commented] (YARN-5170) Eliminate singleton converters and static method access

[ https://issues.apache.org/jira/browse/YARN-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15323633#comment-15323633 ] Li Lu commented on YARN-5170: - Ah that's fine. Let's not expose it in the milestone then. Let's open another

[jira] [Commented] (YARN-5170) Eliminate singleton converters and static method access

[ https://issues.apache.org/jira/browse/YARN-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15323631#comment-15323631 ] Joep Rottinghuis commented on YARN-5170: Thanks for the review [~gtCarrera9] bq. In

[jira] [Commented] (YARN-5170) Eliminate singleton converters and static method access

[ https://issues.apache.org/jira/browse/YARN-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15323601#comment-15323601 ] Li Lu commented on YARN-5170: - Thanks for the work [~jrottinghuis]! This is a big one and generally LGTM. I

[jira] [Commented] (YARN-5170) Eliminate singleton converters and static method access

[ https://issues.apache.org/jira/browse/YARN-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15323562#comment-15323562 ] Hadoop QA commented on YARN-5170: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5170) Eliminate singleton converters and static method access

[ https://issues.apache.org/jira/browse/YARN-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15323496#comment-15323496 ] Li Lu commented on YARN-5170: - Thanks [~jrottinghuis] and [~varun_saxena] for the work! I'll take a look at it

[jira] [Commented] (YARN-5170) Eliminate singleton converters and static method access

[ https://issues.apache.org/jira/browse/YARN-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15322919#comment-15322919 ] Joep Rottinghuis commented on YARN-5170: [~varun_saxena] Thank you for your review, this is great

[jira] [Commented] (YARN-5170) Eliminate singleton converters and static method access

[ https://issues.apache.org/jira/browse/YARN-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15322825#comment-15322825 ] Varun Saxena commented on YARN-5170: One more comment : In HBaseTimelineWriterImpl#storeEvents, we

[jira] [Commented] (YARN-5170) Eliminate singleton converters and static method access

[ https://issues.apache.org/jira/browse/YARN-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15322719#comment-15322719 ] Varun Saxena commented on YARN-5170: The patch looks largely good to me. Few points. # Maybe its just

[jira] [Commented] (YARN-5170) Eliminate singleton converters and static method access

[ https://issues.apache.org/jira/browse/YARN-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15322626#comment-15322626 ] Varun Saxena commented on YARN-5170: The patch looks largely good to me. A couple of points. #

[jira] [Commented] (YARN-5170) Eliminate singleton converters and static method access

[ https://issues.apache.org/jira/browse/YARN-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15322627#comment-15322627 ] Varun Saxena commented on YARN-5170: The patch looks largely good to me. A couple of points. #

[jira] [Commented] (YARN-5170) Eliminate singleton converters and static method access

[ https://issues.apache.org/jira/browse/YARN-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15322177#comment-15322177 ] Hadoop QA commented on YARN-5170: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5170) Eliminate singleton converters and static method access

[ https://issues.apache.org/jira/browse/YARN-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15321971#comment-15321971 ] Hadoop QA commented on YARN-5170: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5170) Eliminate singleton converters and static method access

[ https://issues.apache.org/jira/browse/YARN-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15321966#comment-15321966 ] Varun Saxena commented on YARN-5170: [~jrottinghuis], this JIRA was targeted for 1st milestone ? >

[jira] [Commented] (YARN-5170) Eliminate singleton converters and static method access

[ https://issues.apache.org/jira/browse/YARN-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15321859#comment-15321859 ] Joep Rottinghuis commented on YARN-5170: YARN-5170-YARN-2928.08.patch uploaded, Still waiting for

[jira] [Commented] (YARN-5170) Eliminate singleton converters and static method access

[ https://issues.apache.org/jira/browse/YARN-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15321832#comment-15321832 ] Hadoop QA commented on YARN-5170: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5170) Eliminate singleton converters and static method access

[ https://issues.apache.org/jira/browse/YARN-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15321742#comment-15321742 ] Hadoop QA commented on YARN-5170: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5170) Eliminate singleton converters and static method access

[ https://issues.apache.org/jira/browse/YARN-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15321222#comment-15321222 ] Vrushali C commented on YARN-5170: -- I applied the patch on my laptop and all the tests in

[jira] [Commented] (YARN-5170) Eliminate singleton converters and static method access

[ https://issues.apache.org/jira/browse/YARN-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15320153#comment-15320153 ] Joep Rottinghuis commented on YARN-5170: Will address license, find bugs and check style warnings.

[jira] [Commented] (YARN-5170) Eliminate singleton converters and static method access

[ https://issues.apache.org/jira/browse/YARN-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15320023#comment-15320023 ] Hadoop QA commented on YARN-5170: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5170) Eliminate singleton converters and static method access

[ https://issues.apache.org/jira/browse/YARN-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15319991#comment-15319991 ] Vrushali C commented on YARN-5170: -- Alright, it picked H6 now

[jira] [Commented] (YARN-5170) Eliminate singleton converters and static method access

[ https://issues.apache.org/jira/browse/YARN-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15319989#comment-15319989 ] Vrushali C commented on YARN-5170: -- Looks like build failed again

[jira] [Commented] (YARN-5170) Eliminate singleton converters and static method access

[ https://issues.apache.org/jira/browse/YARN-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15319662#comment-15319662 ] Hadoop QA commented on YARN-5170: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5170) Eliminate singleton converters and static method access

[ https://issues.apache.org/jira/browse/YARN-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15319532#comment-15319532 ] Hadoop QA commented on YARN-5170: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5170) Eliminate singleton converters and static method access

[ https://issues.apache.org/jira/browse/YARN-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15319481#comment-15319481 ] Joep Rottinghuis commented on YARN-5170: I'm annotating the *RowKeyConverter classes with

[jira] [Commented] (YARN-5170) Eliminate singleton converters and static method access

[ https://issues.apache.org/jira/browse/YARN-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15319464#comment-15319464 ] Vrushali C commented on YARN-5170: -- Yes, I had resubmitted the build, but that failed too. Didn't notice

[jira] [Commented] (YARN-5170) Eliminate singleton converters and static method access

[ https://issues.apache.org/jira/browse/YARN-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15319311#comment-15319311 ] Varun Saxena commented on YARN-5170: This is a long standing issue. YARN-2928 build always breaks on

[jira] [Commented] (YARN-5170) Eliminate singleton converters and static method access

[ https://issues.apache.org/jira/browse/YARN-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15319218#comment-15319218 ] Vrushali C commented on YARN-5170: -- Perhaps your patch is not off of the latest head, I think,

[jira] [Commented] (YARN-5170) Eliminate singleton converters and static method access

[ https://issues.apache.org/jira/browse/YARN-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15319214#comment-15319214 ] Vrushali C commented on YARN-5170: -- I have restarted the build

[jira] [Commented] (YARN-5170) Eliminate singleton converters and static method access

[ https://issues.apache.org/jira/browse/YARN-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15319213#comment-15319213 ] Vrushali C commented on YARN-5170: -- Here is the console output of the jenkins build

[jira] [Commented] (YARN-5170) Eliminate singleton converters and static method access

[ https://issues.apache.org/jira/browse/YARN-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15315291#comment-15315291 ] Joep Rottinghuis commented on YARN-5170: Rebasing my own patch to pick up work from YARN-5189 and

[jira] [Commented] (YARN-5170) Eliminate singleton converters and static method access

[ https://issues.apache.org/jira/browse/YARN-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15304653#comment-15304653 ] Joep Rottinghuis commented on YARN-5170: General concern with singletons that they start out

[jira] [Commented] (YARN-5170) Eliminate singleton converters and static method access

[ https://issues.apache.org/jira/browse/YARN-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15304588#comment-15304588 ] Varun Saxena commented on YARN-5170: Removal of static methods is a good idea. Especially the methods