[jira] [Commented] (YARN-5392) Replace use of Priority in the Scheduling infrastructure with an opaque ShedulerKey

2016-07-26 Thread Karthik Kambatla (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15394594#comment-15394594 ] Karthik Kambatla commented on YARN-5392: +1. Thanks for your patience through the reviews, Arun.

[jira] [Commented] (YARN-5392) Replace use of Priority in the Scheduling infrastructure with an opaque ShedulerKey

2016-07-26 Thread Arun Suresh (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15394580#comment-15394580 ] Arun Suresh commented on YARN-5392: --- The test failure is unrelated > Replace use of Priority in the

[jira] [Commented] (YARN-5392) Replace use of Priority in the Scheduling infrastructure with an opaque ShedulerKey

2016-07-26 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15394551#comment-15394551 ] Hadoop QA commented on YARN-5392: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5392) Replace use of Priority in the Scheduling infrastructure with an opaque ShedulerKey

2016-07-26 Thread Karthik Kambatla (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15394449#comment-15394449 ] Karthik Kambatla commented on YARN-5392: In my comments above, 2.1 still applies. Otherwise, looks

[jira] [Commented] (YARN-5392) Replace use of Priority in the Scheduling infrastructure with an opaque ShedulerKey

2016-07-25 Thread Arun Suresh (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15393230#comment-15393230 ] Arun Suresh commented on YARN-5392: --- The remaining checkstyles are all related to method parameters /

[jira] [Commented] (YARN-5392) Replace use of Priority in the Scheduling infrastructure with an opaque ShedulerKey

2016-07-25 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15392819#comment-15392819 ] Hadoop QA commented on YARN-5392: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5392) Replace use of Priority in the Scheduling infrastructure with an opaque ShedulerKey

2016-07-24 Thread Arun Suresh (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15391356#comment-15391356 ] Arun Suresh commented on YARN-5392: --- Thanks for taking a look [~kasha], bq. The name is very

[jira] [Commented] (YARN-5392) Replace use of Priority in the Scheduling infrastructure with an opaque ShedulerKey

2016-07-24 Thread Karthik Kambatla (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15391285#comment-15391285 ] Karthik Kambatla commented on YARN-5392: Patch looks mostly good. Have mostly minor comments: #

[jira] [Commented] (YARN-5392) Replace use of Priority in the Scheduling infrastructure with an opaque ShedulerKey

2016-07-24 Thread Karthik Kambatla (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15391272#comment-15391272 ] Karthik Kambatla commented on YARN-5392: Looking into this now.. > Replace use of Priority in the

[jira] [Commented] (YARN-5392) Replace use of Priority in the Scheduling infrastructure with an opaque ShedulerKey

2016-07-22 Thread Arun Suresh (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15390355#comment-15390355 ] Arun Suresh commented on YARN-5392: --- thanks [~leftnoteasy] .. will do > Replace use of Priority in the

[jira] [Commented] (YARN-5392) Replace use of Priority in the Scheduling infrastructure with an opaque ShedulerKey

2016-07-22 Thread Wangda Tan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15390346#comment-15390346 ] Wangda Tan commented on YARN-5392: -- Looks good, thanks [~asuresh]. But I really hope you could wait for

[jira] [Commented] (YARN-5392) Replace use of Priority in the Scheduling infrastructure with an opaque ShedulerKey

2016-07-22 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389064#comment-15389064 ] Hadoop QA commented on YARN-5392: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5392) Replace use of Priority in the Scheduling infrastructure with an opaque ShedulerKey

2016-07-21 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15388960#comment-15388960 ] Hadoop QA commented on YARN-5392: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5392) Replace use of Priority in the Scheduling infrastructure with an opaque ShedulerKey

2016-07-21 Thread Wangda Tan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15388597#comment-15388597 ] Wangda Tan commented on YARN-5392: -- Thanks for updating, [~asuresh]: Some more comments: 1) Many places

[jira] [Commented] (YARN-5392) Replace use of Priority in the Scheduling infrastructure with an opaque ShedulerKey

2016-07-21 Thread Sunil G (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387992#comment-15387992 ] Sunil G commented on YARN-5392: --- Sure. That make sense, I will create an issue to track same. > Replace use

[jira] [Commented] (YARN-5392) Replace use of Priority in the Scheduling infrastructure with an opaque ShedulerKey

2016-07-21 Thread Arun Suresh (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387775#comment-15387775 ] Arun Suresh commented on YARN-5392: --- [~sunilg], true... also it seems to be used only in testclasses. Did

[jira] [Commented] (YARN-5392) Replace use of Priority in the Scheduling infrastructure with an opaque ShedulerKey

2016-07-21 Thread Sunil G (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387561#comment-15387561 ] Sunil G commented on YARN-5392: --- Hi [~asuresh] If

[jira] [Commented] (YARN-5392) Replace use of Priority in the Scheduling infrastructure with an opaque ShedulerKey

2016-07-21 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387240#comment-15387240 ] Hadoop QA commented on YARN-5392: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5392) Replace use of Priority in the Scheduling infrastructure with an opaque ShedulerKey

2016-07-20 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387099#comment-15387099 ] Hadoop QA commented on YARN-5392: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5392) Replace use of Priority in the Scheduling infrastructure with an opaque ShedulerKey

2016-07-20 Thread Wangda Tan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15386738#comment-15386738 ] Wangda Tan commented on YARN-5392: -- [~asuresh], as we discussed offline with [~subru], sorting application

[jira] [Commented] (YARN-5392) Replace use of Priority in the Scheduling infrastructure with an opaque ShedulerKey

2016-07-20 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15386723#comment-15386723 ] Hadoop QA commented on YARN-5392: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5392) Replace use of Priority in the Scheduling infrastructure with an opaque ShedulerKey

2016-07-20 Thread Arun Suresh (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15386676#comment-15386676 ] Arun Suresh commented on YARN-5392: --- [~leftnoteasy], I understand we've touched a lot of the code, but

[jira] [Commented] (YARN-5392) Replace use of Priority in the Scheduling infrastructure with an opaque ShedulerKey

2016-07-20 Thread Wangda Tan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15386628#comment-15386628 ] Wangda Tan commented on YARN-5392: -- [~asuresh], I can understand that YARN-4888 needs a class to combine

[jira] [Commented] (YARN-5392) Replace use of Priority in the Scheduling infrastructure with an opaque ShedulerKey

2016-07-20 Thread Arun Suresh (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15386594#comment-15386594 ] Arun Suresh commented on YARN-5392: --- Thanks for the taking a look [~leftnoteasy], Agree that currently it

[jira] [Commented] (YARN-5392) Replace use of Priority in the Scheduling infrastructure with an opaque ShedulerKey

2016-07-20 Thread Wangda Tan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15386581#comment-15386581 ] Wangda Tan commented on YARN-5392: -- [~asuresh], [~subru]. I'm not quite sure about why we need a

[jira] [Commented] (YARN-5392) Replace use of Priority in the Scheduling infrastructure with an opaque ShedulerKey

2016-07-19 Thread Subru Krishnan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15385055#comment-15385055 ] Subru Krishnan commented on YARN-5392: -- Thanks [~asuresh] for working on this. I just have one

[jira] [Commented] (YARN-5392) Replace use of Priority in the Scheduling infrastructure with an opaque ShedulerKey

2016-07-19 Thread Arun Suresh (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15384596#comment-15384596 ] Arun Suresh commented on YARN-5392: --- ping [~kasha], [~subru].. wondering if you might be able to give

[jira] [Commented] (YARN-5392) Replace use of Priority in the Scheduling infrastructure with an opaque ShedulerKey

2016-07-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381815#comment-15381815 ] Hadoop QA commented on YARN-5392: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5392) Replace use of Priority in the Scheduling infrastructure with an opaque ShedulerKey

2016-07-17 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381715#comment-15381715 ] Hadoop QA commented on YARN-5392: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5392) Replace use of Priority in the Scheduling infrastructure with an opaque ShedulerKey

2016-07-17 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381270#comment-15381270 ] Hadoop QA commented on YARN-5392: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||