[jira] [Commented] (YARN-5525) Make log aggregation service class configurable

2016-12-05 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15723872#comment-15723872 ] Jian He commented on YARN-5525: --- yeah, we should probably have both log aggregator and logFetcher pluggable

[jira] [Commented] (YARN-5525) Make log aggregation service class configurable

2016-11-28 Thread Xuan Gong (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15703613#comment-15703613 ] Xuan Gong commented on YARN-5525: - bq. then I assume they will handle the downstream log usage, and it is

[jira] [Commented] (YARN-5525) Make log aggregation service class configurable

2016-11-28 Thread Botong Huang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15703107#comment-15703107 ] Botong Huang commented on YARN-5525: Thanks [~xgong], yes this is an issue. I am thinking if the

[jira] [Commented] (YARN-5525) Make log aggregation service class configurable

2016-11-28 Thread Xuan Gong (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15702688#comment-15702688 ] Xuan Gong commented on YARN-5525: - [~botong] [~jianhe] So, if the customer can customize the log

[jira] [Commented] (YARN-5525) Make log aggregation service class configurable

2016-10-28 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15616374#comment-15616374 ] Hadoop QA commented on YARN-5525: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5525) Make log aggregation service class configurable

2016-10-27 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15613940#comment-15613940 ] Hadoop QA commented on YARN-5525: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5525) Make log aggregation service class configurable

2016-10-27 Thread Botong Huang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15613469#comment-15613469 ] Botong Huang commented on YARN-5525: Hi Xuan, ContainerLogAggregationPolicy only provides interface to

[jira] [Commented] (YARN-5525) Make log aggregation service class configurable

2016-10-27 Thread Xuan Gong (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15613387#comment-15613387 ] Xuan Gong commented on YARN-5525: - [~botong] bq. What if the cluster provider doesn't want to use the

[jira] [Commented] (YARN-5525) Make log aggregation service class configurable

2016-10-21 Thread Botong Huang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15596356#comment-15596356 ] Botong Huang commented on YARN-5525: True, so I will only add the new field in LogAggregationContext

[jira] [Commented] (YARN-5525) Make log aggregation service class configurable

2016-10-21 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15596232#comment-15596232 ] Jian He commented on YARN-5525: --- bq. How about I add the AppLogAggregator in Yarn conf as the

[jira] [Commented] (YARN-5525) Make log aggregation service class configurable

2016-10-20 Thread Botong Huang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15593535#comment-15593535 ] Botong Huang commented on YARN-5525: Thanks all or the comment! bq. Are we going to change

[jira] [Commented] (YARN-5525) Make log aggregation service class configurable

2016-10-20 Thread Botong Huang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15593384#comment-15593384 ] Botong Huang commented on YARN-5525: Thanks [~jianhe] for the comment! bq. Are we going to change

[jira] [Commented] (YARN-5525) Make log aggregation service class configurable

2016-10-20 Thread Xuan Gong (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15593015#comment-15593015 ] Xuan Gong commented on YARN-5525: - bq. push it down completely to AppLogAggregatorImpl rather than make it

[jira] [Commented] (YARN-5525) Make log aggregation service class configurable

2016-10-20 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15592878#comment-15592878 ] Jian He commented on YARN-5525: --- bq. push it down completely to AppLogAggregatorImpl I vote for this. This

[jira] [Commented] (YARN-5525) Make log aggregation service class configurable

2016-09-30 Thread Subru Krishnan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15537719#comment-15537719 ] Subru Krishnan commented on YARN-5525: -- Thanks [~botong] for the clarification. With the additional

[jira] [Commented] (YARN-5525) Make log aggregation service class configurable

2016-09-30 Thread Botong Huang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15536720#comment-15536720 ] Botong Huang commented on YARN-5525: Thanks [~subru] for the comment. I see your concern. Yes, I agree

[jira] [Commented] (YARN-5525) Make log aggregation service class configurable

2016-09-29 Thread Subru Krishnan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15534903#comment-15534903 ] Subru Krishnan commented on YARN-5525: -- Thanks [~botong] for your response. bq. One reason that we

[jira] [Commented] (YARN-5525) Make log aggregation service class configurable

2016-09-23 Thread Botong Huang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15517594#comment-15517594 ] Botong Huang commented on YARN-5525: Thank [~subru] for the review and comments. Let me provide some

[jira] [Commented] (YARN-5525) Make log aggregation service class configurable

2016-09-23 Thread Subru Krishnan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15517484#comment-15517484 ] Subru Krishnan commented on YARN-5525: -- Thanks [~botong] for working on this. I took a look at the

[jira] [Commented] (YARN-5525) Make log aggregation service class configurable

2016-09-01 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15457179#comment-15457179 ] Hadoop QA commented on YARN-5525: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5525) Make log aggregation service class configurable

2016-08-23 Thread Botong Huang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15433975#comment-15433975 ] Botong Huang commented on YARN-5525: I ran TestYarnConfigurationFields locally and it passes. Somehow

[jira] [Commented] (YARN-5525) Make log aggregation service class configurable

2016-08-23 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15433860#comment-15433860 ] Hadoop QA commented on YARN-5525: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5525) Make log aggregation service class configurable

2016-08-23 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15433691#comment-15433691 ] Hadoop QA commented on YARN-5525: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||