[jira] [Commented] (YARN-5549) AMLauncher.createAMContainerLaunchContext() should not log the command to be launched indiscriminately

2016-09-02 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15458504#comment-15458504 ] Daniel Templeton commented on YARN-5549: Minor correction, [~Naganarasimha]: it req

[jira] [Commented] (YARN-5549) AMLauncher.createAMContainerLaunchContext() should not log the command to be launched indiscriminately

2016-09-01 Thread Naganarasimha G R (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15457570#comment-15457570 ] Naganarasimha G R commented on YARN-5549: - Thanks for the patch [~templedf] and [~k

[jira] [Commented] (YARN-5549) AMLauncher.createAMContainerLaunchContext() should not log the command to be launched indiscriminately

2016-09-01 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15456686#comment-15456686 ] Hadoop QA commented on YARN-5549: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-5549) AMLauncher.createAMContainerLaunchContext() should not log the command to be launched indiscriminately

2016-09-01 Thread Karthik Kambatla (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15456672#comment-15456672 ] Karthik Kambatla commented on YARN-5549: +1 pending Jenkins. Will commit this tomor

[jira] [Commented] (YARN-5549) AMLauncher.createAMContainerLaunchContext() should not log the command to be launched indiscriminately

2016-09-01 Thread Ray Chiang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15456618#comment-15456618 ] Ray Chiang commented on YARN-5549: -- I like the actionable log message in v6 better too. +

[jira] [Commented] (YARN-5549) AMLauncher.createAMContainerLaunchContext() should not log the command to be launched indiscriminately

2016-09-01 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15456586#comment-15456586 ] Jason Lowe commented on YARN-5549: -- +1 lgtm. > AMLauncher.createAMContainerLaunchContext(

[jira] [Commented] (YARN-5549) AMLauncher.createAMContainerLaunchContext() should not log the command to be launched indiscriminately

2016-09-01 Thread Karthik Kambatla (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15456309#comment-15456309 ] Karthik Kambatla commented on YARN-5549: [~vinodkv], [~jlowe], [~Naganarasimha Garl

[jira] [Commented] (YARN-5549) AMLauncher.createAMContainerLaunchContext() should not log the command to be launched indiscriminately

2016-09-01 Thread Karthik Kambatla (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15456302#comment-15456302 ] Karthik Kambatla commented on YARN-5549: The patch looks good, except for the follo

[jira] [Commented] (YARN-5549) AMLauncher.createAMContainerLaunchContext() should not log the command to be launched indiscriminately

2016-08-31 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15453750#comment-15453750 ] Hadoop QA commented on YARN-5549: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-5549) AMLauncher.createAMContainerLaunchContext() should not log the command to be launched indiscriminately

2016-08-31 Thread Karthik Kambatla (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15453549#comment-15453549 ] Karthik Kambatla commented on YARN-5549: I hate introducing one more config, but lo

[jira] [Commented] (YARN-5549) AMLauncher.createAMContainerLaunchContext() should not log the command to be launched indiscriminately

2016-08-30 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15450299#comment-15450299 ] Daniel Templeton commented on YARN-5549: I just created YARN-5599 and YARN-5600 to

[jira] [Commented] (YARN-5549) AMLauncher.createAMContainerLaunchContext() should not log the command to be launched indiscriminately

2016-08-30 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15449515#comment-15449515 ] Daniel Templeton commented on YARN-5549: I would still argue to keep the config par

[jira] [Commented] (YARN-5549) AMLauncher.createAMContainerLaunchContext() should not log the command to be launched indiscriminately

2016-08-30 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15449059#comment-15449059 ] Jason Lowe commented on YARN-5549: -- Storing launch info in ATSv2 is fine with me and sound

[jira] [Commented] (YARN-5549) AMLauncher.createAMContainerLaunchContext() should not log the command to be launched indiscriminately

2016-08-29 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15447310#comment-15447310 ] Daniel Templeton commented on YARN-5549: Sounds like we're agreed that we should go

[jira] [Commented] (YARN-5549) AMLauncher.createAMContainerLaunchContext() should not log the command to be launched indiscriminately

2016-08-29 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15447251#comment-15447251 ] Jason Lowe commented on YARN-5549: -- Totally agree with Daniel that this is only useful for

[jira] [Commented] (YARN-5549) AMLauncher.createAMContainerLaunchContext() should not log the command to be launched indiscriminately

2016-08-29 Thread Vinod Kumar Vavilapalli (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15447238#comment-15447238 ] Vinod Kumar Vavilapalli commented on YARN-5549: --- bq. Enabling the log message

[jira] [Commented] (YARN-5549) AMLauncher.createAMContainerLaunchContext() should not log the command to be launched indiscriminately

2016-08-29 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15447158#comment-15447158 ] Daniel Templeton commented on YARN-5549: With the log message set to debug and guar

[jira] [Commented] (YARN-5549) AMLauncher.createAMContainerLaunchContext() should not log the command to be launched indiscriminately

2016-08-29 Thread Ray Chiang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15447070#comment-15447070 ] Ray Chiang commented on YARN-5549: -- [~Naganarasimha], so you'd rather stick to version 003

[jira] [Commented] (YARN-5549) AMLauncher.createAMContainerLaunchContext() should not log the command to be launched indiscriminately

2016-08-29 Thread Naganarasimha G R (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15445302#comment-15445302 ] Naganarasimha G R commented on YARN-5549: - bq. If the command information is neede

[jira] [Commented] (YARN-5549) AMLauncher.createAMContainerLaunchContext() should not log the command to be launched indiscriminately

2016-08-26 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15440125#comment-15440125 ] Hadoop QA commented on YARN-5549: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-5549) AMLauncher.createAMContainerLaunchContext() should not log the command to be launched indiscriminately

2016-08-26 Thread Ray Chiang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15440067#comment-15440067 ] Ray Chiang commented on YARN-5549: -- +1 for removing it. Makes the review much cleaner. >

[jira] [Commented] (YARN-5549) AMLauncher.createAMContainerLaunchContext() should not log the command to be launched indiscriminately

2016-08-26 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15440022#comment-15440022 ] Hadoop QA commented on YARN-5549: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-5549) AMLauncher.createAMContainerLaunchContext() should not log the command to be launched indiscriminately

2016-08-26 Thread Vinod Kumar Vavilapalli (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15439951#comment-15439951 ] Vinod Kumar Vavilapalli commented on YARN-5549: --- bq. I don't have any objecti

[jira] [Commented] (YARN-5549) AMLauncher.createAMContainerLaunchContext() should not log the command to be launched indiscriminately

2016-08-26 Thread Ray Chiang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15439696#comment-15439696 ] Ray Chiang commented on YARN-5549: -- I don't have any objections to moving the command mess

[jira] [Commented] (YARN-5549) AMLauncher.createAMContainerLaunchContext() should not log the command to be launched indiscriminately

2016-08-25 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15437802#comment-15437802 ] Hadoop QA commented on YARN-5549: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-5549) AMLauncher.createAMContainerLaunchContext() should not log the command to be launched indiscriminately

2016-08-25 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15437513#comment-15437513 ] Hadoop QA commented on YARN-5549: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||