[
https://issues.apache.org/jira/browse/YARN-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15484308#comment-15484308
]
Jian He commented on YARN-5620:
---
Arun, thank you very much for the prompt response..
I think you forgot to
[
https://issues.apache.org/jira/browse/YARN-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15484303#comment-15484303
]
Hadoop QA commented on YARN-5620:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15483565#comment-15483565
]
Jian He commented on YARN-5620:
---
bq. It is also possible that the an admin logs into the NM and does a 'kill
[
https://issues.apache.org/jira/browse/YARN-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15483521#comment-15483521
]
Hadoop QA commented on YARN-5620:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15483437#comment-15483437
]
Hadoop QA commented on YARN-5620:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15483313#comment-15483313
]
Jian He commented on YARN-5620:
---
One more thing about the test.. In testContainerUpgradeSuccess, could you
[
https://issues.apache.org/jira/browse/YARN-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15483274#comment-15483274
]
Jian He commented on YARN-5620:
---
bq. the container should be killable explicitly via an external signal.
[
https://issues.apache.org/jira/browse/YARN-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15483158#comment-15483158
]
Arun Suresh commented on YARN-5620:
---
Thanks [~jianhe]..
Will update patch shortly with your suggestions.
[
https://issues.apache.org/jira/browse/YARN-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15483135#comment-15483135
]
Jian He commented on YARN-5620:
---
Arun, thanks for updating ! looks good to me overall, few more comments:
-
[
https://issues.apache.org/jira/browse/YARN-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15480762#comment-15480762
]
Hadoop QA commented on YARN-5620:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15477961#comment-15477961
]
Arun Suresh commented on YARN-5620:
---
Missed this:
bq. why do we set the reInitContext to be null if once
[
https://issues.apache.org/jira/browse/YARN-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15477938#comment-15477938
]
Arun Suresh commented on YARN-5620:
---
[~jianhe], thanks for thoughtful comments.
bq. Also, if it’s
[
https://issues.apache.org/jira/browse/YARN-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15477474#comment-15477474
]
Jian He commented on YARN-5620:
---
Thanks Arun, some more comments and questions:
- The reInitContext is
[
https://issues.apache.org/jira/browse/YARN-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15475449#comment-15475449
]
Hadoop QA commented on YARN-5620:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15474474#comment-15474474
]
Hadoop QA commented on YARN-5620:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15473997#comment-15473997
]
Jian He commented on YARN-5620:
---
Thanks Arun, few comments on the upgrade flow:
- The addResource better be
[
https://issues.apache.org/jira/browse/YARN-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15473563#comment-15473563
]
Varun Vasudev commented on YARN-5620:
-
Thanks for the patch [~asuresh]!
1)
{code}
-
[
https://issues.apache.org/jira/browse/YARN-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15473035#comment-15473035
]
Hadoop QA commented on YARN-5620:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15473024#comment-15473024
]
Hadoop QA commented on YARN-5620:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15472971#comment-15472971
]
Hadoop QA commented on YARN-5620:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15472777#comment-15472777
]
Jian He commented on YARN-5620:
---
[~asuresh], thanks for the explanation
bq. Only the AM knows if the upgrade
[
https://issues.apache.org/jira/browse/YARN-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15472223#comment-15472223
]
Wangda Tan commented on YARN-5620:
--
Just have an offline chat with [~asuresh], since this is a
[
https://issues.apache.org/jira/browse/YARN-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15472054#comment-15472054
]
Wangda Tan commented on YARN-5620:
--
[~asuresh],
I still think two APIs should be merged.
In YARN-5221,
[
https://issues.apache.org/jira/browse/YARN-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15472021#comment-15472021
]
Arun Suresh commented on YARN-5620:
---
[~leftnoteasy], I feel the YARN-5221 and this are orthogonal.
[
https://issues.apache.org/jira/browse/YARN-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15471981#comment-15471981
]
Wangda Tan commented on YARN-5620:
--
[~asuresh],
In YARN-5221 we have merged update container resource and
[
https://issues.apache.org/jira/browse/YARN-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15471809#comment-15471809
]
Arun Suresh commented on YARN-5620:
---
Thanks for the review [~jianhe]
bq. The COMMIT_UPGRADE API: I don’t
[
https://issues.apache.org/jira/browse/YARN-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15471166#comment-15471166
]
Jian He commented on YARN-5620:
---
Thanks Arun, some questions on the API:
- The COMMIT_UPGRADE API: I don’t
[
https://issues.apache.org/jira/browse/YARN-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15469829#comment-15469829
]
Hadoop QA commented on YARN-5620:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15469446#comment-15469446
]
Hadoop QA commented on YARN-5620:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15469021#comment-15469021
]
Hadoop QA commented on YARN-5620:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
30 matches
Mail list logo
