[jira] [Commented] (YARN-5710) Fix inconsistent naming in class ResourceRequest

2016-10-27 Thread Yufei Gu (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15612399#comment-15612399 ] Yufei Gu commented on YARN-5710: Thanks [~sunilg] and [~varun_saxena] for the review and co

[jira] [Commented] (YARN-5710) Fix inconsistent naming in class ResourceRequest

2016-10-27 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15611192#comment-15611192 ] Hudson commented on YARN-5710: -- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #1069

[jira] [Commented] (YARN-5710) Fix inconsistent naming in class ResourceRequest

2016-10-27 Thread Varun Saxena (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15611159#comment-15611159 ] Varun Saxena commented on YARN-5710: Committed to trunk, branch-2. Thanks [~yufeigu] fo

[jira] [Commented] (YARN-5710) Fix inconsistent naming in class ResourceRequest

2016-10-27 Thread Sunil G (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15611152#comment-15611152 ] Sunil G commented on YARN-5710: --- Looks fine for me. cc/[~rohithsharma] > Fix inconsistent na

[jira] [Commented] (YARN-5710) Fix inconsistent naming in class ResourceRequest

2016-10-04 Thread Yufei Gu (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15547079#comment-15547079 ] Yufei Gu commented on YARN-5710: No need to add unit test. > Fix inconsistent naming in cl

[jira] [Commented] (YARN-5710) Fix inconsistent naming in class ResourceRequest

2016-10-04 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15547063#comment-15547063 ] Hadoop QA commented on YARN-5710: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-5710) Fix inconsistent naming in class ResourceRequest

2016-10-04 Thread Yufei Gu (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15547003#comment-15547003 ] Yufei Gu commented on YARN-5710: Since "host" is used in many place, we think "host" should

[jira] [Commented] (YARN-5710) Fix inconsistent naming in class ResourceRequest

2016-10-04 Thread Yufei Gu (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15546956#comment-15546956 ] Yufei Gu commented on YARN-5710: It is OK to leave the style issue alone and not add any un

[jira] [Commented] (YARN-5710) Fix inconsistent naming in class ResourceRequest

2016-10-04 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15546907#comment-15546907 ] Hadoop QA commented on YARN-5710: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||