[
https://issues.apache.org/jira/browse/YARN-5792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16146723#comment-16146723
]
Hudson commented on YARN-5792:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #1227
[
https://issues.apache.org/jira/browse/YARN-5792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15686485#comment-15686485
]
Varun Saxena commented on YARN-5792:
Thanks [~sjlee0] for the review and commit.
> ado
[
https://issues.apache.org/jira/browse/YARN-5792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15678167#comment-15678167
]
Sangjin Lee commented on YARN-5792:
---
The latest patch LGTM.
I'll wait until next Monday
[
https://issues.apache.org/jira/browse/YARN-5792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15677355#comment-15677355
]
Varun Saxena commented on YARN-5792:
Checkstyle issues are related to constructor param
[
https://issues.apache.org/jira/browse/YARN-5792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15676442#comment-15676442
]
Hadoop QA commented on YARN-5792:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-5792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15672211#comment-15672211
]
Hadoop QA commented on YARN-5792:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-5792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15672049#comment-15672049
]
Sangjin Lee commented on YARN-5792:
---
Thanks [~varun_saxena] for updating the patch! I thi
[
https://issues.apache.org/jira/browse/YARN-5792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671745#comment-15671745
]
Varun Saxena commented on YARN-5792:
Thanks [~sjlee0] for the review.
Fixed all the com
[
https://issues.apache.org/jira/browse/YARN-5792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15665142#comment-15665142
]
Sangjin Lee commented on YARN-5792:
---
I went over the latest patch, and had some comments.
[
https://issues.apache.org/jira/browse/YARN-5792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15661803#comment-15661803
]
Varun Saxena commented on YARN-5792:
bq. If we can guarantee the created time is made a
[
https://issues.apache.org/jira/browse/YARN-5792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15658522#comment-15658522
]
Sangjin Lee commented on YARN-5792:
---
[~varun_saxena], thanks for the update!
Your points
[
https://issues.apache.org/jira/browse/YARN-5792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15658081#comment-15658081
]
Hadoop QA commented on YARN-5792:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-5792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15656854#comment-15656854
]
Hadoop QA commented on YARN-5792:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-5792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15656583#comment-15656583
]
Varun Saxena commented on YARN-5792:
bq. At a high level, I'd like to discuss options.
[
https://issues.apache.org/jira/browse/YARN-5792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1561#comment-1561
]
Sangjin Lee commented on YARN-5792:
---
At a high level, I'd like to discuss options.
I see
[
https://issues.apache.org/jira/browse/YARN-5792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15655540#comment-15655540
]
Sangjin Lee commented on YARN-5792:
---
Patch v.2 fails compilation:
{noformat}
[INFO] -
[
https://issues.apache.org/jira/browse/YARN-5792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15655096#comment-15655096
]
Varun Saxena commented on YARN-5792:
Tests pass in local. Lets see what comes up when b
[
https://issues.apache.org/jira/browse/YARN-5792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15655013#comment-15655013
]
Hadoop QA commented on YARN-5792:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-5792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15654321#comment-15654321
]
Varun Saxena commented on YARN-5792:
The patch does the following.
# Uses inverse of c
19 matches
Mail list logo
