[jira] [Commented] (YARN-582) Restore appToken for app attempt after RM restart

[ https://issues.apache.org/jira/browse/YARN-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13651634#comment-13651634 ] Jian He commented on YARN-582: -- tested, works on branch-2 > Restore appToken f

[jira] [Commented] (YARN-582) Restore appToken for app attempt after RM restart

[ https://issues.apache.org/jira/browse/YARN-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13651633#comment-13651633 ] Vinod Kumar Vavilapalli commented on YARN-582: -- Looks good to me too. Can you

[jira] [Commented] (YARN-582) Restore appToken for app attempt after RM restart

[ https://issues.apache.org/jira/browse/YARN-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13651530#comment-13651530 ] Bikas Saha commented on YARN-582: - Looks good. +1. > Restore appToken for a

[jira] [Commented] (YARN-582) Restore appToken for app attempt after RM restart

[ https://issues.apache.org/jira/browse/YARN-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13651422#comment-13651422 ] Hadoop QA commented on YARN-582: {color:green}+1 overall{color}. Here are the results of te

[jira] [Commented] (YARN-582) Restore appToken for app attempt after RM restart

[ https://issues.apache.org/jira/browse/YARN-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13651268#comment-13651268 ] Jian He commented on YARN-582: -- bq. Why not simply create it once in the RMAppAttemptImpl and r

[jira] [Commented] (YARN-582) Restore appToken for app attempt after RM restart

[ https://issues.apache.org/jira/browse/YARN-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13650390#comment-13650390 ] Hadoop QA commented on YARN-582: {color:green}+1 overall{color}. Here are the results of te

[jira] [Commented] (YARN-582) Restore appToken for app attempt after RM restart

[ https://issues.apache.org/jira/browse/YARN-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13650337#comment-13650337 ] Bikas Saha commented on YARN-582: - Move into a common function? {code} Credentials cre

[jira] [Commented] (YARN-582) Restore appToken for app attempt after RM restart

[ https://issues.apache.org/jira/browse/YARN-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13649910#comment-13649910 ] Vinod Kumar Vavilapalli commented on YARN-582: -- bq. Alternatively, it could Cre

[jira] [Commented] (YARN-582) Restore appToken for app attempt after RM restart

[ https://issues.apache.org/jira/browse/YARN-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13649449#comment-13649449 ] Bikas Saha commented on YARN-582: - bq. RMAppAttemptImpl.appAttemptTokens should simply be T

[jira] [Commented] (YARN-582) Restore appToken for app attempt after RM restart

[ https://issues.apache.org/jira/browse/YARN-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13648040#comment-13648040 ] Bikas Saha commented on YARN-582: - Also, we could be better off storing credentials in rmapp

[jira] [Commented] (YARN-582) Restore appToken for app attempt after RM restart

[ https://issues.apache.org/jira/browse/YARN-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13648037#comment-13648037 ] Bikas Saha commented on YARN-582: - Is the null check necessary? the underlying protobuf hand

[jira] [Commented] (YARN-582) Restore appToken for app attempt after RM restart

[ https://issues.apache.org/jira/browse/YARN-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13646835#comment-13646835 ] Hadoop QA commented on YARN-582: {color:green}+1 overall{color}. Here are the results of te

[jira] [Commented] (YARN-582) Restore appToken for app attempt after RM restart

[ https://issues.apache.org/jira/browse/YARN-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13646806#comment-13646806 ] Jian He commented on YARN-582: -- new patch addressed last comments > Restore ap

[jira] [Commented] (YARN-582) Restore appToken for app attempt after RM restart

[ https://issues.apache.org/jira/browse/YARN-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13646282#comment-13646282 ] Bikas Saha commented on YARN-582: - Why is this inside the try instead of where the existing

[jira] [Commented] (YARN-582) Restore appToken for app attempt after RM restart

[ https://issues.apache.org/jira/browse/YARN-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13646095#comment-13646095 ] Hadoop QA commented on YARN-582: {color:green}+1 overall{color}. Here are the results of te