[jira] [Commented] (YARN-6081) LeafQueue#getTotalPendingResourcesConsideringUserLimit should deduct reserved from pending to avoid unnecessary preemption of reserved container

2017-01-13 Thread Wangda Tan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15822091#comment-15822091 ] Wangda Tan commented on YARN-6081: -- Thanks for review and commit! [~sunilg], [~eepayne]. >

[jira] [Commented] (YARN-6081) LeafQueue#getTotalPendingResourcesConsideringUserLimit should deduct reserved from pending to avoid unnecessary preemption of reserved container

2017-01-11 Thread Sunil G (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15820030#comment-15820030 ] Sunil G commented on YARN-6081: --- Thanks [~leftnoteasy] for the updated patch, and thanks [~eepayne] for the

[jira] [Commented] (YARN-6081) LeafQueue#getTotalPendingResourcesConsideringUserLimit should deduct reserved from pending to avoid unnecessary preemption of reserved container

2017-01-11 Thread Eric Payne (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15819452#comment-15819452 ] Eric Payne commented on YARN-6081: -- +1 LGTM. The failed test ({{TestRMRestart}}) is not related to this

[jira] [Commented] (YARN-6081) LeafQueue#getTotalPendingResourcesConsideringUserLimit should deduct reserved from pending to avoid unnecessary preemption of reserved container

2017-01-11 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15819374#comment-15819374 ] Hadoop QA commented on YARN-6081: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-6081) LeafQueue#getTotalPendingResourcesConsideringUserLimit should deduct reserved from pending to avoid unnecessary preemption of reserved container

2017-01-11 Thread Eric Payne (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15819338#comment-15819338 ] Eric Payne commented on YARN-6081: -- Thanks [~leftnoteasy] for fixing this. I am reviewing today. I will

[jira] [Commented] (YARN-6081) LeafQueue#getTotalPendingResourcesConsideringUserLimit should deduct reserved from pending to avoid unnecessary preemption of reserved container

2017-01-11 Thread Sunil G (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15818018#comment-15818018 ] Sunil G commented on YARN-6081: --- Thanks [~leftnoteasy]. Good catch! We decrement pending resources only if

[jira] [Commented] (YARN-6081) LeafQueue#getTotalPendingResourcesConsideringUserLimit should deduct reserved from pending to avoid unnecessary preemption of reserved container

2017-01-10 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15817153#comment-15817153 ] Hadoop QA commented on YARN-6081: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-6081) LeafQueue#getTotalPendingResourcesConsideringUserLimit should deduct reserved from pending to avoid unnecessary preemption of reserved container

2017-01-10 Thread Wangda Tan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15816996#comment-15816996 ] Wangda Tan commented on YARN-6081: -- [~sunilg], [~eepayne]. Could you please review this fix? It will be

[jira] [Commented] (YARN-6081) LeafQueue#getTotalPendingResourcesConsideringUserLimit should deduct reserved from pending to avoid unnecessary preemption of reserved container

2017-01-10 Thread Wangda Tan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15816990#comment-15816990 ] Wangda Tan commented on YARN-6081: -- This is the test case to reproduce the problem: {code} @Test