[jira] [Commented] (YARN-6125) The application attempt's diagnostic message should have a maximum size

2018-03-19 Thread Leo Chen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16405721#comment-16405721 ] Leo Chen commented on YARN-6125: Hi, Andras Piros, Do u know how to reproduce this secenari

[jira] [Commented] (YARN-6125) The application attempt's diagnostic message should have a maximum size

2017-05-23 Thread stefanlee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16022397#comment-16022397 ] stefanlee commented on YARN-6125: - [~templedf] thanks > The application attempt's diagnost

[jira] [Commented] (YARN-6125) The application attempt's diagnostic message should have a maximum size

2017-05-23 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021458#comment-16021458 ] Daniel Templeton commented on YARN-6125: Because {{BoundedAppender}} has no depende

[jira] [Commented] (YARN-6125) The application attempt's diagnostic message should have a maximum size

2017-05-23 Thread stefanlee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16020819#comment-16020819 ] stefanlee commented on YARN-6125: - thanks for this jira, i have a doubt that why class *Bou

[jira] [Commented] (YARN-6125) The application attempt's diagnostic message should have a maximum size

2017-02-17 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872670#comment-15872670 ] Daniel Templeton commented on YARN-6125: Committed to trunk and branch-2. > The ap

[jira] [Commented] (YARN-6125) The application attempt's diagnostic message should have a maximum size

2017-02-17 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872634#comment-15872634 ] Hudson commented on YARN-6125: -- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #1127

[jira] [Commented] (YARN-6125) The application attempt's diagnostic message should have a maximum size

2017-02-16 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15870913#comment-15870913 ] Daniel Templeton commented on YARN-6125: Thanks, [~andras.piros]! LGTM +1. I'll

[jira] [Commented] (YARN-6125) The application attempt's diagnostic message should have a maximum size

2017-02-16 Thread Andras Piros (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15870504#comment-15870504 ] Andras Piros commented on YARN-6125: The tests {{TestRMRestart}}, {{TestDelegationToken

[jira] [Commented] (YARN-6125) The application attempt's diagnostic message should have a maximum size

2017-02-15 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15869348#comment-15869348 ] Hadoop QA commented on YARN-6125: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-6125) The application attempt's diagnostic message should have a maximum size

2017-02-15 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15868744#comment-15868744 ] Daniel Templeton commented on YARN-6125: Thanks, [~andras.piros]. A few more comme

[jira] [Commented] (YARN-6125) The application attempt's diagnostic message should have a maximum size

2017-02-13 Thread Andras Piros (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15864139#comment-15864139 ] Andras Piros commented on YARN-6125: The unit test {{TestRMRestart#testFinishedAppRemov

[jira] [Commented] (YARN-6125) The application attempt's diagnostic message should have a maximum size

2017-02-10 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15862243#comment-15862243 ] Hadoop QA commented on YARN-6125: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-6125) The application attempt's diagnostic message should have a maximum size

2017-02-10 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15862179#comment-15862179 ] Hadoop QA commented on YARN-6125: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-6125) The application attempt's diagnostic message should have a maximum size

2017-02-10 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15862085#comment-15862085 ] Daniel Templeton commented on YARN-6125: bq. My original consideration was that we

[jira] [Commented] (YARN-6125) The application attempt's diagnostic message should have a maximum size

2017-02-10 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15862081#comment-15862081 ] Daniel Templeton commented on YARN-6125: I agree on #3. I thought I had deleted th

[jira] [Commented] (YARN-6125) The application attempt's diagnostic message should have a maximum size

2017-02-10 Thread Andras Piros (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15862078#comment-15862078 ] Andras Piros commented on YARN-6125: [~templedf] latest code review comment responses:

[jira] [Commented] (YARN-6125) The application attempt's diagnostic message should have a maximum size

2017-02-10 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15861864#comment-15861864 ] Daniel Templeton commented on YARN-6125: Looking good, [~andras.piros]. A few more

[jira] [Commented] (YARN-6125) The application attempt's diagnostic message should have a maximum size

2017-02-08 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15858983#comment-15858983 ] Hadoop QA commented on YARN-6125: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote |

[jira] [Commented] (YARN-6125) The application attempt's diagnostic message should have a maximum size

2017-02-07 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15857576#comment-15857576 ] Hadoop QA commented on YARN-6125: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-6125) The application attempt's diagnostic message should have a maximum size

2017-02-07 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15857205#comment-15857205 ] Hadoop QA commented on YARN-6125: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-6125) The application attempt's diagnostic message should have a maximum size

2017-02-07 Thread Andras Piros (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15857127#comment-15857127 ] Andras Piros commented on YARN-6125: [~templedf] it's actually always a good idea to th

[jira] [Commented] (YARN-6125) The application attempt's diagnostic message should have a maximum size

2017-02-07 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15857113#comment-15857113 ] Daniel Templeton commented on YARN-6125: Thanks for the update, [~andras.piros]. N

[jira] [Commented] (YARN-6125) The application attempt's diagnostic message should have a maximum size

2017-02-06 Thread Andras Piros (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15854452#comment-15854452 ] Andras Piros commented on YARN-6125: Good. [~templedf] neither the header nor the ellip

[jira] [Commented] (YARN-6125) The application attempt's diagnostic message should have a maximum size

2017-02-06 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15854394#comment-15854394 ] Daniel Templeton commented on YARN-6125: Works for me. Are you planning to count t

[jira] [Commented] (YARN-6125) The application attempt's diagnostic message should have a maximum size

2017-02-06 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15854295#comment-15854295 ] Jason Lowe commented on YARN-6125: -- Seems fine to me. > The application attempt's diagnos

[jira] [Commented] (YARN-6125) The application attempt's diagnostic message should have a maximum size

2017-02-03 Thread Andras Piros (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15851920#comment-15851920 ] Andras Piros commented on YARN-6125: Thanks [~jlowe] and [~templedf] for your ideas! S

[jira] [Commented] (YARN-6125) The application attempt's diagnostic message should have a maximum size

2017-02-03 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15851834#comment-15851834 ] Daniel Templeton commented on YARN-6125: I would argue that a partial stack trace,

[jira] [Commented] (YARN-6125) The application attempt's diagnostic message should have a maximum size

2017-02-03 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15851732#comment-15851732 ] Jason Lowe commented on YARN-6125: -- I would argue the most important part of many stacktra

[jira] [Commented] (YARN-6125) The application attempt's diagnostic message should have a maximum size

2017-02-03 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15851698#comment-15851698 ] Daniel Templeton commented on YARN-6125: That is certainly an option. The point th

[jira] [Commented] (YARN-6125) The application attempt's diagnostic message should have a maximum size

2017-02-03 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15851674#comment-15851674 ] Jason Lowe commented on YARN-6125: -- I suppose we could do ellipses, but I'm still a bit co

[jira] [Commented] (YARN-6125) The application attempt's diagnostic message should have a maximum size

2017-02-03 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15851600#comment-15851600 ] Daniel Templeton commented on YARN-6125: My original thought there was something mo

[jira] [Commented] (YARN-6125) The application attempt's diagnostic message should have a maximum size

2017-02-03 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15851556#comment-15851556 ] Jason Lowe commented on YARN-6125: -- I think it's not necessary to distinguish between mess

[jira] [Commented] (YARN-6125) The application attempt's diagnostic message should have a maximum size

2017-02-02 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15850903#comment-15850903 ] Hadoop QA commented on YARN-6125: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-6125) The application attempt's diagnostic message should have a maximum size

2017-02-02 Thread Andras Piros (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15850732#comment-15850732 ] Andras Piros commented on YARN-6125: * {{ExpectedException.none()}} as factory method,

[jira] [Commented] (YARN-6125) The application attempt's diagnostic message should have a maximum size

2017-02-02 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15850577#comment-15850577 ] Daniel Templeton commented on YARN-6125: bq. the pom.xml dependency reordering was

[jira] [Commented] (YARN-6125) The application attempt's diagnostic message should have a maximum size

2017-02-01 Thread Andras Piros (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15848968#comment-15848968 ] Andras Piros commented on YARN-6125: [~templedf] thanks for the review! My thoughts on

[jira] [Commented] (YARN-6125) The application attempt's diagnostic message should have a maximum size

2017-01-31 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15847836#comment-15847836 ] Daniel Templeton commented on YARN-6125: Thanks for the patch. Some comments: * I

[jira] [Commented] (YARN-6125) The application attempt's diagnostic message should have a maximum size

2017-01-31 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15847763#comment-15847763 ] Hadoop QA commented on YARN-6125: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-6125) The application attempt's diagnostic message should have a maximum size

2017-01-26 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15840490#comment-15840490 ] Daniel Templeton commented on YARN-6125: Agreed. I don't think we need to be too d

[jira] [Commented] (YARN-6125) The application attempt's diagnostic message should have a maximum size

2017-01-26 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15840473#comment-15840473 ] Jason Lowe commented on YARN-6125: -- So I assume the tail end of the diagnostics would have

[jira] [Commented] (YARN-6125) The application attempt's diagnostic message should have a maximum size

2017-01-26 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15840451#comment-15840451 ] Daniel Templeton commented on YARN-6125: In the case that I've gotten my hands on t

[jira] [Commented] (YARN-6125) The application attempt's diagnostic message should have a maximum size

2017-01-26 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15840265#comment-15840265 ] Jason Lowe commented on YARN-6125: -- For the huge examples that have been encountered so fa