[jira] [Commented] (YARN-6175) Negative vcore for resource needed to preempt

[ https://issues.apache.org/jira/browse/YARN-6175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15876793#comment-15876793 ] Hadoop QA commented on YARN-6175: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-6175) Negative vcore for resource needed to preempt

[ https://issues.apache.org/jira/browse/YARN-6175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15876427#comment-15876427 ] Yufei Gu commented on YARN-6175: [~kasha], good catch. Resources.max isn't necessary. Uploaded the patch v3

[jira] [Commented] (YARN-6175) Negative vcore for resource needed to preempt

[ https://issues.apache.org/jira/browse/YARN-6175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15875647#comment-15875647 ] Karthik Kambatla commented on YARN-6175: In FairScheduler.java, do we still need the Resources.max

[jira] [Commented] (YARN-6175) Negative vcore for resource needed to preempt

[ https://issues.apache.org/jira/browse/YARN-6175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15870996#comment-15870996 ] Hadoop QA commented on YARN-6175: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-6175) Negative vcore for resource needed to preempt

[ https://issues.apache.org/jira/browse/YARN-6175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15870730#comment-15870730 ] Yufei Gu commented on YARN-6175: Uploaded patch v2 which is in line with YARN-6163. > Negative vcore for

[jira] [Commented] (YARN-6175) Negative vcore for resource needed to preempt

[ https://issues.apache.org/jira/browse/YARN-6175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15870487#comment-15870487 ] Yufei Gu commented on YARN-6175: [~kasha], would you like take a look since YARN-6163 is done. > Negative

[jira] [Commented] (YARN-6175) Negative vcore for resource needed to preempt

[ https://issues.apache.org/jira/browse/YARN-6175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15867330#comment-15867330 ] Karthik Kambatla commented on YARN-6175: Just skimmed through the patch. When using

[jira] [Commented] (YARN-6175) Negative vcore for resource needed to preempt

[ https://issues.apache.org/jira/browse/YARN-6175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15867275#comment-15867275 ] Yufei Gu commented on YARN-6175: Thanks [~wilfreds] for the review. [~kasha], wanna take a look? >

[jira] [Commented] (YARN-6175) Negative vcore for resource needed to preempt

[ https://issues.apache.org/jira/browse/YARN-6175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15867208#comment-15867208 ] Wilfred Spiegelenburg commented on YARN-6175: - The change overall looks good. The junit test

[jira] [Commented] (YARN-6175) Negative vcore for resource needed to preempt

[ https://issues.apache.org/jira/browse/YARN-6175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15867033#comment-15867033 ] Hadoop QA commented on YARN-6175: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-6175) Negative vcore for resource needed to preempt

[ https://issues.apache.org/jira/browse/YARN-6175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15866582#comment-15866582 ] Yufei Gu commented on YARN-6175: The issue in new preemption code is fixed in YARN-6163. This Jira is only

[jira] [Commented] (YARN-6175) Negative vcore for resource needed to preempt

[ https://issues.apache.org/jira/browse/YARN-6175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15866573#comment-15866573 ] ASF GitHub Bot commented on YARN-6175: -- GitHub user flyrain opened a pull request: