[jira] [Commented] (YARN-7119) yarn rmadmin -updateNodeResource should be updated for resource types

[ https://issues.apache.org/jira/browse/YARN-7119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289582#comment-16289582 ] Manikandan R commented on YARN-7119: Not related. Am seeing this failure even without this patch in

[jira] [Commented] (YARN-7119) yarn rmadmin -updateNodeResource should be updated for resource types

[ https://issues.apache.org/jira/browse/YARN-7119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289420#comment-16289420 ] Sunil G commented on YARN-7119: --- [~maniraj...@gmail.com] Is test case failures related? > yarn rmadmin

[jira] [Commented] (YARN-7119) yarn rmadmin -updateNodeResource should be updated for resource types

[ https://issues.apache.org/jira/browse/YARN-7119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289150#comment-16289150 ] genericqa commented on YARN-7119: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7119) yarn rmadmin -updateNodeResource should be updated for resource types

[ https://issues.apache.org/jira/browse/YARN-7119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289011#comment-16289011 ] Manikandan R commented on YARN-7119: Rebasing patch. > yarn rmadmin -updateNodeResource should be

[jira] [Commented] (YARN-7119) yarn rmadmin -updateNodeResource should be updated for resource types

[ https://issues.apache.org/jira/browse/YARN-7119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287381#comment-16287381 ] Sunil G commented on YARN-7119: --- [~maniraj...@gmail.com] Could you please help to rebase this patch. There is

[jira] [Commented] (YARN-7119) yarn rmadmin -updateNodeResource should be updated for resource types

[ https://issues.apache.org/jira/browse/YARN-7119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16282137#comment-16282137 ] Sunil G commented on YARN-7119: --- Thanks [~dan...@cloudera.com]. Sure, will commit it later today. > yarn

[jira] [Commented] (YARN-7119) yarn rmadmin -updateNodeResource should be updated for resource types

[ https://issues.apache.org/jira/browse/YARN-7119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16282133#comment-16282133 ] Daniel Templeton commented on YARN-7119: +1 [~sunilg], wanna do the commit? I'm on vacation

[jira] [Commented] (YARN-7119) yarn rmadmin -updateNodeResource should be updated for resource types

[ https://issues.apache.org/jira/browse/YARN-7119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281546#comment-16281546 ] genericqa commented on YARN-7119: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7119) yarn rmadmin -updateNodeResource should be updated for resource types

[ https://issues.apache.org/jira/browse/YARN-7119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281426#comment-16281426 ] Manikandan R commented on YARN-7119: Taken care. There was one more new test case with similar

[jira] [Commented] (YARN-7119) yarn rmadmin -updateNodeResource should be updated for resource types

[ https://issues.apache.org/jira/browse/YARN-7119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280559#comment-16280559 ] Daniel Templeton commented on YARN-7119: LGTM. Last thing, it would be nice to clean up the

[jira] [Commented] (YARN-7119) yarn rmadmin -updateNodeResource should be updated for resource types

[ https://issues.apache.org/jira/browse/YARN-7119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280170#comment-16280170 ] Manikandan R commented on YARN-7119: Junit failure is not related to this patch. > yarn rmadmin

[jira] [Commented] (YARN-7119) yarn rmadmin -updateNodeResource should be updated for resource types

[ https://issues.apache.org/jira/browse/YARN-7119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16279787#comment-16279787 ] genericqa commented on YARN-7119: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7119) yarn rmadmin -updateNodeResource should be updated for resource types

[ https://issues.apache.org/jira/browse/YARN-7119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16279684#comment-16279684 ] Manikandan R commented on YARN-7119: Thanks. Attached new patch. > yarn rmadmin -updateNodeResource

[jira] [Commented] (YARN-7119) yarn rmadmin -updateNodeResource should be updated for resource types

[ https://issues.apache.org/jira/browse/YARN-7119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16279185#comment-16279185 ] Daniel Templeton commented on YARN-7119: Looks good to me, except one tiny issue, which might not

[jira] [Commented] (YARN-7119) yarn rmadmin -updateNodeResource should be updated for resource types

[ https://issues.apache.org/jira/browse/YARN-7119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16278930#comment-16278930 ] Manikandan R commented on YARN-7119: Hope you had a good time :) Can you please confirm latest patch

[jira] [Commented] (YARN-7119) yarn rmadmin -updateNodeResource should be updated for resource types

[ https://issues.apache.org/jira/browse/YARN-7119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266261#comment-16266261 ] Daniel Templeton commented on YARN-7119: I'm on vacation, but I'll try to get to it tomorrow. :) >

[jira] [Commented] (YARN-7119) yarn rmadmin -updateNodeResource should be updated for resource types

[ https://issues.apache.org/jira/browse/YARN-7119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266097#comment-16266097 ] Manikandan R commented on YARN-7119: [~templedf] Can you please confirm changes based on your recent

[jira] [Commented] (YARN-7119) yarn rmadmin -updateNodeResource should be updated for resource types

[ https://issues.apache.org/jira/browse/YARN-7119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16259089#comment-16259089 ] Hadoop QA commented on YARN-7119: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7119) yarn rmadmin -updateNodeResource should be updated for resource types

[ https://issues.apache.org/jira/browse/YARN-7119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16258978#comment-16258978 ] Manikandan R commented on YARN-7119: [~templedf] Thanks for very thorough reviews. Addressed all

[jira] [Commented] (YARN-7119) yarn rmadmin -updateNodeResource should be updated for resource types

[ https://issues.apache.org/jira/browse/YARN-7119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16257629#comment-16257629 ] Daniel Templeton commented on YARN-7119: # ResourceUtils:L24, javadoc summary must end with a

[jira] [Commented] (YARN-7119) yarn rmadmin -updateNodeResource should be updated for resource types

[ https://issues.apache.org/jira/browse/YARN-7119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16257286#comment-16257286 ] Daniel Templeton commented on YARN-7119: bq. Currently if there is any non-alpha characters in

[jira] [Commented] (YARN-7119) yarn rmadmin -updateNodeResource should be updated for resource types

[ https://issues.apache.org/jira/browse/YARN-7119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256596#comment-16256596 ] Hadoop QA commented on YARN-7119: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7119) yarn rmadmin -updateNodeResource should be updated for resource types

[ https://issues.apache.org/jira/browse/YARN-7119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256488#comment-16256488 ] Manikandan R commented on YARN-7119: [~templedf] Thanks for detailed reviews. 1: Currently if there is

[jira] [Commented] (YARN-7119) yarn rmadmin -updateNodeResource should be updated for resource types

[ https://issues.apache.org/jira/browse/YARN-7119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16253850#comment-16253850 ] Daniel Templeton commented on YARN-7119: My feedback: # On ResourceUtils:L438, you're quietly

[jira] [Commented] (YARN-7119) yarn rmadmin -updateNodeResource should be updated for resource types

[ https://issues.apache.org/jira/browse/YARN-7119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16253728#comment-16253728 ] Manikandan R commented on YARN-7119: [~dan...@cloudera.com] Can you take a look? > yarn rmadmin

[jira] [Commented] (YARN-7119) yarn rmadmin -updateNodeResource should be updated for resource types

[ https://issues.apache.org/jira/browse/YARN-7119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250150#comment-16250150 ] Hadoop QA commented on YARN-7119: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7119) yarn rmadmin -updateNodeResource should be updated for resource types

[ https://issues.apache.org/jira/browse/YARN-7119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249629#comment-16249629 ] Sunil G commented on YARN-7119: --- [~templedf] could you please help to take a look at final patch > yarn

[jira] [Commented] (YARN-7119) yarn rmadmin -updateNodeResource should be updated for resource types

[ https://issues.apache.org/jira/browse/YARN-7119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249566#comment-16249566 ] Manikandan R commented on YARN-7119: Fixed checkstyle issues. > yarn rmadmin -updateNodeResource

[jira] [Commented] (YARN-7119) yarn rmadmin -updateNodeResource should be updated for resource types

[ https://issues.apache.org/jira/browse/YARN-7119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248968#comment-16248968 ] Hadoop QA commented on YARN-7119: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7119) yarn rmadmin -updateNodeResource should be updated for resource types

[ https://issues.apache.org/jira/browse/YARN-7119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248927#comment-16248927 ] Manikandan R commented on YARN-7119: [~templedf] Thanks for your comments. Addressed all points and

[jira] [Commented] (YARN-7119) yarn rmadmin -updateNodeResource should be updated for resource types

[ https://issues.apache.org/jira/browse/YARN-7119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16246731#comment-16246731 ] Daniel Templeton commented on YARN-7119: I have just a few comments: # The new public methods in

[jira] [Commented] (YARN-7119) yarn rmadmin -updateNodeResource should be updated for resource types

[ https://issues.apache.org/jira/browse/YARN-7119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16246084#comment-16246084 ] Sunil G commented on YARN-7119: --- Looks good in general. I will wait for couple of days for other folks also

[jira] [Commented] (YARN-7119) yarn rmadmin -updateNodeResource should be updated for resource types

[ https://issues.apache.org/jira/browse/YARN-7119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243436#comment-16243436 ] Hadoop QA commented on YARN-7119: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7119) yarn rmadmin -updateNodeResource should be updated for resource types

[ https://issues.apache.org/jira/browse/YARN-7119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243371#comment-16243371 ] Manikandan R commented on YARN-7119: Fixed checkstyle errors, findbugs warnings. > yarn rmadmin

[jira] [Commented] (YARN-7119) yarn rmadmin -updateNodeResource should be updated for resource types

[ https://issues.apache.org/jira/browse/YARN-7119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242430#comment-16242430 ] Hadoop QA commented on YARN-7119: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7119) yarn rmadmin -updateNodeResource should be updated for resource types

[ https://issues.apache.org/jira/browse/YARN-7119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242227#comment-16242227 ] Manikandan R commented on YARN-7119: Re-attaching same patch. > yarn rmadmin -updateNodeResource

[jira] [Commented] (YARN-7119) yarn rmadmin -updateNodeResource should be updated for resource types

[ https://issues.apache.org/jira/browse/YARN-7119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16241972#comment-16241972 ] Hadoop QA commented on YARN-7119: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7119) yarn rmadmin -updateNodeResource should be updated for resource types

[ https://issues.apache.org/jira/browse/YARN-7119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16241955#comment-16241955 ] Manikandan R commented on YARN-7119: [~sunilg] Thanks for your comments. 1-6,9: Taken care. 7:

[jira] [Commented] (YARN-7119) yarn rmadmin -updateNodeResource should be updated for resource types

[ https://issues.apache.org/jira/browse/YARN-7119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226845#comment-16226845 ] Sunil G commented on YARN-7119: --- Thanks [~maniraj...@gmail.com]. Few comments # In {{parseResourceValue}},

[jira] [Commented] (YARN-7119) yarn rmadmin -updateNodeResource should be updated for resource types

[ https://issues.apache.org/jira/browse/YARN-7119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226392#comment-16226392 ] Hadoop QA commented on YARN-7119: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7119) yarn rmadmin -updateNodeResource should be updated for resource types

[ https://issues.apache.org/jira/browse/YARN-7119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226383#comment-16226383 ] Manikandan R commented on YARN-7119: Thanks [~sunilg] for your comments. Addressed all comments and

[jira] [Commented] (YARN-7119) yarn rmadmin -updateNodeResource should be updated for resource types

[ https://issues.apache.org/jira/browse/YARN-7119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223839#comment-16223839 ] Sunil G commented on YARN-7119: --- Thanks [~maniraj...@gmail.com] Few comments #

[jira] [Commented] (YARN-7119) yarn rmadmin -updateNodeResource should be updated for resource types

[ https://issues.apache.org/jira/browse/YARN-7119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223493#comment-16223493 ] Hadoop QA commented on YARN-7119: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7119) yarn rmadmin -updateNodeResource should be updated for resource types

[ https://issues.apache.org/jira/browse/YARN-7119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223450#comment-16223450 ] Manikandan R commented on YARN-7119: [~sunilg] [~leftnoteasy] Thanks for working on YARN-7307. Had an

[jira] [Commented] (YARN-7119) yarn rmadmin -updateNodeResource should be updated for resource types

[ https://issues.apache.org/jira/browse/YARN-7119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16187460#comment-16187460 ] Manikandan R commented on YARN-7119: This patch has couple of dependencies on 1 class

[jira] [Commented] (YARN-7119) yarn rmadmin -updateNodeResource should be updated for resource types

[ https://issues.apache.org/jira/browse/YARN-7119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16186064#comment-16186064 ] Hadoop QA commented on YARN-7119: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7119) yarn rmadmin -updateNodeResource should be updated for resource types

[ https://issues.apache.org/jira/browse/YARN-7119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16185789#comment-16185789 ] Manikandan R commented on YARN-7119: [~sunilg] Thanks for your suggestions. Attaching patch for the

[jira] [Commented] (YARN-7119) yarn rmadmin -updateNodeResource should be updated for resource types

[ https://issues.apache.org/jira/browse/YARN-7119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184081#comment-16184081 ] Sunil G commented on YARN-7119: --- To keep the backward compatibility, we might need to support existing

[jira] [Commented] (YARN-7119) yarn rmadmin -updateNodeResource should be updated for resource types

[ https://issues.apache.org/jira/browse/YARN-7119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16181171#comment-16181171 ] Manikandan R commented on YARN-7119: As of now, updateNodeResource accepts below params: NodeID