[
https://issues.apache.org/jira/browse/YARN-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16262892#comment-16262892
]
Miklos Szegedi commented on YARN-7337:
--
+1. Thank you for the contribution [~haibochen
[
https://issues.apache.org/jira/browse/YARN-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261668#comment-16261668
]
Haibo Chen commented on YARN-7337:
--
NO unit test failures even though there is a -1 from u
[
https://issues.apache.org/jira/browse/YARN-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261648#comment-16261648
]
Hadoop QA commented on YARN-7337:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261072#comment-16261072
]
Haibo Chen commented on YARN-7337:
--
The findbug issue is unrelated. There were no unit tes
[
https://issues.apache.org/jira/browse/YARN-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16260199#comment-16260199
]
Hadoop QA commented on YARN-7337:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16259899#comment-16259899
]
Miklos Szegedi commented on YARN-7337:
--
Thenk you for the patch [~haibochen]
{code}
15
[
https://issues.apache.org/jira/browse/YARN-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16257532#comment-16257532
]
Haibo Chen commented on YARN-7337:
--
The license warning and findbug issue are unrelated, s
[
https://issues.apache.org/jira/browse/YARN-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16257513#comment-16257513
]
Hadoop QA commented on YARN-7337:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16256526#comment-16256526
]
Hadoop QA commented on YARN-7337:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248017#comment-16248017
]
Hadoop QA commented on YARN-7337:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247380#comment-16247380
]
Hadoop QA commented on YARN-7337:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247039#comment-16247039
]
Haibo Chen commented on YARN-7337:
--
The unit tests are unrelated. Will update the patch to
[
https://issues.apache.org/jira/browse/YARN-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247017#comment-16247017
]
Hadoop QA commented on YARN-7337:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16246880#comment-16246880
]
Haibo Chen commented on YARN-7337:
--
Updated the patch to
-depreciate exisiting getUsed ap
[
https://issues.apache.org/jira/browse/YARN-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16246789#comment-16246789
]
Haibo Chen commented on YARN-7337:
--
That sounds good to me. Will address it in the next pa
[
https://issues.apache.org/jira/browse/YARN-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16246786#comment-16246786
]
Miklos Szegedi commented on YARN-7337:
--
Why do not we create a getTotalNumContainers,
[
https://issues.apache.org/jira/browse/YARN-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16246571#comment-16246571
]
Haibo Chen commented on YARN-7337:
--
Thanks for the review, [~miklos.szeg...@cloudera.com].
[
https://issues.apache.org/jira/browse/YARN-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16246308#comment-16246308
]
Miklos Szegedi commented on YARN-7337:
--
Thank you for the patch [~haibochen].
{code}
1
[
https://issues.apache.org/jira/browse/YARN-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16238805#comment-16238805
]
Hadoop QA commented on YARN-7337:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16238623#comment-16238623
]
Haibo Chen commented on YARN-7337:
--
Patch updated to address the unit test failures and ch
[
https://issues.apache.org/jira/browse/YARN-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16236991#comment-16236991
]
Hadoop QA commented on YARN-7337:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
21 matches
Mail list logo
