[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16587389#comment-16587389
]
Sunil Govindan commented on YARN-7494:
--
[~cheersyang] Fixed checkstyles which are possible. Some
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16587386#comment-16587386
]
genericqa commented on YARN-7494:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16587157#comment-16587157
]
genericqa commented on YARN-7494:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586978#comment-16586978
]
Sunil Govindan commented on YARN-7494:
--
Fixed checkstyle whichever is possible. [~cheersyang] pls
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16585857#comment-16585857
]
Weiwei Yang commented on YARN-7494:
---
Hi [~sunilg], looks good, +1 once the checkstyle issues are fixed.
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16585789#comment-16585789
]
genericqa commented on YARN-7494:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16585620#comment-16585620
]
Sunil Govindan commented on YARN-7494:
--
Fixed test case. Attaching new patch,
> Add muti node lookup
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16579468#comment-16579468
]
Weiwei Yang commented on YARN-7494:
---
Hi [~sunilg]
{\{TestAppSchedulingInfo}} failure was related to the
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16579461#comment-16579461
]
genericqa commented on YARN-7494:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16579330#comment-16579330
]
Weiwei Yang commented on YARN-7494:
---
Hi [~sunilg]
I just pull the patch to local and it seems good to
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16579323#comment-16579323
]
Sunil Govindan commented on YARN-7494:
--
Updated v17 patch. [~cheersyang] pls help to review.
> Add
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16578543#comment-16578543
]
genericqa commented on YARN-7494:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16578103#comment-16578103
]
genericqa commented on YARN-7494:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577817#comment-16577817
]
Sunil Govindan commented on YARN-7494:
--
Thanks [~cheersyang] for quick review. Yes, I modified
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1652#comment-1652
]
Weiwei Yang commented on YARN-7494:
---
Thanks [~sunilg] for the updates, please see my followup comments
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577698#comment-16577698
]
genericqa commented on YARN-7494:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577651#comment-16577651
]
Sunil Govindan commented on YARN-7494:
--
Updating v15 patch after correcting default class name. cc
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576769#comment-16576769
]
genericqa commented on YARN-7494:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576604#comment-16576604
]
Sunil Govindan commented on YARN-7494:
--
As discussed, removed updating multiNodePolicyName in Queue
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576105#comment-16576105
]
genericqa commented on YARN-7494:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575974#comment-16575974
]
Sunil Govindan commented on YARN-7494:
--
Thanks [~cheersyang].
bq.my opinion is if this causes burden
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575020#comment-16575020
]
Weiwei Yang commented on YARN-7494:
---
Hi [~sunilg]
I think to get this not a CS only feature was from
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16574790#comment-16574790
]
genericqa commented on YARN-7494:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16574680#comment-16574680
]
Sunil Govindan commented on YARN-7494:
--
Thanks [~cheersyang] and [~leftnoteasy]
Almost fixed all
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564589#comment-16564589
]
Wangda Tan commented on YARN-7494:
--
[~sunilg],
Thanks for updating the patch, some comments.
1) Not
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16561665#comment-16561665
]
Weiwei Yang commented on YARN-7494:
---
Hello [~sunilg]
Thanks for the updates, it looks almost good to
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16561370#comment-16561370
]
Sunil Govindan commented on YARN-7494:
--
[~leftnoteasy] [~cheersyang] pls help to review.
> Add muti
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16559573#comment-16559573
]
genericqa commented on YARN-7494:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16559429#comment-16559429
]
Sunil Govindan commented on YARN-7494:
--
Fixed test case,
> Add muti node lookup support for better
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16545144#comment-16545144
]
genericqa commented on YARN-7494:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16545031#comment-16545031
]
Sunil Govindan commented on YARN-7494:
--
Thanks [~cheersyang]. Addressed the comments. Pls find some
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544759#comment-16544759
]
Weiwei Yang commented on YARN-7494:
---
Hi [~sunilg]
ApplicationSchedulingConfig
* Is
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544116#comment-16544116
]
Sunil Govindan commented on YARN-7494:
--
[~leftnoteasy] and [~cheersyang] Could u pls help to take a
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541547#comment-16541547
]
genericqa commented on YARN-7494:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541419#comment-16541419
]
Sunil Govindan commented on YARN-7494:
--
Thanks [~cheersyang]. Attaching latest patch with testcase.
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16490602#comment-16490602
]
Weiwei Yang commented on YARN-7494:
---
Hi [~sunilg]
Please see my comments about your latest patch,
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16481855#comment-16481855
]
genericqa commented on YARN-7494:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480403#comment-16480403
]
Sunil Govindan commented on YARN-7494:
--
Thanks [~cheersyang] and [~leftnoteasy]
Attaching latest
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16474418#comment-16474418
]
Sunil G commented on YARN-7494:
---
Sorry for the delay here [~cheersyang]
I am working on a patch to close ur
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16441469#comment-16441469
]
genericqa commented on YARN-7494:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16441269#comment-16441269
]
Sunil G commented on YARN-7494:
---
Thanks [~cheersyang] for the comments. I ll be updating ur comment in next
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16433729#comment-16433729
]
Weiwei Yang commented on YARN-7494:
---
Sure, thanks for the review [~leftnoteasy].
Here is my review
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432970#comment-16432970
]
Wangda Tan commented on YARN-7494:
--
Thanks [~sunilg],
In general change looks good. Could u check UT
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426010#comment-16426010
]
Weiwei Yang commented on YARN-7494:
---
Hi [~sunilg], have you got the chance to review the UT failures? I
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16422259#comment-16422259
]
Weiwei Yang commented on YARN-7494:
---
Hi [~sunilg]
There are a lot of UT failing, could you please check?
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16421771#comment-16421771
]
genericqa commented on YARN-7494:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16419342#comment-16419342
]
Sunil G commented on YARN-7494:
---
[~cheersyang] Thanks for the update. I also discussed with [~leftnoteasy]
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16419109#comment-16419109
]
Weiwei Yang commented on YARN-7494:
---
Hi [~sunilg]
{quote}then each one has to expanded like other 2
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16418907#comment-16418907
]
Sunil G commented on YARN-7494:
---
Thanks [~cheersyang]
For known policies like resource-usage, this looks
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16418411#comment-16418411
]
Weiwei Yang commented on YARN-7494:
---
Hi [~sunilg]
I was proposing to have configuration like following:
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417590#comment-16417590
]
Sunil G commented on YARN-7494:
---
Thanks [~cheersyang] and [~leftnoteasy]
bq.Maintaining a separate cache
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16416485#comment-16416485
]
Wangda Tan commented on YARN-7494:
--
[~sunilg],
I found there's one comment doesn't updated which
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16415536#comment-16415536
]
Weiwei Yang commented on YARN-7494:
---
Hi [~sunilg]
I haven't read the new patch yet, probably tomorrow I
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16415435#comment-16415435
]
Sunil G commented on YARN-7494:
---
Thanks [~cheersyang]
# Removed NodeSortingAlgorithm to make it simpler. Now
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413473#comment-16413473
]
Weiwei Yang commented on YARN-7494:
---
Hi [~sunilg]
Another comment in \{{FiCaSchedulerApp}}
{code}
//
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16407831#comment-16407831
]
Weiwei Yang commented on YARN-7494:
---
Hi [~sunilg]
Thanks for the updates,
{quote}each scheduler can
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405157#comment-16405157
]
Sunil G commented on YARN-7494:
---
Updating patch by correct api names where each scheduler can register
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397388#comment-16397388
]
Sunil G commented on YARN-7494:
---
This was a bit due. Sorry for the delay.
Updated as per comments. However
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16392740#comment-16392740
]
Weiwei Yang commented on YARN-7494:
---
Hi [~sunilg]/[~leftnoteasy]
Sorry I just get the time to review
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16382864#comment-16382864
]
Wangda Tan commented on YARN-7494:
--
Thanks [~sunilg] for updating the patch, reviewed overall workflow of
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16382377#comment-16382377
]
Sunil G commented on YARN-7494:
---
Updated v2 patch as per design proposal updated as
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346992#comment-16346992
]
Sunil G commented on YARN-7494:
---
Thanks [~leftnoteasy] [~cheersyang] [~Tao Yang] for comments.
Overall i ll
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346727#comment-16346727
]
Weiwei Yang commented on YARN-7494:
---
Hi [~sunilg]
Some updates today, I took a deeper look at the patch.
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346404#comment-16346404
]
Tao Yang commented on YARN-7494:
Thanks [~cheersyang] for your mention.
Some thoughts (parts are the same
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345090#comment-16345090
]
Weiwei Yang commented on YARN-7494:
---
Hi [~leftnoteasy], [~sunilg]
I have some high level comments
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344656#comment-16344656
]
Wangda Tan commented on YARN-7494:
--
[~sunilg] , sorry for the delays in review. I just took a look at the
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329108#comment-16329108
]
Sunil G commented on YARN-7494:
---
[~leftnoteasy]. I attached a new patch. However I have added a new policy to
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305095#comment-16305095
]
Sunil G commented on YARN-7494:
---
YARN-7666 introduces a scheduler env map through ASC. So I moved those
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16283419#comment-16283419
]
Tao Yang commented on YARN-7494:
Thanks for the patch. [~sunilg]
Some thoughts from my side:
* Agree with
[
https://issues.apache.org/jira/browse/YARN-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280902#comment-16280902
]
Wangda Tan commented on YARN-7494:
--
Thanks [~sunilg] for working on this.
Looked at the implementation,
70 matches
Mail list logo
