[jira] [Commented] (YARN-7590) Improve container-executor validation check

2018-07-18 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547568#comment-16547568 ] Aljoscha Krettek commented on YARN-7590: Thanks a lot [~ebadger]! This was indeed the problem. I

[jira] [Commented] (YARN-7590) Improve container-executor validation check

2018-07-17 Thread Eric Badger (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16546828#comment-16546828 ] Eric Badger commented on YARN-7590: --- Is your NM running as root? {noformat} if (caller_uid !=

[jira] [Commented] (YARN-7590) Improve container-executor validation check

2018-07-17 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16546289#comment-16546289 ] Aljoscha Krettek commented on YARN-7590: Hi, I just came across this issue. I have a kerberized

[jira] [Commented] (YARN-7590) Improve container-executor validation check

2018-01-18 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331454#comment-16331454 ] Eric Yang commented on YARN-7590: - Thank you [~miklos.szeg...@cloudera.com] > Improve container-executor

[jira] [Commented] (YARN-7590) Improve container-executor validation check

2018-01-18 Thread Miklos Szegedi (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331284#comment-16331284 ] Miklos Szegedi commented on YARN-7590: -- Thank you, [~eyang] for the patches, I verified and committed

[jira] [Commented] (YARN-7590) Improve container-executor validation check

2018-01-13 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325345#comment-16325345 ] Eric Yang commented on YARN-7590: - [~miklos.szeg...@cloudera.com] Sure, I'll add 2.x patches on Tuesday. >

[jira] [Commented] (YARN-7590) Improve container-executor validation check

2018-01-11 Thread Miklos Szegedi (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16322776#comment-16322776 ] Miklos Szegedi commented on YARN-7590: -- Thank you for the contribution [~eyang]! I am still working on

[jira] [Commented] (YARN-7590) Improve container-executor validation check

2018-01-11 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16322755#comment-16322755 ] Eric Yang commented on YARN-7590: - [~miklos.szeg...@cloudera.com] Thank you for the review and commit. :)

[jira] [Commented] (YARN-7590) Improve container-executor validation check

2018-01-11 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16322726#comment-16322726 ] Hudson commented on YARN-7590: -- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13482 (See

[jira] [Commented] (YARN-7590) Improve container-executor validation check

2018-01-11 Thread Miklos Szegedi (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16322705#comment-16322705 ] Miklos Szegedi commented on YARN-7590: -- +1. I will commit this shortly. > Improve container-executor

[jira] [Commented] (YARN-7590) Improve container-executor validation check

2018-01-11 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16322681#comment-16322681 ] genericqa commented on YARN-7590: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7590) Improve container-executor validation check

2018-01-11 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16322538#comment-16322538 ] Eric Yang commented on YARN-7590: - [~miklos.szeg...@cloudera.com] Sure, I can wait for YARN-7705 and do the

[jira] [Commented] (YARN-7590) Improve container-executor validation check

2018-01-10 Thread Miklos Szegedi (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16321664#comment-16321664 ] Miklos Szegedi commented on YARN-7590: -- [~eyang], The code I suggested above {code} fprintf(LOGFILE,

[jira] [Commented] (YARN-7590) Improve container-executor validation check

2018-01-10 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16321590#comment-16321590 ] genericqa commented on YARN-7590: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7590) Improve container-executor validation check

2018-01-10 Thread Miklos Szegedi (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16321274#comment-16321274 ] Miklos Szegedi commented on YARN-7590: -- [~eyang], I figured it out. {code} char *local_path =

[jira] [Commented] (YARN-7590) Improve container-executor validation check

2018-01-09 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319001#comment-16319001 ] Eric Yang commented on YARN-7590: - Hi [~miklos.szeg...@cloudera.com], could you shed some lights on the

[jira] [Commented] (YARN-7590) Improve container-executor validation check

2018-01-05 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314329#comment-16314329 ] genericqa commented on YARN-7590: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7590) Improve container-executor validation check

2018-01-05 Thread Miklos Szegedi (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313730#comment-16313730 ] Miklos Szegedi commented on YARN-7590: -- [~eyang], thank you for the updated patch. {code} Testing

[jira] [Commented] (YARN-7590) Improve container-executor validation check

2018-01-05 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313623#comment-16313623 ] genericqa commented on YARN-7590: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7590) Improve container-executor validation check

2018-01-05 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313502#comment-16313502 ] Eric Yang commented on YARN-7590: - [~miklos.szeg...@cloudera.com] Sorry about missing the last point

[jira] [Commented] (YARN-7590) Improve container-executor validation check

2018-01-03 Thread Miklos Szegedi (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310534#comment-16310534 ] Miklos Szegedi commented on YARN-7590: -- Thank you for the patch [~eyang]. I have two more style

[jira] [Commented] (YARN-7590) Improve container-executor validation check

2018-01-03 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309902#comment-16309902 ] Eric Yang commented on YARN-7590: - Happy New Year [~miklos.szeg...@cloudera.com], Can you review the 006

[jira] [Commented] (YARN-7590) Improve container-executor validation check

2018-01-02 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308445#comment-16308445 ] genericqa commented on YARN-7590: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7590) Improve container-executor validation check

2017-12-22 Thread Miklos Szegedi (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302137#comment-16302137 ] Miklos Szegedi commented on YARN-7590: -- Thank you for the patch [~eyang]. I have a few style issues:

[jira] [Commented] (YARN-7590) Improve container-executor validation check

2017-12-22 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302020#comment-16302020 ] genericqa commented on YARN-7590: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7590) Improve container-executor validation check

2017-12-22 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16301970#comment-16301970 ] Eric Yang commented on YARN-7590: - [~miklos.szeg...@cloudera.com] Thank you for the feedback, and I revised

[jira] [Commented] (YARN-7590) Improve container-executor validation check

2017-12-21 Thread Miklos Szegedi (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16300387#comment-16300387 ] Miklos Szegedi commented on YARN-7590: -- Thank you for the patch, [~eyang]. I have a few minor comments

[jira] [Commented] (YARN-7590) Improve container-executor validation check

2017-12-20 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299455#comment-16299455 ] genericqa commented on YARN-7590: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7590) Improve container-executor validation check

2017-12-20 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299272#comment-16299272 ] genericqa commented on YARN-7590: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7590) Improve container-executor validation check

2017-12-20 Thread Miklos Szegedi (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16298990#comment-16298990 ] Miklos Szegedi commented on YARN-7590: -- Thank you for the patch, [~eyang]. I see two more issues.

[jira] [Commented] (YARN-7590) Improve container-executor validation check

2017-12-14 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16291770#comment-16291770 ] Eric Yang commented on YARN-7590: - The unit test failure for TestContainerLaunch is caused by YARN-7381,

[jira] [Commented] (YARN-7590) Improve container-executor validation check

2017-12-13 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290182#comment-16290182 ] genericqa commented on YARN-7590: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7590) Improve container-executor validation check

2017-12-13 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290142#comment-16290142 ] Eric Yang commented on YARN-7590: - [~miklos.szeg...@cloudera.com] Thank you for the review. I revised the

[jira] [Commented] (YARN-7590) Improve container-executor validation check

2017-12-12 Thread Miklos Szegedi (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288599#comment-16288599 ] Miklos Szegedi commented on YARN-7590: -- [~eyang], the first line of {{main()}} calls

[jira] [Commented] (YARN-7590) Improve container-executor validation check

2017-12-08 Thread Miklos Szegedi (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16284372#comment-16284372 ] Miklos Szegedi commented on YARN-7590: -- [~eyang], sorry about the delay. Due to the sensitivity of the

[jira] [Commented] (YARN-7590) Improve container-executor validation check

2017-12-08 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16283906#comment-16283906 ] Eric Yang commented on YARN-7590: - [~miklos.szeg...@cloudera.com] Hi Miklos, would you mind to review this

[jira] [Commented] (YARN-7590) Improve container-executor validation check

2017-12-04 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277725#comment-16277725 ] genericqa commented on YARN-7590: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7590) Improve container-executor validation check

2017-12-04 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277252#comment-16277252 ] Eric Yang commented on YARN-7590: - [~miklos.szeg...@cloudera.com] getuid() may produce uid belong to

[jira] [Commented] (YARN-7590) Improve container-executor validation check

2017-12-01 Thread Miklos Szegedi (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275315#comment-16275315 ] Miklos Szegedi commented on YARN-7590: -- [~eyang], why do not we just call getuid() to get the uid? >

[jira] [Commented] (YARN-7590) Improve container-executor validation check

2017-12-01 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275300#comment-16275300 ] Eric Yang commented on YARN-7590: - [~miklos.szeg...@cloudera.com] One problem with option 3 is that

[jira] [Commented] (YARN-7590) Improve container-executor validation check

2017-12-01 Thread Andrew Wang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275232#comment-16275232 ] Andrew Wang commented on YARN-7590: --- Thanks Eric! > Improve container-executor validation check >

[jira] [Commented] (YARN-7590) Improve container-executor validation check

2017-12-01 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275221#comment-16275221 ] Eric Yang commented on YARN-7590: - [~ebadger] {quote} I've brought this up in the past (can't remember

[jira] [Commented] (YARN-7590) Improve container-executor validation check

2017-12-01 Thread Andrew Wang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275205#comment-16275205 ] Andrew Wang commented on YARN-7590: --- Hi folks, is this a release blocker? Could someone set the affects

[jira] [Commented] (YARN-7590) Improve container-executor validation check

2017-12-01 Thread Mike Yoder (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275168#comment-16275168 ] Mike Yoder commented on YARN-7590: -- {quote} Container executor should link to a C based XML parser to get

[jira] [Commented] (YARN-7590) Improve container-executor validation check

2017-12-01 Thread Miklos Szegedi (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275142#comment-16275142 ] Miklos Szegedi commented on YARN-7590: -- I have two more options: 3. Instead of getting a prefix path

[jira] [Commented] (YARN-7590) Improve container-executor validation check

2017-12-01 Thread Eric Badger (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275068#comment-16275068 ] Eric Badger commented on YARN-7590: --- bq. Make sure the prefix path is same as the one in yarn-site.xml,

[jira] [Commented] (YARN-7590) Improve container-executor validation check

2017-12-01 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274708#comment-16274708 ] Eric Yang commented on YARN-7590: - There is currently two proposals to address this issue: h3. Proposals