[
https://issues.apache.org/jira/browse/YARN-7626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16390123#comment-16390123
]
Hudson commented on YARN-7626:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13789 (See
[
https://issues.apache.org/jira/browse/YARN-7626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16390095#comment-16390095
]
Miklos Szegedi commented on YARN-7626:
--
Thank you for the contribution [~Zian Chen] and for the commit
[
https://issues.apache.org/jira/browse/YARN-7626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388685#comment-16388685
]
Wangda Tan commented on YARN-7626:
--
Thanks [~miklos.szeg...@cloudera.com]/[~Zian Chen], will commit the
[
https://issues.apache.org/jira/browse/YARN-7626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387169#comment-16387169
]
Zian Chen commented on YARN-7626:
-
[~leftnoteasy] , I think after changing the style issue according to
[
https://issues.apache.org/jira/browse/YARN-7626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387123#comment-16387123
]
genericqa commented on YARN-7626:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16386920#comment-16386920
]
Zian Chen commented on YARN-7626:
-
Sure [~miklos.szeg...@cloudera.com] totally agree with that style
[
https://issues.apache.org/jira/browse/YARN-7626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16386738#comment-16386738
]
Miklos Szegedi commented on YARN-7626:
--
Thank you for the patch [~Zian Chen] and for the review
[
https://issues.apache.org/jira/browse/YARN-7626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16385580#comment-16385580
]
Wangda Tan commented on YARN-7626:
--
Thanks [~Zian Chen]. +1, LGTM, [~miklos.szeg...@cloudera.com], do you
[
https://issues.apache.org/jira/browse/YARN-7626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383294#comment-16383294
]
Zian Chen commented on YARN-7626:
-
[~leftnoteasy] , could you help me check the latest patch? Thanks!
>
[
https://issues.apache.org/jira/browse/YARN-7626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16382908#comment-16382908
]
genericqa commented on YARN-7626:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16382887#comment-16382887
]
Zian Chen commented on YARN-7626:
-
Address failed test cases and rebuild the patch
> Allow regular
[
https://issues.apache.org/jira/browse/YARN-7626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381417#comment-16381417
]
genericqa commented on YARN-7626:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16377171#comment-16377171
]
Zian Chen commented on YARN-7626:
-
I'm changing the patch according to the comments and find some memory
[
https://issues.apache.org/jira/browse/YARN-7626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370401#comment-16370401
]
Miklos Szegedi commented on YARN-7626:
--
Indeed there is not there any substantial difference other
[
https://issues.apache.org/jira/browse/YARN-7626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16368440#comment-16368440
]
Zian Chen commented on YARN-7626:
-
Hi [~leftnoteasy] , could you also share your thoughts on this? Thanks!
[
https://issues.apache.org/jira/browse/YARN-7626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16368027#comment-16368027
]
Zian Chen commented on YARN-7626:
-
Hi [~miklos.szeg...@cloudera.com] , really appreciate your comments for
[
https://issues.apache.org/jira/browse/YARN-7626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363078#comment-16363078
]
Miklos Szegedi commented on YARN-7626:
--
Thank you for the patch [~Zian Chen].
{code:java}
return !(len
[
https://issues.apache.org/jira/browse/YARN-7626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362084#comment-16362084
]
Wangda Tan commented on YARN-7626:
--
[~miklos.szeg...@cloudera.com], could you help to check the latest
[
https://issues.apache.org/jira/browse/YARN-7626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362008#comment-16362008
]
genericqa commented on YARN-7626:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16361743#comment-16361743
]
Zian Chen commented on YARN-7626:
-
[~miklos.szeg...@cloudera.com] , Thanks Miklos for the comments.
[
https://issues.apache.org/jira/browse/YARN-7626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16361741#comment-16361741
]
genericqa commented on YARN-7626:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16357340#comment-16357340
]
Miklos Szegedi commented on YARN-7626:
--
Thank you, [~Zian Chen] for the reply and update. Your latest
[
https://issues.apache.org/jira/browse/YARN-7626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356484#comment-16356484
]
Zian Chen commented on YARN-7626:
-
For the latest patch, I tested the regex expression matching on a GPU
[
https://issues.apache.org/jira/browse/YARN-7626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351149#comment-16351149
]
genericqa commented on YARN-7626:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350873#comment-16350873
]
Zian Chen commented on YARN-7626:
-
Update patch 006 per Miklos's suggestions. [~leftnoteasy] ,[~sunilg] ,
[
https://issues.apache.org/jira/browse/YARN-7626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345671#comment-16345671
]
Zian Chen commented on YARN-7626:
-
Hi [~miklos.szeg...@cloudera.com] , thank you so much for your
[
https://issues.apache.org/jira/browse/YARN-7626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341810#comment-16341810
]
Miklos Szegedi commented on YARN-7626:
--
[~Zian Chen], thank you for the patch.
{code:java}
76
[
https://issues.apache.org/jira/browse/YARN-7626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340496#comment-16340496
]
Wangda Tan commented on YARN-7626:
--
Thanks [~Zian Chen] for working on this issue and testing. I just
28 matches
Mail list logo