[
https://issues.apache.org/jira/browse/YARN-7786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446156#comment-16446156
]
Hudson commented on YARN-7786:
--
FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #14039 (See
[
https://issues.apache.org/jira/browse/YARN-7786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446111#comment-16446111
]
Jason Lowe commented on YARN-7786:
--
Thanks for updating the patch!
+1 lgtm. Committing this.
>
[
https://issues.apache.org/jira/browse/YARN-7786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16444117#comment-16444117
]
genericqa commented on YARN-7786:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443971#comment-16443971
]
lujie commented on YARN-7786:
-
the original wait time in _testAMLaunchAndCleanup_ is 20 * 1000, new patch
[
https://issues.apache.org/jira/browse/YARN-7786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443513#comment-16443513
]
genericqa commented on YARN-7786:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443424#comment-16443424
]
lujie commented on YARN-7786:
-
The polling loop is copy-past code, I not only change it to
[
https://issues.apache.org/jira/browse/YARN-7786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16442815#comment-16442815
]
Jason Lowe commented on YARN-7786:
--
Thanks for updating the patch! Looks good overall, just one nit.
[
https://issues.apache.org/jira/browse/YARN-7786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16442095#comment-16442095
]
genericqa commented on YARN-7786:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16441947#comment-16441947
]
lujie commented on YARN-7786:
-
[~jlowe]:
I have update the patch:
* fix some handy check-style error in other
[
https://issues.apache.org/jira/browse/YARN-7786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16441114#comment-16441114
]
Jason Lowe commented on YARN-7786:
--
Thanks for the report and patch! My apologies for the delay in
[
https://issues.apache.org/jira/browse/YARN-7786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16440678#comment-16440678
]
genericqa commented on YARN-7786:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16440545#comment-16440545
]
lujie commented on YARN-7786:
-
Ping>
We have developed a static analysis tool
[
https://issues.apache.org/jira/browse/YARN-7786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339190#comment-16339190
]
genericqa commented on YARN-7786:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339094#comment-16339094
]
genericqa commented on YARN-7786:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338955#comment-16338955
]
lujie commented on YARN-7786:
-
Carefully write a patch that has a unit test. In my locally running, there
[
https://issues.apache.org/jira/browse/YARN-7786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335976#comment-16335976
]
genericqa commented on YARN-7786:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335640#comment-16335640
]
lujie commented on YARN-7786:
-
I have restudy this bug, sorry about that previous analysis was wrong. I use
[
https://issues.apache.org/jira/browse/YARN-7786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334637#comment-16334637
]
genericqa commented on YARN-7786:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334402#comment-16334402
]
lujie commented on YARN-7786:
-
I attach the resource manager log(1 of the 21), All of these logs show that
[
https://issues.apache.org/jira/browse/YARN-7786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334370#comment-16334370
]
lujie commented on YARN-7786:
-
There maybe two reasons for Nullpointer:
# datarace: setAMContainerSpec and
20 matches
Mail list logo
