[jira] [Commented] (YARN-7841) Cleanup AllocationFileLoaderService's reloadAllocations method

[ https://issues.apache.org/jira/browse/YARN-7841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16924603#comment-16924603 ] Ahmed Hussein commented on YARN-7841: - The patch seems to cause random NPE in ReservationACLsTestBase

[jira] [Commented] (YARN-7841) Cleanup AllocationFileLoaderService's reloadAllocations method

[ https://issues.apache.org/jira/browse/YARN-7841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16361181#comment-16361181 ] Vinod Kumar Vavilapalli commented on YARN-7841: --- [~rkanter], please set the *Fix Version/s*

[jira] [Commented] (YARN-7841) Cleanup AllocationFileLoaderService's reloadAllocations method

[ https://issues.apache.org/jira/browse/YARN-7841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355133#comment-16355133 ] Szilard Nemeth commented on YARN-7841: -- Thank you [~rkanter] for the quick review! > Cleanup

[jira] [Commented] (YARN-7841) Cleanup AllocationFileLoaderService's reloadAllocations method

[ https://issues.apache.org/jira/browse/YARN-7841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354683#comment-16354683 ] Hudson commented on YARN-7841: -- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13622 (See

[jira] [Commented] (YARN-7841) Cleanup AllocationFileLoaderService's reloadAllocations method

[ https://issues.apache.org/jira/browse/YARN-7841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354649#comment-16354649 ] Robert Kanter commented on YARN-7841: - +1 LGTM > Cleanup AllocationFileLoaderService's

[jira] [Commented] (YARN-7841) Cleanup AllocationFileLoaderService's reloadAllocations method

[ https://issues.apache.org/jira/browse/YARN-7841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353934#comment-16353934 ] genericqa commented on YARN-7841: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7841) Cleanup AllocationFileLoaderService's reloadAllocations method

[ https://issues.apache.org/jira/browse/YARN-7841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353775#comment-16353775 ] genericqa commented on YARN-7841: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7841) Cleanup AllocationFileLoaderService's reloadAllocations method

[ https://issues.apache.org/jira/browse/YARN-7841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353665#comment-16353665 ] Szilard Nemeth commented on YARN-7841: -- Hi [~rkanter]!   Thanks for your review comments. Good to

[jira] [Commented] (YARN-7841) Cleanup AllocationFileLoaderService's reloadAllocations method

[ https://issues.apache.org/jira/browse/YARN-7841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352896#comment-16352896 ] Robert Kanter commented on YARN-7841: - Thanks for the patch [~snemeth] and the review [~grepas]. 

[jira] [Commented] (YARN-7841) Cleanup AllocationFileLoaderService's reloadAllocations method

[ https://issues.apache.org/jira/browse/YARN-7841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350171#comment-16350171 ] Szilard Nemeth commented on YARN-7841: -- [~grepas] Thanks for the review! > Cleanup

[jira] [Commented] (YARN-7841) Cleanup AllocationFileLoaderService's reloadAllocations method

[ https://issues.apache.org/jira/browse/YARN-7841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350170#comment-16350170 ] Gergo Repas commented on YARN-7841: --- +1 (non-binding) Since this is a big piece of refactoring, I think

[jira] [Commented] (YARN-7841) Cleanup AllocationFileLoaderService's reloadAllocations method

[ https://issues.apache.org/jira/browse/YARN-7841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343887#comment-16343887 ] genericqa commented on YARN-7841: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7841) Cleanup AllocationFileLoaderService's reloadAllocations method

[ https://issues.apache.org/jira/browse/YARN-7841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343702#comment-16343702 ] Szilard Nemeth commented on YARN-7841: -- fixed reasonable checkstyle issues. The unit test failure is

[jira] [Commented] (YARN-7841) Cleanup AllocationFileLoaderService's reloadAllocations method

[ https://issues.apache.org/jira/browse/YARN-7841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343599#comment-16343599 ] genericqa commented on YARN-7841: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||