[
https://issues.apache.org/jira/browse/YARN-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611986#comment-16611986
]
Hudson commented on YARN-7863:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14931 (See
[
https://issues.apache.org/jira/browse/YARN-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16593113#comment-16593113
]
Weiwei Yang commented on YARN-7863:
---
Sounds good to me, +1. Lets get this one in. Thanks [~sunilg],
[
https://issues.apache.org/jira/browse/YARN-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16593114#comment-16593114
]
Naganarasimha G R commented on YARN-7863:
-
Yes [~sunilg], as both the issues are related and we
[
https://issues.apache.org/jira/browse/YARN-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16593112#comment-16593112
]
Sunil Govindan commented on YARN-7863:
--
Thanks [~cheersyang] and [~Naganarasimha]
This comment is
[
https://issues.apache.org/jira/browse/YARN-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16593109#comment-16593109
]
Naganarasimha G R commented on YARN-7863:
-
Hi [~sunilg],
As discussed some comments
[
https://issues.apache.org/jira/browse/YARN-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16593103#comment-16593103
]
Sunil Govindan commented on YARN-7863:
--
Thanks [~cheersyang]
Since the constraint expression asks
[
https://issues.apache.org/jira/browse/YARN-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16593099#comment-16593099
]
Weiwei Yang commented on YARN-7863:
---
Hi [~sunilg]
Latest patch seems good to me, except one doubt. If I
[
https://issues.apache.org/jira/browse/YARN-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16593012#comment-16593012
]
genericqa commented on YARN-7863:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16592955#comment-16592955
]
Sunil Govindan commented on YARN-7863:
--
Thanks [~Naganarasimha]. Updating latest patch addressing
[
https://issues.apache.org/jira/browse/YARN-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16592847#comment-16592847
]
Naganarasimha G R commented on YARN-7863:
-
Hi [~sunilg],
Latest patch does not seem to consider
[
https://issues.apache.org/jira/browse/YARN-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16592827#comment-16592827
]
genericqa commented on YARN-7863:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16592785#comment-16592785
]
Sunil Govindan commented on YARN-7863:
--
Since we use an enum, proto class with default to first value
[
https://issues.apache.org/jira/browse/YARN-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16592784#comment-16592784
]
Sunil Govindan commented on YARN-7863:
--
Thanks [~cheersyang]. Fixed these issues and uploaded a new
[
https://issues.apache.org/jira/browse/YARN-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16592740#comment-16592740
]
Weiwei Yang commented on YARN-7863:
---
Thanks [~sunilg], the patch looks good. To make code changes
[
https://issues.apache.org/jira/browse/YARN-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16592687#comment-16592687
]
genericqa commented on YARN-7863:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16592627#comment-16592627
]
Sunil Govindan commented on YARN-7863:
--
Thanks [~cheersyang] and [~Naganarasimha]
Improved syntax in
[
https://issues.apache.org/jira/browse/YARN-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590410#comment-16590410
]
Naganarasimha G R commented on YARN-7863:
-
Thanks [~cheersyang] for the detailed clarification,
[
https://issues.apache.org/jira/browse/YARN-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589605#comment-16589605
]
Weiwei Yang commented on YARN-7863:
---
Hi [~Naganarasimha]
Unlike partitions, PC is not associated with
[
https://issues.apache.org/jira/browse/YARN-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589559#comment-16589559
]
Naganarasimha G R commented on YARN-7863:
-
Hi [~sunilg],
few other nits in the patch :
*
[
https://issues.apache.org/jira/browse/YARN-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589171#comment-16589171
]
Naganarasimha G R commented on YARN-7863:
-
Thanks [~cheersyang], for some clarifications but at
[
https://issues.apache.org/jira/browse/YARN-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589116#comment-16589116
]
Weiwei Yang commented on YARN-7863:
---
Hi [~Naganarasimha]
Regarding some of your comments
{quote}IIUC we
[
https://issues.apache.org/jira/browse/YARN-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589075#comment-16589075
]
Naganarasimha G R commented on YARN-7863:
-
Hi [~sunilg],
Now i am confused when we have
[
https://issues.apache.org/jira/browse/YARN-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16588996#comment-16588996
]
Weiwei Yang commented on YARN-7863:
---
Hi [~sunilg]
Thanks for the updates. I think v8 patch has
[
https://issues.apache.org/jira/browse/YARN-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16588066#comment-16588066
]
genericqa commented on YARN-7863:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16587849#comment-16587849
]
Sunil Govindan commented on YARN-7863:
--
Updated v8 patch.
cc [~cheersyang] [~Naganarasimha]
>
[
https://issues.apache.org/jira/browse/YARN-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16587634#comment-16587634
]
genericqa commented on YARN-7863:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16587371#comment-16587371
]
Sunil Govindan commented on YARN-7863:
--
Thanks [~cheersyang] [~Naganarasimha]
*TestCases* could be
[
https://issues.apache.org/jira/browse/YARN-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16585329#comment-16585329
]
Naganarasimha G R commented on YARN-7863:
-
Thanks [~sunilg], for the latest patch,
Some of the
[
https://issues.apache.org/jira/browse/YARN-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16584798#comment-16584798
]
Weiwei Yang commented on YARN-7863:
---
Hi [~sunilg]
Thanks for the update, but I am afraid this needs
[
https://issues.apache.org/jira/browse/YARN-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16584441#comment-16584441
]
genericqa commented on YARN-7863:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16584281#comment-16584281
]
Sunil Govindan commented on YARN-7863:
--
Updating a refined patch. Thanks [~cheersyang] for quick
[
https://issues.apache.org/jira/browse/YARN-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16583613#comment-16583613
]
genericqa commented on YARN-7863:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16583362#comment-16583362
]
Sunil Govindan commented on YARN-7863:
--
For now, i removed AttributeSpec class. Using same
[
https://issues.apache.org/jira/browse/YARN-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16583360#comment-16583360
]
Sunil Govindan commented on YARN-7863:
--
Attaching an end-to-end working patch. (only anti-affinity
[
https://issues.apache.org/jira/browse/YARN-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577644#comment-16577644
]
Naganarasimha G R commented on YARN-7863:
-
Thanks for the patch [~sunilg] and apologies for the
[
https://issues.apache.org/jira/browse/YARN-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16567462#comment-16567462
]
genericqa commented on YARN-7863:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16567127#comment-16567127
]
Sunil Govindan commented on YARN-7863:
--
Attached rebased patch.
[~cheersyang], these constraints
[
https://issues.apache.org/jira/browse/YARN-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16561858#comment-16561858
]
Weiwei Yang commented on YARN-7863:
---
{quote}
For DS, I think its better we correlate with placement_spec
[
https://issues.apache.org/jira/browse/YARN-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16561134#comment-16561134
]
Naganarasimha G R commented on YARN-7863:
-
Hi [~sunilg],
Patch seems to fail after rebase (tried
[
https://issues.apache.org/jira/browse/YARN-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16558735#comment-16558735
]
genericqa commented on YARN-7863:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16558728#comment-16558728
]
Sunil Govindan commented on YARN-7863:
--
Thanks [~Naganarasimha] and [~cheersyang] for comments
A
[
https://issues.apache.org/jira/browse/YARN-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553691#comment-16553691
]
Naganarasimha G R commented on YARN-7863:
-
Have done just a first pass review,
few higher level
[
https://issues.apache.org/jira/browse/YARN-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16552201#comment-16552201
]
Naganarasimha G R commented on YARN-7863:
-
Hi [~sunilg],
While i am going through the patch,
[
https://issues.apache.org/jira/browse/YARN-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16534148#comment-16534148
]
Sunil Govindan commented on YARN-7863:
--
Thanks [~Naganarasimha] for the comments.
{quote}bq. 1.who
[
https://issues.apache.org/jira/browse/YARN-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16529118#comment-16529118
]
Naganarasimha G R commented on YARN-7863:
-
[~sunilg],
Few queries before going into the detail
[
https://issues.apache.org/jira/browse/YARN-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16529111#comment-16529111
]
Naganarasimha G R commented on YARN-7863:
-
Thanks for the patch [~sunilg], It gives a very good
[
https://issues.apache.org/jira/browse/YARN-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16526965#comment-16526965
]
Sunil Govindan commented on YARN-7863:
--
Attaching first version for this patch. I will add more test
[
https://issues.apache.org/jira/browse/YARN-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16474464#comment-16474464
]
Naganarasimha G R commented on YARN-7863:
-
Thanks [~sunilg], Would support you in the review of it
[
https://issues.apache.org/jira/browse/YARN-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16474124#comment-16474124
]
Sunil G commented on YARN-7863:
---
Given YARN-7892 is now committed, updating this patch shortly
> Modify
[
https://issues.apache.org/jira/browse/YARN-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347372#comment-16347372
]
Konstantinos Karanasos commented on YARN-7863:
--
Ideally there should be no API changes for
[
https://issues.apache.org/jira/browse/YARN-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346479#comment-16346479
]
Weiwei Yang commented on YARN-7863:
---
Hi [~sunilg], if you have bandwidth, I appreciate if you can work on
[
https://issues.apache.org/jira/browse/YARN-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346399#comment-16346399
]
Wangda Tan commented on YARN-7863:
--
[~asuresh] / [~sunilg] , is there anything need to be done before
[
https://issues.apache.org/jira/browse/YARN-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346391#comment-16346391
]
Arun Suresh commented on YARN-7863:
---
[~sunilg], There are actually two aspects to this:
# Supporting node
[
https://issues.apache.org/jira/browse/YARN-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346382#comment-16346382
]
Sunil G commented on YARN-7863:
---
[~cheersyang] I thought of creating this ticket under YARN-3409 itself as
54 matches
Mail list logo
