[
https://issues.apache.org/jira/browse/YARN-8013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424766#comment-16424766
]
Konstantinos Karanasos commented on YARN-8013:
--
Sure, will commit this now.
> Support APP-TAG
[
https://issues.apache.org/jira/browse/YARN-8013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424724#comment-16424724
]
Weiwei Yang commented on YARN-8013:
---
Hi [~kkaranasos], thanks. Do you want me to take care of committing
[
https://issues.apache.org/jira/browse/YARN-8013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16423577#comment-16423577
]
Konstantinos Karanasos commented on YARN-8013:
--
+1, thanks [~cheersyang].
> Support APP-TAG
[
https://issues.apache.org/jira/browse/YARN-8013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16423544#comment-16423544
]
Weiwei Yang commented on YARN-8013:
---
Hi [~kkaranasos], does v7 patch look good to you?
> Support APP-TAG
[
https://issues.apache.org/jira/browse/YARN-8013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16423483#comment-16423483
]
genericqa commented on YARN-8013:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16423400#comment-16423400
]
Weiwei Yang commented on YARN-8013:
---
Hi [~kkaranasos]
Thanks, I've fixed the checkstyle issues in v7
[
https://issues.apache.org/jira/browse/YARN-8013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16423394#comment-16423394
]
Konstantinos Karanasos commented on YARN-8013:
--
+1, thanks [~cheersyang].
(There seem to be a
[
https://issues.apache.org/jira/browse/YARN-8013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16423383#comment-16423383
]
genericqa commented on YARN-8013:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16423280#comment-16423280
]
Weiwei Yang commented on YARN-8013:
---
Hi [~kkaranasos]
{quote}I would call the class
[
https://issues.apache.org/jira/browse/YARN-8013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16422820#comment-16422820
]
Konstantinos Karanasos commented on YARN-8013:
--
Thanks for the new patch, [~cheersyang].
I
[
https://issues.apache.org/jira/browse/YARN-8013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16421572#comment-16421572
]
Weiwei Yang commented on YARN-8013:
---
Hi [~kkaranasos], please take a look at the latest patch. Thanks
>
[
https://issues.apache.org/jira/browse/YARN-8013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16421171#comment-16421171
]
genericqa commented on YARN-8013:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16421128#comment-16421128
]
Weiwei Yang commented on YARN-8013:
---
Hi [~kkaranasos]
Thanks for providing your feedback.
[
https://issues.apache.org/jira/browse/YARN-8013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16421040#comment-16421040
]
Konstantinos Karanasos commented on YARN-8013:
--
Thanks again for working on this,
[
https://issues.apache.org/jira/browse/YARN-8013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16418099#comment-16418099
]
Konstantinos Karanasos commented on YARN-8013:
--
Thanks [~cheersyang] for working on this and
[
https://issues.apache.org/jira/browse/YARN-8013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417579#comment-16417579
]
Wangda Tan commented on YARN-8013:
--
Thanks [~cheersyang], sounds good. Will wait 2 more days to see if
[
https://issues.apache.org/jira/browse/YARN-8013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16416842#comment-16416842
]
genericqa commented on YARN-8013:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16416736#comment-16416736
]
Weiwei Yang commented on YARN-8013:
---
Hi [~leftnoteasy]
Thanks for the review. I have addressed your #1
[
https://issues.apache.org/jira/browse/YARN-8013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16416505#comment-16416505
]
Wangda Tan commented on YARN-8013:
--
Thanks [~cheersyang], comments/questions:
1) getAllApplicationIds =>
[
https://issues.apache.org/jira/browse/YARN-8013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16409291#comment-16409291
]
Weiwei Yang commented on YARN-8013:
---
The UT failure is not related to this patch. [~leftnoteasy],
[
https://issues.apache.org/jira/browse/YARN-8013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16409190#comment-16409190
]
genericqa commented on YARN-8013:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408961#comment-16408961
]
Weiwei Yang commented on YARN-8013:
---
Forgot to update LocalAllocationTagsManager which caused the UT
[
https://issues.apache.org/jira/browse/YARN-8013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16407968#comment-16407968
]
genericqa commented on YARN-8013:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16407788#comment-16407788
]
Weiwei Yang commented on YARN-8013:
---
V2 patch uploaded. The patch basically has following changes
*
[
https://issues.apache.org/jira/browse/YARN-8013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16392546#comment-16392546
]
Weiwei Yang commented on YARN-8013:
---
Based on the work of YARN-8002, it doesn't need big change to
[
https://issues.apache.org/jira/browse/YARN-8013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16391109#comment-16391109
]
Weiwei Yang commented on YARN-8013:
---
Loop [~leftnoteasy], [~asuresh], [~kkaranasos] for discussion,
26 matches
Mail list logo