[
https://issues.apache.org/jira/browse/YARN-8015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16588279#comment-16588279
]
Weiwei Yang commented on YARN-8015:
---
Hi [~sunilg], thanks
{quote}I think we can commit this only to
[
https://issues.apache.org/jira/browse/YARN-8015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16588274#comment-16588274
]
Sunil Govindan commented on YARN-8015:
--
Thanks [~cheersyang]. Looks fine to me.
Committing shortly.
[
https://issues.apache.org/jira/browse/YARN-8015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16585338#comment-16585338
]
Weiwei Yang commented on YARN-8015:
---
Hi [~sunilg]
To answer your questions:
# Current patch is
[
https://issues.apache.org/jira/browse/YARN-8015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16585209#comment-16585209
]
Sunil Govindan commented on YARN-8015:
--
Thanks for the patch [~cheersyang]
Some quick questions:
#
[
https://issues.apache.org/jira/browse/YARN-8015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16580698#comment-16580698
]
Weiwei Yang commented on YARN-8015:
---
Hi [~sunilg], please help to review, thanks.
> Complete placement
[
https://issues.apache.org/jira/browse/YARN-8015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16580695#comment-16580695
]
genericqa commented on YARN-8015:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16580618#comment-16580618
]
Weiwei Yang commented on YARN-8015:
---
Fix findbugs warning in v4 patch.
> Complete placement constraint
[
https://issues.apache.org/jira/browse/YARN-8015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16580088#comment-16580088
]
genericqa commented on YARN-8015:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16579917#comment-16579917
]
Weiwei Yang commented on YARN-8015:
---
Rebase to latest trunk, [~sunil.gov...@gmail.com] please help to