[jira] [Commented] (YARN-803) factor out scheduler config validation from the ResourceManager to each scheduler implementation

2013-06-14 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13683515#comment-13683515 ] Hadoop QA commented on YARN-803: {color:green}+1 overall{color}. Here are the results of te

[jira] [Commented] (YARN-803) factor out scheduler config validation from the ResourceManager to each scheduler implementation

2013-06-14 Thread Alejandro Abdelnur (JIRA)
[ https://issues.apache.org/jira/browse/YARN-803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13683457#comment-13683457 ] Alejandro Abdelnur commented on YARN-803: - that is a typo, i'll fix and upload patch

[jira] [Commented] (YARN-803) factor out scheduler config validation from the ResourceManager to each scheduler implementation

2013-06-14 Thread Tom White (JIRA)
[ https://issues.apache.org/jira/browse/YARN-803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13683454#comment-13683454 ] Tom White commented on YARN-803: Looks good to me. Is there a reason FairScheduler#validateC

[jira] [Commented] (YARN-803) factor out scheduler config validation from the ResourceManager to each scheduler implementation

2013-06-13 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13682709#comment-13682709 ] Hadoop QA commented on YARN-803: {color:green}+1 overall{color}. Here are the results of te

[jira] [Commented] (YARN-803) factor out scheduler config validation from the ResourceManager to each scheduler implementation

2013-06-13 Thread Zhijie Shen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13682652#comment-13682652 ] Zhijie Shen commented on YARN-803: -- looks good. +1 > factor out scheduler

[jira] [Commented] (YARN-803) factor out scheduler config validation from the ResourceManager to each scheduler implementation

2013-06-13 Thread Alejandro Abdelnur (JIRA)
[ https://issues.apache.org/jira/browse/YARN-803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13682634#comment-13682634 ] Alejandro Abdelnur commented on YARN-803: - Sandhy, SchedulerUtils is for all schedul

[jira] [Commented] (YARN-803) factor out scheduler config validation from the ResourceManager to each scheduler implementation

2013-06-13 Thread Sandy Ryza (JIRA)
[ https://issues.apache.org/jira/browse/YARN-803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13682635#comment-13682635 ] Sandy Ryza commented on YARN-803: - Ok, makes sense. > factor out scheduler

[jira] [Commented] (YARN-803) factor out scheduler config validation from the ResourceManager to each scheduler implementation

2013-06-13 Thread Sandy Ryza (JIRA)
[ https://issues.apache.org/jira/browse/YARN-803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13682636#comment-13682636 ] Sandy Ryza commented on YARN-803: - +1 > factor out scheduler config validat

[jira] [Commented] (YARN-803) factor out scheduler config validation from the ResourceManager to each scheduler implementation

2013-06-13 Thread Sandy Ryza (JIRA)
[ https://issues.apache.org/jira/browse/YARN-803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13682619#comment-13682619 ] Sandy Ryza commented on YARN-803: - Would it make sense to put validateConf in SchedulerUtils

[jira] [Commented] (YARN-803) factor out scheduler config validation from the ResourceManager to each scheduler implementation

2013-06-13 Thread Alejandro Abdelnur (JIRA)
[ https://issues.apache.org/jira/browse/YARN-803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13682564#comment-13682564 ] Alejandro Abdelnur commented on YARN-803: - mmh, so i guess we could do a mix of what

[jira] [Commented] (YARN-803) factor out scheduler config validation from the ResourceManager to each scheduler implementation

2013-06-13 Thread Sandy Ryza (JIRA)
[ https://issues.apache.org/jira/browse/YARN-803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13682503#comment-13682503 ] Sandy Ryza commented on YARN-803: - A Configuration already gets passed in when a scheduler's

[jira] [Commented] (YARN-803) factor out scheduler config validation from the ResourceManager to each scheduler implementation

2013-06-13 Thread Alejandro Abdelnur (JIRA)
[ https://issues.apache.org/jira/browse/YARN-803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13682495#comment-13682495 ] Alejandro Abdelnur commented on YARN-803: - Zhijie, On adding the setConf() method t

[jira] [Commented] (YARN-803) factor out scheduler config validation from the ResourceManager to each scheduler implementation

2013-06-13 Thread Zhijie Shen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13682444#comment-13682444 ] Zhijie Shen commented on YARN-803: -- It sounds a good idea to support polymorphy of config v

[jira] [Commented] (YARN-803) factor out scheduler config validation from the ResourceManager to each scheduler implementation

2013-06-13 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13682434#comment-13682434 ] Hadoop QA commented on YARN-803: {color:green}+1 overall{color}. Here are the results of te