[jira] [Commented] (YARN-8096) Wrong condition in AmIpFilter#getProxyAddresses() to update the proxy IP list

2018-04-17 Thread Oleksandr Shevchenko (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16441478#comment-16441478 ] Oleksandr Shevchenko commented on YARN-8096: Thanks a lot [~elgoiri] and [~giov

[jira] [Commented] (YARN-8096) Wrong condition in AmIpFilter#getProxyAddresses() to update the proxy IP list

2018-04-17 Thread JIRA
[ https://issues.apache.org/jira/browse/YARN-8096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16441428#comment-16441428 ] Íñigo Goiri commented on YARN-8096: --- Thanks [~oshevchenko] for the patch and [~giovanni.f

[jira] [Commented] (YARN-8096) Wrong condition in AmIpFilter#getProxyAddresses() to update the proxy IP list

2018-04-17 Thread Giovanni Matteo Fumarola (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16441398#comment-16441398 ] Giovanni Matteo Fumarola commented on YARN-8096: Thanks [~oshevchenko] for

[jira] [Commented] (YARN-8096) Wrong condition in AmIpFilter#getProxyAddresses() to update the proxy IP list

2018-03-31 Thread Oleksandr Shevchenko (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16421437#comment-16421437 ] Oleksandr Shevchenko commented on YARN-8096: Thanks [~elgoiri]. If we got Servl

[jira] [Commented] (YARN-8096) Wrong condition in AmIpFilter#getProxyAddresses() to update the proxy IP list

2018-03-31 Thread JIRA
[ https://issues.apache.org/jira/browse/YARN-8096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16421387#comment-16421387 ] Íñigo Goiri commented on YARN-8096: --- [^YARN-8096.003.patch] LGTM. The only quesiton is r

[jira] [Commented] (YARN-8096) Wrong condition in AmIpFilter#getProxyAddresses() to update the proxy IP list

2018-03-31 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16421225#comment-16421225 ] genericqa commented on YARN-8096: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote |

[jira] [Commented] (YARN-8096) Wrong condition in AmIpFilter#getProxyAddresses() to update the proxy IP list

2018-03-30 Thread Oleksandr Shevchenko (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16421194#comment-16421194 ] Oleksandr Shevchenko commented on YARN-8096: [~elgoiri] Thanks a lot for the re

[jira] [Commented] (YARN-8096) Wrong condition in AmIpFilter#getProxyAddresses() to update the proxy IP list

2018-03-30 Thread JIRA
[ https://issues.apache.org/jira/browse/YARN-8096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16421063#comment-16421063 ] Íñigo Goiri commented on YARN-8096: --- I missed the second part of [^YARN-8096.002.patch];

[jira] [Commented] (YARN-8096) Wrong condition in AmIpFilter#getProxyAddresses() to update the proxy IP list

2018-03-30 Thread JIRA
[ https://issues.apache.org/jira/browse/YARN-8096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16421061#comment-16421061 ] Íñigo Goiri commented on YARN-8096: --- Thanks [~oshevchenko], there is no need to check for

[jira] [Commented] (YARN-8096) Wrong condition in AmIpFilter#getProxyAddresses() to update the proxy IP list

2018-03-30 Thread Oleksandr Shevchenko (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16420972#comment-16420972 ] Oleksandr Shevchenko commented on YARN-8096: For initialization, AmIpFilter is

[jira] [Commented] (YARN-8096) Wrong condition in AmIpFilter#getProxyAddresses() to update the proxy IP list

2018-03-30 Thread JIRA
[ https://issues.apache.org/jira/browse/YARN-8096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16420822#comment-16420822 ] Íñigo Goiri commented on YARN-8096: --- Yes, you can get it from YarnConfiguration and actua

[jira] [Commented] (YARN-8096) Wrong condition in AmIpFilter#getProxyAddresses() to update the proxy IP list

2018-03-30 Thread Oleksandr Shevchenko (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16420819#comment-16420819 ] Oleksandr Shevchenko commented on YARN-8096: [~elgoiri] This property is final.

[jira] [Commented] (YARN-8096) Wrong condition in AmIpFilter#getProxyAddresses() to update the proxy IP list

2018-03-30 Thread JIRA
[ https://issues.apache.org/jira/browse/YARN-8096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16420799#comment-16420799 ] Íñigo Goiri commented on YARN-8096: --- [~oshevchenko], you can make the UPDATE_INTERVAL con

[jira] [Commented] (YARN-8096) Wrong condition in AmIpFilter#getProxyAddresses() to update the proxy IP list

2018-03-30 Thread Oleksandr Shevchenko (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16420692#comment-16420692 ] Oleksandr Shevchenko commented on YARN-8096: [~giovanni.fumarola], I'll add the

[jira] [Commented] (YARN-8096) Wrong condition in AmIpFilter#getProxyAddresses() to update the proxy IP list

2018-03-30 Thread Oleksandr Shevchenko (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16420689#comment-16420689 ] Oleksandr Shevchenko commented on YARN-8096: Thank you [~elgoiri] . > Wrong co

[jira] [Commented] (YARN-8096) Wrong condition in AmIpFilter#getProxyAddresses() to update the proxy IP list

2018-03-30 Thread Giovanni Matteo Fumarola (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16420688#comment-16420688 ] Giovanni Matteo Fumarola commented on YARN-8096: I took a second look of th

[jira] [Commented] (YARN-8096) Wrong condition in AmIpFilter#getProxyAddresses() to update the proxy IP list

2018-03-30 Thread JIRA
[ https://issues.apache.org/jira/browse/YARN-8096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16420685#comment-16420685 ] Íñigo Goiri commented on YARN-8096: --- [~oshevchenko], I added you to the list of contribut

[jira] [Commented] (YARN-8096) Wrong condition in AmIpFilter#getProxyAddresses() to update the proxy IP list

2018-03-30 Thread Oleksandr Shevchenko (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16420670#comment-16420670 ] Oleksandr Shevchenko commented on YARN-8096: [~giovanni.fumarola] Thanks a lot

[jira] [Commented] (YARN-8096) Wrong condition in AmIpFilter#getProxyAddresses() to update the proxy IP list

2018-03-30 Thread Giovanni Matteo Fumarola (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16420641#comment-16420641 ] Giovanni Matteo Fumarola commented on YARN-8096: Thanks [~oshevchenko] for

[jira] [Commented] (YARN-8096) Wrong condition in AmIpFilter#getProxyAddresses() to update the proxy IP list

2018-03-30 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16420624#comment-16420624 ] genericqa commented on YARN-8096: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-8096) Wrong condition in AmIpFilter#getProxyAddresses() to update the proxy IP list

2018-03-30 Thread Oleksandr Shevchenko (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16420550#comment-16420550 ] Oleksandr Shevchenko commented on YARN-8096: [^YARN-8096.001.patch] > Wrong co