[jira] [Commented] (YARN-8206) Sending a kill does not immediately kill docker containers

[ https://issues.apache.org/jira/browse/YARN-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16484382#comment-16484382 ] Eric Badger commented on YARN-8206: --- Wonderful! Thanks [~jlowe] for the review/commit and

[jira] [Commented] (YARN-8206) Sending a kill does not immediately kill docker containers

[ https://issues.apache.org/jira/browse/YARN-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16484093#comment-16484093 ] Hudson commented on YARN-8206: -- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #1425

[jira] [Commented] (YARN-8206) Sending a kill does not immediately kill docker containers

[ https://issues.apache.org/jira/browse/YARN-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16483087#comment-16483087 ] Jason Lowe commented on YARN-8206: -- Thanks for updating the patch! +1 lgtm. I'll commit

[jira] [Commented] (YARN-8206) Sending a kill does not immediately kill docker containers

[ https://issues.apache.org/jira/browse/YARN-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16482809#comment-16482809 ] genericqa commented on YARN-8206: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote |

[jira] [Commented] (YARN-8206) Sending a kill does not immediately kill docker containers

[ https://issues.apache.org/jira/browse/YARN-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16482694#comment-16482694 ] Eric Badger commented on YARN-8206: --- Thanks for the review, [~jlowe]! Patch 011 addresses

[jira] [Commented] (YARN-8206) Sending a kill does not immediately kill docker containers

[ https://issues.apache.org/jira/browse/YARN-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16482584#comment-16482584 ] Jason Lowe commented on YARN-8206: -- Thanks for updating the patch! Unfortunately the patc

[jira] [Commented] (YARN-8206) Sending a kill does not immediately kill docker containers

[ https://issues.apache.org/jira/browse/YARN-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16479463#comment-16479463 ] genericqa commented on YARN-8206: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote |

[jira] [Commented] (YARN-8206) Sending a kill does not immediately kill docker containers

[ https://issues.apache.org/jira/browse/YARN-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16479315#comment-16479315 ] Eric Badger commented on YARN-8206: --- Thanks for the review, [~jlowe]! Patch 010 addresses

[jira] [Commented] (YARN-8206) Sending a kill does not immediately kill docker containers

[ https://issues.apache.org/jira/browse/YARN-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16476476#comment-16476476 ] Jason Lowe commented on YARN-8206: -- Thanks for the patch! Calling allowPrivilegedContaine

[jira] [Commented] (YARN-8206) Sending a kill does not immediately kill docker containers

[ https://issues.apache.org/jira/browse/YARN-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469590#comment-16469590 ] genericqa commented on YARN-8206: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote |

[jira] [Commented] (YARN-8206) Sending a kill does not immediately kill docker containers

[ https://issues.apache.org/jira/browse/YARN-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469423#comment-16469423 ] Eric Badger commented on YARN-8206: --- Somehow lost the checkstyle changes during the rebas

[jira] [Commented] (YARN-8206) Sending a kill does not immediately kill docker containers

[ https://issues.apache.org/jira/browse/YARN-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469411#comment-16469411 ] genericqa commented on YARN-8206: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote |

[jira] [Commented] (YARN-8206) Sending a kill does not immediately kill docker containers

[ https://issues.apache.org/jira/browse/YARN-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469331#comment-16469331 ] Jim Brennan commented on YARN-8206: --- New patch looks good to me. > Sending a kill does n

[jira] [Commented] (YARN-8206) Sending a kill does not immediately kill docker containers

[ https://issues.apache.org/jira/browse/YARN-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469205#comment-16469205 ] Eric Badger commented on YARN-8206: --- bq. Eric Badger, patch 7 does not look right... face

[jira] [Commented] (YARN-8206) Sending a kill does not immediately kill docker containers

[ https://issues.apache.org/jira/browse/YARN-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469201#comment-16469201 ] Jim Brennan commented on YARN-8206: --- [~ebadger], patch 7 does not look right...   > Sen

[jira] [Commented] (YARN-8206) Sending a kill does not immediately kill docker containers

[ https://issues.apache.org/jira/browse/YARN-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469191#comment-16469191 ] Eric Badger commented on YARN-8206: --- Thanks for the review, [~Jim_Brennan]! Uploaded new

[jira] [Commented] (YARN-8206) Sending a kill does not immediately kill docker containers

[ https://issues.apache.org/jira/browse/YARN-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469116#comment-16469116 ] Jim Brennan commented on YARN-8206: --- [~ebadger], thanks for the patch! In handleContaine

[jira] [Commented] (YARN-8206) Sending a kill does not immediately kill docker containers

[ https://issues.apache.org/jira/browse/YARN-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469028#comment-16469028 ] genericqa commented on YARN-8206: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote |

[jira] [Commented] (YARN-8206) Sending a kill does not immediately kill docker containers

[ https://issues.apache.org/jira/browse/YARN-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16468909#comment-16468909 ] Eric Badger commented on YARN-8206: --- Fixing checkstyle > Sending a kill does not immedia

[jira] [Commented] (YARN-8206) Sending a kill does not immediately kill docker containers

[ https://issues.apache.org/jira/browse/YARN-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16468117#comment-16468117 ] genericqa commented on YARN-8206: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote |

[jira] [Commented] (YARN-8206) Sending a kill does not immediately kill docker containers

[ https://issues.apache.org/jira/browse/YARN-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16468047#comment-16468047 ] Eric Badger commented on YARN-8206: --- Attaching a new patch that uses the docker api for p

[jira] [Commented] (YARN-8206) Sending a kill does not immediately kill docker containers

[ https://issues.apache.org/jira/browse/YARN-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467626#comment-16467626 ] Eric Badger commented on YARN-8206: --- Thanks for the quick input! I'll put up a patch soon

[jira] [Commented] (YARN-8206) Sending a kill does not immediately kill docker containers

[ https://issues.apache.org/jira/browse/YARN-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467574#comment-16467574 ] Jim Brennan commented on YARN-8206: --- +1 for proposal 2. > Sending a kill does not immedi

[jira] [Commented] (YARN-8206) Sending a kill does not immediately kill docker containers

[ https://issues.apache.org/jira/browse/YARN-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467406#comment-16467406 ] Jason Lowe commented on YARN-8206: -- +1 for proposal 2 from me as well. > Sending a kill d

[jira] [Commented] (YARN-8206) Sending a kill does not immediately kill docker containers

[ https://issues.apache.org/jira/browse/YARN-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467265#comment-16467265 ] Shane Kumpf commented on YARN-8206: --- [~ebadger] - I'm also +1 for proposal 2. > Sending

[jira] [Commented] (YARN-8206) Sending a kill does not immediately kill docker containers

[ https://issues.apache.org/jira/browse/YARN-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16466616#comment-16466616 ] Eric Yang commented on YARN-8206: - [~ebadger] +1 for proposal 2. This is safer option in m

[jira] [Commented] (YARN-8206) Sending a kill does not immediately kill docker containers

[ https://issues.apache.org/jira/browse/YARN-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16466529#comment-16466529 ] Eric Badger commented on YARN-8206: --- [~eyang], [~shaneku...@gmail.com], [~jlowe], [~Jim_B

[jira] [Commented] (YARN-8206) Sending a kill does not immediately kill docker containers

[ https://issues.apache.org/jira/browse/YARN-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16461771#comment-16461771 ] genericqa commented on YARN-8206: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote |

[jira] [Commented] (YARN-8206) Sending a kill does not immediately kill docker containers

[ https://issues.apache.org/jira/browse/YARN-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16461751#comment-16461751 ] Eric Yang commented on YARN-8206: - >From today's meeting, signal handling is ran as the use

[jira] [Commented] (YARN-8206) Sending a kill does not immediately kill docker containers

[ https://issues.apache.org/jira/browse/YARN-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16461678#comment-16461678 ] Eric Badger commented on YARN-8206: --- Patch 004 removes unused import > Sending a kill do

[jira] [Commented] (YARN-8206) Sending a kill does not immediately kill docker containers

[ https://issues.apache.org/jira/browse/YARN-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16461627#comment-16461627 ] genericqa commented on YARN-8206: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote |

[jira] [Commented] (YARN-8206) Sending a kill does not immediately kill docker containers

[ https://issues.apache.org/jira/browse/YARN-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16461567#comment-16461567 ] Shane Kumpf commented on YARN-8206: --- Thanks [~ebadger]! {quote}I'm looking through the c

[jira] [Commented] (YARN-8206) Sending a kill does not immediately kill docker containers

[ https://issues.apache.org/jira/browse/YARN-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16461556#comment-16461556 ] Eric Badger commented on YARN-8206: --- Hey [~shaneku...@gmail.com], thanks for the review.

[jira] [Commented] (YARN-8206) Sending a kill does not immediately kill docker containers

[ https://issues.apache.org/jira/browse/YARN-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16461463#comment-16461463 ] Shane Kumpf commented on YARN-8206: --- Thanks for the patch, [~ebadger]! I've been able to

[jira] [Commented] (YARN-8206) Sending a kill does not immediately kill docker containers

[ https://issues.apache.org/jira/browse/YARN-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16460299#comment-16460299 ] genericqa commented on YARN-8206: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-8206) Sending a kill does not immediately kill docker containers

[ https://issues.apache.org/jira/browse/YARN-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16460185#comment-16460185 ] Eric Badger commented on YARN-8206: --- Not quite sure how I missed the lack of {{executePri

[jira] [Commented] (YARN-8206) Sending a kill does not immediately kill docker containers

[ https://issues.apache.org/jira/browse/YARN-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16459701#comment-16459701 ] Jason Lowe commented on YARN-8206: -- {quote}Can we send signal to wrong pid, if pid namespa

[jira] [Commented] (YARN-8206) Sending a kill does not immediately kill docker containers

[ https://issues.apache.org/jira/browse/YARN-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16459446#comment-16459446 ] Eric Yang commented on YARN-8206: - [~Jim_Brennan] Docker supports pid namespace. Can we se

[jira] [Commented] (YARN-8206) Sending a kill does not immediately kill docker containers

[ https://issues.apache.org/jira/browse/YARN-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16459209#comment-16459209 ] genericqa commented on YARN-8206: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-8206) Sending a kill does not immediately kill docker containers

[ https://issues.apache.org/jira/browse/YARN-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16458716#comment-16458716 ] Shane Kumpf commented on YARN-8206: --- Thanks for the additional background, [~Jim_Brennan]

[jira] [Commented] (YARN-8206) Sending a kill does not immediately kill docker containers

[ https://issues.apache.org/jira/browse/YARN-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16458694#comment-16458694 ] Jim Brennan commented on YARN-8206: --- [~eyang], [~jlowe], I'm not sure I see the advantage

[jira] [Commented] (YARN-8206) Sending a kill does not immediately kill docker containers

[ https://issues.apache.org/jira/browse/YARN-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16454599#comment-16454599 ] Eric Yang commented on YARN-8206: - [~jlowe] I agree with [~shaneku...@gmail.com] to use doc

[jira] [Commented] (YARN-8206) Sending a kill does not immediately kill docker containers

[ https://issues.apache.org/jira/browse/YARN-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16454179#comment-16454179 ] Jason Lowe commented on YARN-8206: -- bq. I expect the Docker maintainers would steer us tow

[jira] [Commented] (YARN-8206) Sending a kill does not immediately kill docker containers

[ https://issues.apache.org/jira/browse/YARN-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453922#comment-16453922 ] Shane Kumpf commented on YARN-8206: --- {quote}Is it necessary to do a docker kill? We alrea

[jira] [Commented] (YARN-8206) Sending a kill does not immediately kill docker containers

[ https://issues.apache.org/jira/browse/YARN-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453126#comment-16453126 ] Jason Lowe commented on YARN-8206: -- Is it necessary to do a docker kill? We already have

[jira] [Commented] (YARN-8206) Sending a kill does not immediately kill docker containers

[ https://issues.apache.org/jira/browse/YARN-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453020#comment-16453020 ] Shane Kumpf commented on YARN-8206: --- Thanks for raising this [~ebadger]. The reasoning be

[jira] [Commented] (YARN-8206) Sending a kill does not immediately kill docker containers

[ https://issues.apache.org/jira/browse/YARN-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452976#comment-16452976 ] Eric Badger commented on YARN-8206: --- My proposal is that we handle {{KILL}} and {{TERM}}