[jira] [Commented] (YARN-8243) Flex down should first remove pending container requests (if any) and then kill running containers

2018-05-10 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471269#comment-16471269 ] genericqa commented on YARN-8243: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-8243) Flex down should first remove pending container requests (if any) and then kill running containers

2018-05-10 Thread Gour Saha (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471196#comment-16471196 ] Gour Saha commented on YARN-8243: - Ah, I know what you are saying [~billie.rinaldi]. I modified the patch

[jira] [Commented] (YARN-8243) Flex down should first remove pending container requests (if any) and then kill running containers

2018-05-09 Thread Billie Rinaldi (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469368#comment-16469368 ] Billie Rinaldi commented on YARN-8243: -- I strongly feel we should not make the changes to

[jira] [Commented] (YARN-8243) Flex down should first remove pending container requests (if any) and then kill running containers

2018-05-09 Thread Gour Saha (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469360#comment-16469360 ] Gour Saha commented on YARN-8243: - bq. The only situation the compareTo fix would not address is when comp0

[jira] [Commented] (YARN-8243) Flex down should first remove pending container requests (if any) and then kill running containers

2018-05-09 Thread Billie Rinaldi (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469120#comment-16469120 ] Billie Rinaldi commented on YARN-8243: -- bq. Let's say a service owner flexes up her service by 2 extra

[jira] [Commented] (YARN-8243) Flex down should first remove pending container requests (if any) and then kill running containers

2018-05-09 Thread Gour Saha (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469022#comment-16469022 ] Gour Saha commented on YARN-8243: - bq. component.pendingInstances.remove(instance); on line 358 may not be

[jira] [Commented] (YARN-8243) Flex down should first remove pending container requests (if any) and then kill running containers

2018-05-09 Thread Gour Saha (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469020#comment-16469020 ] Gour Saha commented on YARN-8243: - bq. The compareTo method is checking the container start time, when it

[jira] [Commented] (YARN-8243) Flex down should first remove pending container requests (if any) and then kill running containers

2018-05-08 Thread Suma Shivaprasad (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468104#comment-16468104 ] Suma Shivaprasad commented on YARN-8243: [~gsaha] component.pendingInstances.remove(instance); on

[jira] [Commented] (YARN-8243) Flex down should first remove pending container requests (if any) and then kill running containers

2018-05-08 Thread Billie Rinaldi (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467675#comment-16467675 ] Billie Rinaldi commented on YARN-8243: -- bq. Isn't that what we want? Yes, I'm saying that removing the

[jira] [Commented] (YARN-8243) Flex down should first remove pending container requests (if any) and then kill running containers

2018-05-08 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467033#comment-16467033 ] genericqa commented on YARN-8243: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-8243) Flex down should first remove pending container requests (if any) and then kill running containers

2018-05-08 Thread Gour Saha (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16466924#comment-16466924 ] Gour Saha commented on YARN-8243: - bq. It seems that, based on the component instance ID assignment, we

[jira] [Commented] (YARN-8243) Flex down should first remove pending container requests (if any) and then kill running containers

2018-05-07 Thread Billie Rinaldi (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16466259#comment-16466259 ] Billie Rinaldi commented on YARN-8243: -- I think one problem here is that the ComponentInstance