[jira] [Commented] (YARN-8259) Revisit liveliness checks for Docker containers

2018-06-13 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16511814#comment-16511814 ] Hudson commented on YARN-8259: -- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14424 (See

[jira] [Commented] (YARN-8259) Revisit liveliness checks for Docker containers

2018-06-13 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16511444#comment-16511444 ] genericqa commented on YARN-8259: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-8259) Revisit liveliness checks for Docker containers

2018-06-12 Thread Shane Kumpf (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16510290#comment-16510290 ] Shane Kumpf commented on YARN-8259: --- Thanks for the input everyone. {quote}Could you add some

[jira] [Commented] (YARN-8259) Revisit liveliness checks for Docker containers

2018-06-12 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16510275#comment-16510275 ] Eric Yang commented on YARN-8259: - 4 People have expressed opinion to go with option #1. Therefore, this

[jira] [Commented] (YARN-8259) Revisit liveliness checks for Docker containers

2018-06-11 Thread Eric Badger (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16508657#comment-16508657 ] Eric Badger commented on YARN-8259: --- I would give a slight preference to proposal #1 because of

[jira] [Commented] (YARN-8259) Revisit liveliness checks for Docker containers

2018-06-11 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16508516#comment-16508516 ] Eric Yang commented on YARN-8259: - I prefer #3 to keep abstraction in place, and improve portability. #1

[jira] [Commented] (YARN-8259) Revisit liveliness checks for Docker containers

2018-06-11 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16508198#comment-16508198 ] Jim Brennan commented on YARN-8259: --- I think we should go with Option 1 with documentation to whitelist

[jira] [Commented] (YARN-8259) Revisit liveliness checks for Docker containers

2018-06-10 Thread Shane Kumpf (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507437#comment-16507437 ] Shane Kumpf commented on YARN-8259: --- [~eyang], [~Jim_Brennan], [~ebadger], [~jlowe] - any additional

[jira] [Commented] (YARN-8259) Revisit liveliness checks for Docker containers

2018-05-31 Thread Shane Kumpf (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16497266#comment-16497266 ] Shane Kumpf commented on YARN-8259: --- Thanks for the feedback, [~ebadger]. {quote}if the yarn user is

[jira] [Commented] (YARN-8259) Revisit liveliness checks for Docker containers

2018-05-31 Thread Eric Badger (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16497239#comment-16497239 ] Eric Badger commented on YARN-8259: --- For proposal #1, if the yarn user is whitelisted for hidepid, then

[jira] [Commented] (YARN-8259) Revisit liveliness checks for Docker containers

2018-05-31 Thread Shane Kumpf (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16496492#comment-16496492 ] Shane Kumpf commented on YARN-8259: --- I've been doing additional testing here and could use input from

[jira] [Commented] (YARN-8259) Revisit liveliness checks for Docker containers

2018-05-22 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16484271#comment-16484271 ] Eric Yang commented on YARN-8259: - [~shaneku...@gmail.com] The proposal for implementing both is okay, but

[jira] [Commented] (YARN-8259) Revisit liveliness checks for Docker containers

2018-05-22 Thread Shane Kumpf (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16483845#comment-16483845 ] Shane Kumpf commented on YARN-8259: --- {quote}System administrator can reserve one cpu core for node

[jira] [Commented] (YARN-8259) Revisit liveliness checks for Docker containers

2018-05-21 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16483057#comment-16483057 ] Eric Yang commented on YARN-8259: - System administrator can reserve one cpu core for node manager and all

[jira] [Commented] (YARN-8259) Revisit liveliness checks for Docker containers

2018-05-21 Thread Eric Badger (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16483041#comment-16483041 ] Eric Badger commented on YARN-8259: --- Also, I have tested the current patch for correctness. So, if we

[jira] [Commented] (YARN-8259) Revisit liveliness checks for Docker containers

2018-05-21 Thread Eric Badger (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16483038#comment-16483038 ] Eric Badger commented on YARN-8259: --- bq. If hidepid option is used by system administrator, yarn user

[jira] [Commented] (YARN-8259) Revisit liveliness checks for Docker containers

2018-05-21 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16483032#comment-16483032 ] Jason Lowe commented on YARN-8259: -- I do agree with Shane that there are already subsystems that currently

[jira] [Commented] (YARN-8259) Revisit liveliness checks for Docker containers

2018-05-21 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16483029#comment-16483029 ] Jason Lowe commented on YARN-8259: -- Ah comment race with [~eyang], I'll defer until his concerns are

[jira] [Commented] (YARN-8259) Revisit liveliness checks for Docker containers

2018-05-21 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16483028#comment-16483028 ] Jason Lowe commented on YARN-8259: -- Thanks for the patch! +1 lgtm. I'll commit this tomorrow if there

[jira] [Commented] (YARN-8259) Revisit liveliness checks for Docker containers

2018-05-21 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16482992#comment-16482992 ] Eric Yang commented on YARN-8259: - If I am not mistaken, DockerContainerRuntime is running as part of node

[jira] [Commented] (YARN-8259) Revisit liveliness checks for Docker containers

2018-05-21 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16482729#comment-16482729 ] genericqa commented on YARN-8259: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||