[jira] [Commented] (YARN-8284) get_docker_command refactoring

2018-05-16 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477574#comment-16477574 ] Hudson commented on YARN-8284: -- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14208 (See

[jira] [Commented] (YARN-8284) get_docker_command refactoring

2018-05-16 Thread Eric Badger (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477555#comment-16477555 ] Eric Badger commented on YARN-8284: --- Thanks [~jlowe] and [~eyang]! > get_docker_command refactoring >

[jira] [Commented] (YARN-8284) get_docker_command refactoring

2018-05-15 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476577#comment-16476577 ] Jason Lowe commented on YARN-8284: -- Thanks for updating the patch! +1 lgtm. I'll commit this tomorrow if

[jira] [Commented] (YARN-8284) get_docker_command refactoring

2018-05-15 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476196#comment-16476196 ] genericqa commented on YARN-8284: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-8284) get_docker_command refactoring

2018-05-15 Thread Eric Badger (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476057#comment-16476057 ] Eric Badger commented on YARN-8284: --- [~jlowe], thanks for the review! Fixed the whitespace issue and also

[jira] [Commented] (YARN-8284) get_docker_command refactoring

2018-05-15 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476004#comment-16476004 ] Jason Lowe commented on YARN-8284: -- Thanks for the patch! In addition to moving the common docker binary

[jira] [Commented] (YARN-8284) get_docker_command refactoring

2018-05-14 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16474826#comment-16474826 ] Eric Yang commented on YARN-8284: - +1 looks good to me. > get_docker_command refactoring >

[jira] [Commented] (YARN-8284) get_docker_command refactoring

2018-05-14 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16474712#comment-16474712 ] genericqa commented on YARN-8284: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||