[jira] [Commented] (YARN-8680) YARN NM: Implement Iterable Abstraction for LocalResourceTrackerstate

2018-09-13 Thread Pradeep Ambati (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16613886#comment-16613886 ] Pradeep Ambati commented on YARN-8680: -- Thanks for the review [~jlowe]. > YARN NM: Implement

[jira] [Commented] (YARN-8680) YARN NM: Implement Iterable Abstraction for LocalResourceTrackerstate

2018-09-13 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16613878#comment-16613878 ] Jason Lowe commented on YARN-8680: -- Thanks for updating the patch! +1 lgtm. Committing this. > YARN

[jira] [Commented] (YARN-8680) YARN NM: Implement Iterable Abstraction for LocalResourceTrackerstate

2018-09-11 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611492#comment-16611492 ] Hadoop QA commented on YARN-8680: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-8680) YARN NM: Implement Iterable Abstraction for LocalResourceTrackerstate

2018-09-11 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610844#comment-16610844 ] Hadoop QA commented on YARN-8680: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-8680) YARN NM: Implement Iterable Abstraction for LocalResourceTrackerstate

2018-09-10 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609821#comment-16609821 ] Jason Lowe commented on YARN-8680: -- Thanks for updating the patch! In loadUserLocalizedResources for

[jira] [Commented] (YARN-8680) YARN NM: Implement Iterable Abstraction for LocalResourceTrackerstate

2018-09-06 Thread Pradeep Ambati (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605998#comment-16605998 ] Pradeep Ambati commented on YARN-8680: -- Thanks for the review! [~jlowe] I have addressed all the

[jira] [Commented] (YARN-8680) YARN NM: Implement Iterable Abstraction for LocalResourceTrackerstate

2018-09-06 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605993#comment-16605993 ] Hadoop QA commented on YARN-8680: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-8680) YARN NM: Implement Iterable Abstraction for LocalResourceTrackerstate

2018-09-04 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16603616#comment-16603616 ] Jason Lowe commented on YARN-8680: -- Thanks for updating the patch! seekPastPrefix needs to handle

[jira] [Commented] (YARN-8680) YARN NM: Implement Iterable Abstraction for LocalResourceTrackerstate

2018-09-03 Thread Pradeep Ambati (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602270#comment-16602270 ] Pradeep Ambati commented on YARN-8680: -- Thanks for the review [~jlowe]. I have addressed all but one

[jira] [Commented] (YARN-8680) YARN NM: Implement Iterable Abstraction for LocalResourceTrackerstate

2018-08-31 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16599442#comment-16599442 ] genericqa commented on YARN-8680: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-8680) YARN NM: Implement Iterable Abstraction for LocalResourceTrackerstate

2018-08-31 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16599328#comment-16599328 ] genericqa commented on YARN-8680: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-8680) YARN NM: Implement Iterable Abstraction for LocalResourceTrackerstate

2018-08-30 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16597623#comment-16597623 ] Jason Lowe commented on YARN-8680: -- Thanks for the patch! It would be cleaner to have a

[jira] [Commented] (YARN-8680) YARN NM: Implement Iterable Abstraction for LocalResourceTrackerstate

2018-08-30 Thread Pradeep Ambati (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16597499#comment-16597499 ] Pradeep Ambati commented on YARN-8680: -- Hi [~jlowe],  Can you please review the patch? > YARN NM:

[jira] [Commented] (YARN-8680) YARN NM: Implement Iterable Abstraction for LocalResourceTrackerstate

2018-08-29 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16596999#comment-16596999 ] Sunil Govindan commented on YARN-8680: -- Thanks [~pradeepambati]. I ll also try to help u review this. 

[jira] [Commented] (YARN-8680) YARN NM: Implement Iterable Abstraction for LocalResourceTrackerstate

2018-08-29 Thread Pradeep Ambati (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16596230#comment-16596230 ] Pradeep Ambati commented on YARN-8680: -- Hi [~sunilg],   This jira is marked as critical for 3.2. I

[jira] [Commented] (YARN-8680) YARN NM: Implement Iterable Abstraction for LocalResourceTrackerstate

2018-08-28 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16595939#comment-16595939 ] Sunil Govindan commented on YARN-8680: -- Hi [~pradeepambati] As this jira is marked for 3.2 as a

[jira] [Commented] (YARN-8680) YARN NM: Implement Iterable Abstraction for LocalResourceTrackerstate

2018-08-27 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16593804#comment-16593804 ] genericqa commented on YARN-8680: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-8680) YARN NM: Implement Iterable Abstraction for LocalResourceTrackerstate

2018-08-25 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16592723#comment-16592723 ] genericqa commented on YARN-8680: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-8680) YARN NM: Implement Iterable Abstraction for LocalResourceTrackerstate

2018-08-25 Thread Pradeep Ambati (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16592706#comment-16592706 ] Pradeep Ambati commented on YARN-8680: -- Main idea in the fix was taken from [~jlowe] comment (added