[jira] [Commented] (YARN-8763) Add WebSocket logic to the Node Manager web server to establish servlet

2018-11-08 Thread Wangda Tan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680570#comment-16680570 ] Wangda Tan commented on YARN-8763: -- [~sunilg] , I highly suggest reverting this from bran

[jira] [Commented] (YARN-8763) Add WebSocket logic to the Node Manager web server to establish servlet

2018-11-08 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679369#comment-16679369 ] Sunil Govindan commented on YARN-8763: -- Hi [~eyang] I am getting errors of undefined

[jira] [Commented] (YARN-8763) Add WebSocket logic to the Node Manager web server to establish servlet

2018-11-08 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679446#comment-16679446 ] Sunil Govindan commented on YARN-8763: -- Sorry. Apologies. I had some old files in my

[jira] [Commented] (YARN-8763) Add WebSocket logic to the Node Manager web server to establish servlet

2018-10-08 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16642268#comment-16642268 ] Hudson commented on YARN-8763: -- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #151

[jira] [Commented] (YARN-8763) Add WebSocket logic to the Node Manager web server to establish servlet

2018-10-08 Thread Zian Chen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16642219#comment-16642219 ] Zian Chen commented on YARN-8763: - [~eyang], thanks for +1. Could you help me commit this

[jira] [Commented] (YARN-8763) Add WebSocket logic to the Node Manager web server to establish servlet

2018-10-08 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16642203#comment-16642203 ] Eric Yang commented on YARN-8763: - +1 on patch 5. > Add WebSocket logic to the Node Manag

[jira] [Commented] (YARN-8763) Add WebSocket logic to the Node Manager web server to establish servlet

2018-10-05 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16640531#comment-16640531 ] Hadoop QA commented on YARN-8763: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (YARN-8763) Add WebSocket logic to the Node Manager web server to establish servlet

2018-10-05 Thread Zian Chen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16640482#comment-16640482 ] Zian Chen commented on YARN-8763: - [~eyang] sorry for getting back late. I'm curious why T

[jira] [Commented] (YARN-8763) Add WebSocket logic to the Node Manager web server to establish servlet

2018-10-04 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16639006#comment-16639006 ] Eric Yang commented on YARN-8763: - [~Zian Chen] DefaultContainerExecutor execContainer met

[jira] [Commented] (YARN-8763) Add WebSocket logic to the Node Manager web server to establish servlet

2018-10-04 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638918#comment-16638918 ] Hadoop QA commented on YARN-8763: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-8763) Add WebSocket logic to the Node Manager web server to establish servlet

2018-10-04 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638901#comment-16638901 ] Eric Yang commented on YARN-8763: - [~Zian Chen] +1 on patch 4. One small improvement that

[jira] [Commented] (YARN-8763) Add WebSocket logic to the Node Manager web server to establish servlet

2018-10-04 Thread Zian Chen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638730#comment-16638730 ] Zian Chen commented on YARN-8763: - [~eyang], just uploaded patch 004, please help review i

[jira] [Commented] (YARN-8763) Add WebSocket logic to the Node Manager web server to establish servlet

2018-10-04 Thread Zian Chen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638658#comment-16638658 ] Zian Chen commented on YARN-8763: - Thanks for the comments, Eric, I'll update the patch la

[jira] [Commented] (YARN-8763) Add WebSocket logic to the Node Manager web server to establish servlet

2018-10-03 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637100#comment-16637100 ] Eric Yang commented on YARN-8763: - [~Zian Chen] Thank you for the patch. A few minor prob

[jira] [Commented] (YARN-8763) Add WebSocket logic to the Node Manager web server to establish servlet

2018-10-03 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16636687#comment-16636687 ] Hadoop QA commented on YARN-8763: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-8763) Add WebSocket logic to the Node Manager web server to establish servlet

2018-10-03 Thread Zian Chen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16636543#comment-16636543 ] Zian Chen commented on YARN-8763: - Hi [~eyang], could you help review patch 003? It addres

[jira] [Commented] (YARN-8763) Add WebSocket logic to the Node Manager web server to establish servlet

2018-10-01 Thread Zian Chen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16634486#comment-16634486 ] Zian Chen commented on YARN-8763: - Hi [~eyang] , make sense.  I'll work on patch 003 to ad

[jira] [Commented] (YARN-8763) Add WebSocket logic to the Node Manager web server to establish servlet

2018-09-29 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16633062#comment-16633062 ] Eric Yang commented on YARN-8763: - [~Zian Chen] Thank you for the patch, in TestNMWebServe

[jira] [Commented] (YARN-8763) Add WebSocket logic to the Node Manager web server to establish servlet

2018-09-28 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16632702#comment-16632702 ] Hadoop QA commented on YARN-8763: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-8763) Add WebSocket logic to the Node Manager web server to establish servlet

2018-09-28 Thread Zian Chen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16632636#comment-16632636 ] Zian Chen commented on YARN-8763: - Update patch-002 for review. really appreciate the help

[jira] [Commented] (YARN-8763) Add WebSocket logic to the Node Manager web server to establish servlet

2018-09-11 Thread Zian Chen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610186#comment-16610186 ] Zian Chen commented on YARN-8763: - Hi [~eyang], thanks for the detailed suggestions. Make

[jira] [Commented] (YARN-8763) Add WebSocket logic to the Node Manager web server to establish servlet

2018-09-10 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16609972#comment-16609972 ] Hadoop QA commented on YARN-8763: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-8763) Add WebSocket logic to the Node Manager web server to establish servlet

2018-09-10 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16609926#comment-16609926 ] Eric Yang commented on YARN-8763: - [~Zian Chen] Thank you for the patch. We usually have

[jira] [Commented] (YARN-8763) Add WebSocket logic to the Node Manager web server to establish servlet

2018-09-10 Thread Zian Chen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16609919#comment-16609919 ] Zian Chen commented on YARN-8763: - Hi [~eyang], could you help review the patch? Thanks!

[jira] [Commented] (YARN-8763) Add WebSocket logic to the Node Manager web server to establish servlet

2018-09-10 Thread Zian Chen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16609917#comment-16609917 ] Zian Chen commented on YARN-8763: - Provide initial patch for this. > Add WebSocket logic