[jira] [Commented] (YARN-8842) Update QueueMetrics with custom resource values

2018-10-16 Thread Haibo Chen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652443#comment-16652443 ] Haibo Chen commented on YARN-8842: -- +1 on the latest patch. I'll fix the one minor indent

[jira] [Commented] (YARN-8842) Update QueueMetrics with custom resource values

2018-10-15 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16651133#comment-16651133 ] Hadoop QA commented on YARN-8842: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-8842) Update QueueMetrics with custom resource values

2018-10-15 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16651109#comment-16651109 ] Hadoop QA commented on YARN-8842: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-8842) Update QueueMetrics with custom resource values

2018-10-15 Thread Szilard Nemeth (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16651012#comment-16651012 ] Szilard Nemeth commented on YARN-8842: -- Hi [~haibochen]! I applied the changes you su

[jira] [Commented] (YARN-8842) Update QueueMetrics with custom resource values

2018-10-15 Thread Haibo Chen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16650450#comment-16650450 ] Haibo Chen commented on YARN-8842: -- Thanks [~snemeth] for updating the patch!  The patch

[jira] [Commented] (YARN-8842) Update QueueMetrics with custom resource values

2018-10-13 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16649251#comment-16649251 ] Hadoop QA commented on YARN-8842: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-8842) Update QueueMetrics with custom resource values

2018-10-13 Thread Szilard Nemeth (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16649193#comment-16649193 ] Szilard Nemeth commented on YARN-8842: -- Hi [~haibochen]! Fixed some checkstyle issues

[jira] [Commented] (YARN-8842) Update QueueMetrics with custom resource values

2018-10-12 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16648749#comment-16648749 ] Hadoop QA commented on YARN-8842: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-8842) Update QueueMetrics with custom resource values

2018-10-12 Thread Szilard Nemeth (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16648649#comment-16648649 ] Szilard Nemeth commented on YARN-8842: -- I cleaned up the patch a little bit. Let's wa

[jira] [Commented] (YARN-8842) Update QueueMetrics with custom resource values

2018-10-12 Thread Szilard Nemeth (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16648407#comment-16648407 ] Szilard Nemeth commented on YARN-8842: -- Hi [~wilfreds]! Thanks for the review! > Upd

[jira] [Commented] (YARN-8842) Update QueueMetrics with custom resource values

2018-10-11 Thread Wilfred Spiegelenburg (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16647197#comment-16647197 ] Wilfred Spiegelenburg commented on YARN-8842: - Thank you for the updated patch

[jira] [Commented] (YARN-8842) Update QueueMetrics with custom resource values

2018-10-11 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16647160#comment-16647160 ] Hadoop QA commented on YARN-8842: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-8842) Update QueueMetrics with custom resource values

2018-10-11 Thread Szilard Nemeth (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16646831#comment-16646831 ] Szilard Nemeth commented on YARN-8842: -- Based on our offline discussion with [~wilfre

[jira] [Commented] (YARN-8842) Update QueueMetrics with custom resource values

2018-10-10 Thread Szilard Nemeth (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16645960#comment-16645960 ] Szilard Nemeth commented on YARN-8842: -- Hi [~wilfreds]! Thanks for coming back to th

[jira] [Commented] (YARN-8842) Update QueueMetrics with custom resource values

2018-10-10 Thread Wilfred Spiegelenburg (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16645868#comment-16645868 ] Wilfred Spiegelenburg commented on YARN-8842: - The test failure is not related

[jira] [Commented] (YARN-8842) Update QueueMetrics with custom resource values

2018-10-09 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16644532#comment-16644532 ] Hadoop QA commented on YARN-8842: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-8842) Update QueueMetrics with custom resource values

2018-10-09 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16644482#comment-16644482 ] Hadoop QA commented on YARN-8842: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-8842) Update QueueMetrics with custom resource values

2018-10-09 Thread Wilfred Spiegelenburg (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16644473#comment-16644473 ] Wilfred Spiegelenburg commented on YARN-8842: - Thank you [~snemeth]. I am glad

[jira] [Commented] (YARN-8842) Update QueueMetrics with custom resource values

2018-10-09 Thread Szilard Nemeth (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16644398#comment-16644398 ] Szilard Nemeth commented on YARN-8842: -- patch008 fixes a missing null check > Update

[jira] [Commented] (YARN-8842) Update QueueMetrics with custom resource values

2018-10-09 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16644380#comment-16644380 ] Hadoop QA commented on YARN-8842: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-8842) Update QueueMetrics with custom resource values

2018-10-09 Thread Szilard Nemeth (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16644207#comment-16644207 ] Szilard Nemeth commented on YARN-8842: -- According to our offline discussion with [~ha

[jira] [Commented] (YARN-8842) Update QueueMetrics with custom resource values

2018-10-06 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16640817#comment-16640817 ] Hadoop QA commented on YARN-8842: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-8842) Update QueueMetrics with custom resource values

2018-10-06 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16640633#comment-16640633 ] Hadoop QA commented on YARN-8842: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-8842) Update QueueMetrics with custom resource values

2018-10-05 Thread Szilard Nemeth (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16640581#comment-16640581 ] Szilard Nemeth commented on YARN-8842: -- patch004 fixes newline and most of the checks

[jira] [Commented] (YARN-8842) Update QueueMetrics with custom resource values

2018-10-05 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16640532#comment-16640532 ] Hadoop QA commented on YARN-8842: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-8842) Update QueueMetrics with custom resource values

2018-10-05 Thread Haibo Chen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16640491#comment-16640491 ] Haibo Chen commented on YARN-8842: -- Thanks [~snemeth] for the patch. For a clean-code pe

[jira] [Commented] (YARN-8842) Update QueueMetrics with custom resource values

2018-10-04 Thread Szilard Nemeth (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16639218#comment-16639218 ] Szilard Nemeth commented on YARN-8842: -- About your second comment: I think it does ma

[jira] [Commented] (YARN-8842) Update QueueMetrics with custom resource values

2018-10-04 Thread Szilard Nemeth (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16639171#comment-16639171 ] Szilard Nemeth commented on YARN-8842: -- Hi [~wilfreds]! Thanks for the comments. 1. G

[jira] [Commented] (YARN-8842) Update QueueMetrics with custom resource values

2018-10-04 Thread Wilfred Spiegelenburg (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638239#comment-16638239 ] Wilfred Spiegelenburg commented on YARN-8842: - One further remark that showed

[jira] [Commented] (YARN-8842) Update QueueMetrics with custom resource values

2018-10-04 Thread Wilfred Spiegelenburg (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637915#comment-16637915 ] Wilfred Spiegelenburg commented on YARN-8842: - Thank you for splitting this of

[jira] [Commented] (YARN-8842) Update QueueMetrics with custom resource values

2018-10-03 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16636559#comment-16636559 ] Hadoop QA commented on YARN-8842: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||