[jira] [Commented] (YARN-8881) Phase 1 - Add basic pluggable device plugin framework

[ https://issues.apache.org/jira/browse/YARN-8881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689699#comment-16689699 ] Wangda Tan commented on YARN-8881: -- +1 to the latest patch, will commit later today if no objections.

[jira] [Commented] (YARN-8881) Phase 1 - Add basic pluggable device plugin framework

[ https://issues.apache.org/jira/browse/YARN-8881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689025#comment-16689025 ] Zhankun Tang commented on YARN-8881: [~sunilg] ,  [~cheersyang] , the test case seems not related.

[jira] [Commented] (YARN-8881) Phase 1 - Add basic pluggable device plugin framework

[ https://issues.apache.org/jira/browse/YARN-8881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688991#comment-16688991 ] Hadoop QA commented on YARN-8881: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-8881) Phase 1 - Add basic pluggable device plugin framework

[ https://issues.apache.org/jira/browse/YARN-8881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688135#comment-16688135 ] Hadoop QA commented on YARN-8881: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-8881) Phase 1 - Add basic pluggable device plugin framework

[ https://issues.apache.org/jira/browse/YARN-8881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687713#comment-16687713 ] Zhankun Tang commented on YARN-8881: [~sunilg] ,   {quote}I am like +0 for this change. 

[jira] [Commented] (YARN-8881) Phase 1 - Add basic pluggable device plugin framework

[ https://issues.apache.org/jira/browse/YARN-8881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687701#comment-16687701 ] Zhankun Tang commented on YARN-8881: [~sunilg], Thanks for the review! Will fix point 1,2,3,4,5.

[jira] [Commented] (YARN-8881) Phase 1 - Add basic pluggable device plugin framework

[ https://issues.apache.org/jira/browse/YARN-8881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687619#comment-16687619 ] Sunil Govindan commented on YARN-8881: -- Thanks [~tangzhankun]  Few more minor comments # In Device

[jira] [Commented] (YARN-8881) Phase 1 - Add basic pluggable device plugin framework

[ https://issues.apache.org/jira/browse/YARN-8881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687406#comment-16687406 ] Zhankun Tang commented on YARN-8881: [~csingh], Thanks for the review! {quote}It checks if the

[jira] [Commented] (YARN-8881) Phase 1 - Add basic pluggable device plugin framework

[ https://issues.apache.org/jira/browse/YARN-8881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687244#comment-16687244 ] Chandni Singh commented on YARN-8881: - Hi [~tangzhankun], Thanks for the patch. I have some

[jira] [Commented] (YARN-8881) Phase 1 - Add basic pluggable device plugin framework

[ https://issues.apache.org/jira/browse/YARN-8881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16685965#comment-16685965 ] Hadoop QA commented on YARN-8881: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-8881) Phase 1 - Add basic pluggable device plugin framework

[ https://issues.apache.org/jira/browse/YARN-8881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16685868#comment-16685868 ] Zhankun Tang commented on YARN-8881: [~leftnoteasy], [~sunilg] . Ok. Will change the type to int.

[jira] [Commented] (YARN-8881) Phase 1 - Add basic pluggable device plugin framework

[ https://issues.apache.org/jira/browse/YARN-8881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16685605#comment-16685605 ] Wangda Tan commented on YARN-8881: -- Thanks [~tangzhankun], Regarding Integer vs. int, I would suggest

[jira] [Commented] (YARN-8881) Phase 1 - Add basic pluggable device plugin framework

[ https://issues.apache.org/jira/browse/YARN-8881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16685355#comment-16685355 ] Zhankun Tang commented on YARN-8881: [~sunilg], Many thanks for the review! {quote}In Device class,

[jira] [Commented] (YARN-8881) Phase 1 - Add basic pluggable device plugin framework

[ https://issues.apache.org/jira/browse/YARN-8881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16685247#comment-16685247 ] Sunil Govindan commented on YARN-8881: -- Thanks [~tangzhankun] Few comments # In Device class, any