[jira] [Commented] (YARN-8902) Add volume manager that manages CSI volume lifecycle

2018-11-11 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16683236#comment-16683236 ] Sunil Govindan commented on YARN-8902: -- Thanks [~cheersyang] Looks good to me. +1. C

[jira] [Commented] (YARN-8902) Add volume manager that manages CSI volume lifecycle

2018-11-09 Thread Weiwei Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681403#comment-16681403 ] Weiwei Yang commented on YARN-8902: --- Hi [~sunilg] #1 I've seen the timeout issue multip

[jira] [Commented] (YARN-8902) Add volume manager that manages CSI volume lifecycle

2018-11-09 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681349#comment-16681349 ] Sunil Govindan commented on YARN-8902: -- Hi [~cheersyang] Thanks for the patch. We ar

[jira] [Commented] (YARN-8902) Add volume manager that manages CSI volume lifecycle

2018-11-09 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681281#comment-16681281 ] Hadoop QA commented on YARN-8902: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-8902) Add volume manager that manages CSI volume lifecycle

2018-11-08 Thread Weiwei Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681002#comment-16681002 ] Weiwei Yang commented on YARN-8902: --- v9 patch uploaded, [~sunilg], pls take a look. Than

[jira] [Commented] (YARN-8902) Add volume manager that manages CSI volume lifecycle

2018-11-08 Thread Weiwei Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680998#comment-16680998 ] Weiwei Yang commented on YARN-8902: --- Hi [~sunilg] Pls see my response below, {quote}Cou

[jira] [Commented] (YARN-8902) Add volume manager that manages CSI volume lifecycle

2018-11-08 Thread Weiwei Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680950#comment-16680950 ] Weiwei Yang commented on YARN-8902: --- Hi [~sunilg] Pls seem my comments below {quote}In

[jira] [Commented] (YARN-8902) Add volume manager that manages CSI volume lifecycle

2018-11-08 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680952#comment-16680952 ] Sunil Govindan commented on YARN-8902: -- Few more comments 5. {code:java} try { Volum

[jira] [Commented] (YARN-8902) Add volume manager that manages CSI volume lifecycle

2018-11-08 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680848#comment-16680848 ] Sunil Govindan commented on YARN-8902: -- Thanks [~cheersyang]  Few comments. 1. In V

[jira] [Commented] (YARN-8902) Add volume manager that manages CSI volume lifecycle

2018-11-07 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678218#comment-16678218 ] Hadoop QA commented on YARN-8902: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-8902) Add volume manager that manages CSI volume lifecycle

2018-11-07 Thread Weiwei Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677981#comment-16677981 ] Weiwei Yang commented on YARN-8902: --- Hi [~sunilg] Thanks for the review, {quote}Does Cs

[jira] [Commented] (YARN-8902) Add volume manager that manages CSI volume lifecycle

2018-11-07 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677829#comment-16677829 ] Sunil Govindan commented on YARN-8902: -- Hi [~cheersyang] . Thank you. Few initial com

[jira] [Commented] (YARN-8902) Add volume manager that manages CSI volume lifecycle

2018-11-06 Thread Wangda Tan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677027#comment-16677027 ] Wangda Tan commented on YARN-8902: -- {quote}I prefer not to do this rename. As the package

[jira] [Commented] (YARN-8902) Add volume manager that manages CSI volume lifecycle

2018-11-06 Thread Weiwei Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16676381#comment-16676381 ] Weiwei Yang commented on YARN-8902: --- Hi [~leftnoteasy] {quote}org.apache.hadoop.yarn.ser

[jira] [Commented] (YARN-8902) Add volume manager that manages CSI volume lifecycle

2018-11-05 Thread Weiwei Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16676053#comment-16676053 ] Weiwei Yang commented on YARN-8902: --- Hi [~leftnoteasy] Thanks for the review comments.

[jira] [Commented] (YARN-8902) Add volume manager that manages CSI volume lifecycle

2018-11-05 Thread Wangda Tan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16675532#comment-16675532 ] Wangda Tan commented on YARN-8902: -- Thanks [~cheersyang] , a couple of high-level questio

[jira] [Commented] (YARN-8902) Add volume manager that manages CSI volume lifecycle

2018-10-31 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16670720#comment-16670720 ] Hadoop QA commented on YARN-8902: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-8902) Add volume manager that manages CSI volume lifecycle

2018-10-30 Thread Weiwei Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16669572#comment-16669572 ] Weiwei Yang commented on YARN-8902: --- v7 patch fixed the findbugs and checkstyle issues

[jira] [Commented] (YARN-8902) Add volume manager that manages CSI volume lifecycle

2018-10-30 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16669269#comment-16669269 ] Hadoop QA commented on YARN-8902: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-8902) Add volume manager that manages CSI volume lifecycle

2018-10-30 Thread Weiwei Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668389#comment-16668389 ] Weiwei Yang commented on YARN-8902: --- [~leftnoteasy], [~sunilg], please help to review.

[jira] [Commented] (YARN-8902) Add volume manager that manages CSI volume lifecycle

2018-10-30 Thread Weiwei Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668387#comment-16668387 ] Weiwei Yang commented on YARN-8902: --- v6 patch uploaded, major change is to remove the as

[jira] [Commented] (YARN-8902) Add volume manager that manages CSI volume lifecycle

2018-10-27 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1007#comment-1007 ] Hadoop QA commented on YARN-8902: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-8902) Add volume manager that manages CSI volume lifecycle

2018-10-26 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16665668#comment-16665668 ] Hadoop QA commented on YARN-8902: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-8902) Add volume manager that manages CSI volume lifecycle

2018-10-26 Thread Weiwei Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16665192#comment-16665192 ] Weiwei Yang commented on YARN-8902: --- Hi [~sunilg] Thanks for the review. # I agree we

[jira] [Commented] (YARN-8902) Add volume manager that manages CSI volume lifecycle

2018-10-26 Thread Sunil Govindan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16665137#comment-16665137 ] Sunil Govindan commented on YARN-8902: -- Hi [~cheersyang] Thanks for the patch. Some

[jira] [Commented] (YARN-8902) Add volume manager that manages CSI volume lifecycle

2018-10-26 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16665070#comment-16665070 ] Hadoop QA commented on YARN-8902: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-8902) Add volume manager that manages CSI volume lifecycle

2018-10-23 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661787#comment-16661787 ] Hadoop QA commented on YARN-8902: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-8902) Add volume manager that manages CSI volume lifecycle

2018-10-23 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16660886#comment-16660886 ] Hadoop QA commented on YARN-8902: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||