[jira] [Commented] (YARN-8916) Define a constant "docker" string in "ContainerRuntimeConstants.java" for better maintainability

2018-10-19 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16657158#comment-16657158 ] Hudson commented on YARN-8916: -- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #15270 (See

[jira] [Commented] (YARN-8916) Define a constant "docker" string in "ContainerRuntimeConstants.java" for better maintainability

2018-10-19 Thread Wangda Tan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16657057#comment-16657057 ] Wangda Tan commented on YARN-8916: -- +1, thanks [~tangzhankun]. > Define a constant "docker" string in

[jira] [Commented] (YARN-8916) Define a constant "docker" string in "ContainerRuntimeConstants.java" for better maintainability

2018-10-19 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16657034#comment-16657034 ] Hadoop QA commented on YARN-8916: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-8916) Define a constant "docker" string in "ContainerRuntimeConstants.java" for better maintainability

2018-10-19 Thread Zhankun Tang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16656936#comment-16656936 ] Zhankun Tang commented on YARN-8916: [~ebadger] , Thanks for the review! > Define a constant "docker"

[jira] [Commented] (YARN-8916) Define a constant "docker" string in "ContainerRuntimeConstants.java" for better maintainability

2018-10-19 Thread Eric Badger (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16656932#comment-16656932 ] Eric Badger commented on YARN-8916: --- +1 lgtm (non-binding), pending hadoopqa > Define a constant

[jira] [Commented] (YARN-8916) Define a constant "docker" string in "ContainerRuntimeConstants.java" for better maintainability

2018-10-19 Thread Zhankun Tang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16656844#comment-16656844 ] Zhankun Tang commented on YARN-8916: Attached a patch. Please review. [~sunilg],