[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700333#comment-16700333
]
Hadoop QA commented on YARN-8986:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700155#comment-16700155
]
Charo Zhang commented on YARN-8986:
---
[~eyang] YARN-8986-branch-3.1.001.patch and
[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16699779#comment-16699779
]
Hudson commented on YARN-8986:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #15505 (See
[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16699773#comment-16699773
]
Eric Yang commented on YARN-8986:
-
[~Charo Zhang] I committed this to trunk. The patch doesn't apply to
[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697661#comment-16697661
]
Eric Yang commented on YARN-8986:
-
[~Charo Zhang] Thank you for patch 009. This version looks good to me.
[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16696510#comment-16696510
]
Charo Zhang commented on YARN-8986:
---
[~eyang] All unit test cases passed the in 008 patch.:D
Is there
[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16696494#comment-16696494
]
Hadoop QA commented on YARN-8986:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16696395#comment-16696395
]
Eric Yang commented on YARN-8986:
-
[~Charo Zhang] The test can be run locally using in
[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16696318#comment-16696318
]
Charo Zhang commented on YARN-8986:
---
[~eyang] The unit test failure of
[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16696123#comment-16696123
]
Eric Yang commented on YARN-8986:
-
[~liuxun323] Docker container can support one bridge network, and one
[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16695882#comment-16695882
]
Hadoop QA commented on YARN-8986:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16695770#comment-16695770
]
Xun Liu commented on YARN-8986:
---
hi, [~Charo Zhang], [~eyang]
Configure network plugins using calico,
[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16695755#comment-16695755
]
Charo Zhang commented on YARN-8986:
---
[~eyang] i refactored add_ports_mapping_to_command and related test
[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16695740#comment-16695740
]
Hadoop QA commented on YARN-8986:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16695628#comment-16695628
]
Xun Liu commented on YARN-8986:
---
hi, [~Charo Zhang], [~eyang]
{code:java}
+ if (network_name != NULL) {
+
[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16695589#comment-16695589
]
Hadoop QA commented on YARN-8986:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16695549#comment-16695549
]
Hadoop QA commented on YARN-8986:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16695040#comment-16695040
]
Eric Yang commented on YARN-8986:
-
[~Charo Zhang] Jenkins runs with docker 17.05.0-ce. Hadoop compilation
[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694895#comment-16694895
]
Hadoop QA commented on YARN-8986:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694740#comment-16694740
]
Charo Zhang commented on YARN-8986:
---
[~eyang] what's version of Docker in Jenkins node. Does it support
[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694692#comment-16694692
]
Hadoop QA commented on YARN-8986:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694463#comment-16694463
]
Hadoop QA commented on YARN-8986:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694429#comment-16694429
]
Hadoop QA commented on YARN-8986:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694335#comment-16694335
]
Eric Yang commented on YARN-8986:
-
[~Charo Zhang]
[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694340#comment-16694340
]
Charo Zhang commented on YARN-8986:
---
[~eyang] i understand. I set network_name=bridge when it's not
[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694313#comment-16694313
]
Charo Zhang commented on YARN-8986:
---
[~eyang] I know what your mean, it will use bridge network as
[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694263#comment-16694263
]
Eric Yang commented on YARN-8986:
-
[~Charo Zhang] If I am not mistaken, the [default network
[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694176#comment-16694176
]
Hadoop QA commented on YARN-8986:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694099#comment-16694099
]
Charo Zhang commented on YARN-8986:
---
[~eyang]
1, network_names free added in 006 patch.
2, when network
[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16693937#comment-16693937
]
Eric Yang commented on YARN-8986:
-
[~Charo Zhang] Patch 005 seems to return from
[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16693857#comment-16693857
]
Hadoop QA commented on YARN-8986:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16693797#comment-16693797
]
Charo Zhang commented on YARN-8986:
---
[~eyang] I think network_name is allowed to not exist, and i find
[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16693584#comment-16693584
]
Eric Yang commented on YARN-8986:
-
[~Charo Zhang] add_ports_mapping_to_command assumes that network_name
[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16693507#comment-16693507
]
Hadoop QA commented on YARN-8986:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16693392#comment-16693392
]
Charo Zhang commented on YARN-8986:
---
[~eyang] “ports-mapping” test has added to
[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16692626#comment-16692626
]
Eric Yang commented on YARN-8986:
-
[~Charo Zhang] Patch 003 looks very close to final product. Can you
[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691714#comment-16691714
]
Charo Zhang commented on YARN-8986:
---
[~eyang] I added unit test cases to test_docker_util.cc, and
[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691307#comment-16691307
]
Hadoop QA commented on YARN-8986:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691293#comment-16691293
]
Hadoop QA commented on YARN-8986:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691259#comment-16691259
]
Hadoop QA commented on YARN-8986:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691216#comment-16691216
]
Hadoop QA commented on YARN-8986:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691032#comment-16691032
]
Eric Yang commented on YARN-8986:
-
[~Charo Zhang] Thank you for the patch. You are right that set_network
[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690950#comment-16690950
]
Hadoop QA commented on YARN-8986:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690921#comment-16690921
]
Charo Zhang commented on YARN-8986:
---
[~eyang]According to you suggestions, i verify the network_name
[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690890#comment-16690890
]
Hadoop QA commented on YARN-8986:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690665#comment-16690665
]
Eric Yang commented on YARN-8986:
-
{code}char *docker_network_command = make_string("%s network inspect %s
[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690499#comment-16690499
]
Hadoop QA commented on YARN-8986:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690441#comment-16690441
]
Charo Zhang commented on YARN-8986:
---
[~eyang]Dose yarn have version requirement for Docker. I am using
[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689895#comment-16689895
]
Hadoop QA commented on YARN-8986:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689675#comment-16689675
]
Eric Yang commented on YARN-8986:
-
[~Charo Zhang] {quote}1, network name is only allowed by
[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689581#comment-16689581
]
Hadoop QA commented on YARN-8986:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689573#comment-16689573
]
Hadoop QA commented on YARN-8986:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689356#comment-16689356
]
Charo Zhang commented on YARN-8986:
---
[~eyang] Thanks for you suggestions. About 2/3/4 point, i will
[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688538#comment-16688538
]
Eric Yang commented on YARN-8986:
-
[~Charo Zhang] Thank you for the patch. It looks like in the right
[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688263#comment-16688263
]
Hadoop QA commented on YARN-8986:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687715#comment-16687715
]
Hadoop QA commented on YARN-8986:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687652#comment-16687652
]
Charo Zhang commented on YARN-8986:
---
[~eyang]Thanks for your interpretation, and i rewrote the patches
[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687588#comment-16687588
]
Xun Liu commented on YARN-8986:
---
[~Charo Zhang]，[~eyang]
Because hadoop submarine relies on this feature,
[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687516#comment-16687516
]
Eric Yang commented on YARN-8986:
-
[~Charo Zhang] {quote}"If you don’t want to preface the docker command
[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687402#comment-16687402
]
Charo Zhang commented on YARN-8986:
---
[~eyang]
1，YARN_CONTAINER_RUNTIME_DOCKER_PORTS_MAPPING support
[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686938#comment-16686938
]
Eric Yang commented on YARN-8986:
-
[~Charo Zhang] Thank you for the patch. This patch assumes YARN user
[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686823#comment-16686823
]
Hadoop QA commented on YARN-8986:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684529#comment-16684529
]
Eric Yang commented on YARN-8986:
-
[~Charo Zhang] User can define their own bridge network, and the name
[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684144#comment-16684144
]
Eric Yang commented on YARN-8986:
-
[~Charo Zhang] This task looks like a duplicate of YARN-5168. I think
[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683427#comment-16683427
]
Charo Zhang commented on YARN-8986:
---
[~liuxun323]The screenshot is our implemention based on yarn 3.1.1
[
https://issues.apache.org/jira/browse/YARN-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683370#comment-16683370
]
Xun Liu commented on YARN-8986:
---
The screenshot in your attachment, Isn't the port 80 inside the container
66 matches
Mail list logo
